CCIP-3899 fix sender encoding #14877
Merged
+101
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCIP-3791 fix comments
0xsuryansh
requested review from
RensR,
matYang,
jhweintraub and
RyanRHall
as code owners
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: |
|
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
RayXpub
previously approved these changes
Oct 22, 2024
RyanRHall
reviewed
Oct 22, 2024
Comment on lines
+1032
to
+1041
| vm.expectCall( | ||
| address(s_destRouter), | ||
| abi.encodeWithSelector( | ||
| IRouter.routeMessage.selector, | ||
| expectedAny2EvmMessage, | ||
| Internal.GAS_FOR_CALL_EXACT_CHECK, | ||
| message.gasLimit, | ||
| message.receiver | ||
| ) | ||
| ); |
RayXpub
approved these changes
Oct 23, 2024
|
0xsuryansh
removed request for
a team,
winder,
rstout,
asoliman92,
makramkd,
EasterTheBunny,
dimkouv,
mateusz-sekara and
0xnogo
Tofel
approved these changes
Oct 23, 2024
momentmaker
added a commit
that referenced
this pull request
Oct 23, 2024
* develop: rm gethwrappers from codeowners offchain (#14919) CCIP-3899 fix sender encoding (#14877) ccip: use unknown address type. (#14836) [chore] Add changeset entry for RequestRoundTracker fix (#14912) various Solidity Foundry updates (#14866) CCIP-3710 create new custom calldata L1 (DA) gas oracle (#14710) CCIP owns smoke test (#14906) core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion (#14861) CCIP-3730 Misc ccip onchain changes (#14845) Chain fee integration tests (#14829) release/2.17.0 -> develop (#14721) Solana: re-enable disabled test with updated version (#14892)
cedric-cordenier
pushed a commit
that referenced
this pull request
Oct 24, 2024
* CCIP-3899 fix sender encoding and comments CCIP-3791 fix comments * changeset for contracts * formatting fix * snapshot & wrapper * update workflow to include --ir-minimum * Revert "update workflow to include --ir-minimum" This reverts commit 72a3e58. * update workflow to include --ir-minimum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR