Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TACACS+]: Extract tacacs support functions into library and fix memory leak issue. #8659

Merged
merged 13 commits into from
Oct 14, 2021
Merged

[TACACS+]: Extract tacacs support functions into library and fix memory leak issue. #8659

merged 13 commits into from
Oct 14, 2021

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Sep 2, 2021 •
edited
Loading

This pull request extract tacacs support functions into library to share TACACS config file parse code with other project. Also fix memory leak issue in parse config code.

Why I did it

To support TACACS per command authorization, we need reuse the TACACS config file parse code in bash plugin project.

How I did it

Add libtacsupport.pc.in to extract tacacs support functions into library.
Fix memory leak issue in TACACS config parse code by convert the dynamic memory allocation memory to static memory allocation.

How to verify it

Pass all current UT.
Check shared library generated manually.

Which release branch to backport (provide reason below if selected)

N/A

Description for the changelog

Extract tacacs support functions into library, this will share TACACS config file parse code with other project.
Also fix memory leak issue in parse config code.

A picture of a cute animal (not mandatory but encouraged)

@liuh-80 liuh-80 marked this pull request as ready for review September 10, 2021 01:33
@liuh-80 liuh-80 requested a review from lguohan as a code owner September 10, 2021 01:33
@liuh-80 liuh-80 mentioned this pull request Sep 10, 2021
Merged
@liuh-80 liuh-80 changed the title [TACACS+]: Add TACACS support library and fix memory leak issue. [TACACS+]: Extract tacacs support functions into library and fix memory leak issue. Sep 10, 2021
@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Oct 11, 2021 •
edited
Loading

@venkatmahalingam Could you help review, especially src/tacacs/pam/0006-Add-support-for-source-ip-address.patch?

qiluo-msft
qiluo-msft reviewed Oct 13, 2021
View reviewed changes
src/tacacs/pam/0006-Add-support-for-source-ip-address.patch Outdated
+ addrinfo created by getaddrinfo must be released with freeaddrinfo.
+ so source ip address will be stored in following static variables.
+ */
+ static struct addrinfo tac_source_address;
Copy link
Collaborator

@qiluo-msft qiluo-msft Oct 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 4 spaces instead of 1 tab #Closed

@liuh-80 liuh-80 merged commit a4ac69e into sonic-net:master Oct 14, 2021
@liuh-80 liuh-80 mentioned this pull request Nov 11, 2021
Merged
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Dec 13, 2021
@yxieca
Merged PR 5235789: [manual merge] manual merge github/master into int…
74d52c5 
…ernal branch

Related work items: sonic-net#525, sonic-net#534, sonic-net#909, sonic-net#927, sonic-net#930, sonic-net#934, sonic-net#935, sonic-net#937, sonic-net#938, sonic-net#939, sonic-net#940, sonic-net#943, sonic-net#944, sonic-net#945, sonic-net#946, sonic-net#948, sonic-net#1702, sonic-net#1923, sonic-net#1936, sonic-net#1942, sonic-net#2315, sonic-net#7281, sonic-net#7375, sonic-net#8659, sonic-net#8799, sonic-net#8868, sonic-net#8875, sonic-net#8935, sonic-net#8942, sonic-net#8956, sonic-net#8961, sonic-net#8966, sonic-net#8969, sonic-net#8971, sonic-net#8978, sonic-net#8991, sonic-net#8996, sonic-net#9001, sonic-net#9008, #3146150
liuh-80 added a commit to liuh-80/sonic-buildimage that referenced this pull request Jul 3, 2023
@liuh-80
[TACACS+]: Extract tacacs support functions into library and fix memo…
6f3e5ea 
…ry leak issue. (sonic-net#8659)

This pull request extract tacacs support functions into library to share TACACS config file parse code with other project. Also fix memory leak issue in parse config code.

Why I did it
    To support TACACS per command authorization, we need reuse the TACACS config file parse code in bash plugin project.

How I did it
    Add libtacsupport.pc.in to extract tacacs support functions into library.
    Fix memory leak issue in TACACS config parse code by convert the dynamic memory allocation memory to static memory allocation.

How to verify it
    Pass all current UT.
    Check shared library generated manually.

Which release branch to backport (provide reason below if selected)
    N/A

Description for the changelog
    Extract tacacs support functions into library, this will share TACACS config file parse code with other project.
    Also fix memory leak issue in parse config code.
liuh-80 added a commit to liuh-80/sonic-buildimage that referenced this pull request Jul 3, 2023
@liuh-80
[TACACS+]: Extract tacacs support functions into library and fix memo…
c5c92ba 
…ry leak issue. (sonic-net#8659)

This pull request extract tacacs support functions into library to share TACACS config file parse code with other project. Also fix memory leak issue in parse config code.

Why I did it
    To support TACACS per command authorization, we need reuse the TACACS config file parse code in bash plugin project.

How I did it
    Add libtacsupport.pc.in to extract tacacs support functions into library.
    Fix memory leak issue in TACACS config parse code by convert the dynamic memory allocation memory to static memory allocation.

How to verify it
    Pass all current UT.
    Check shared library generated manually.

Which release branch to backport (provide reason below if selected)
    N/A

Description for the changelog
    Extract tacacs support functions into library, this will share TACACS config file parse code with other project.
    Also fix memory leak issue in parse config code.
@liuh-80 liuh-80 mentioned this pull request Jul 3, 2023
Merged
10 tasks
qiluo-msft pushed a commit that referenced this pull request Jul 11, 2023
@liuh-80
[TACACS+]: Extract tacacs support functions into library and fix memo…
f75794a 
…ry leak issue. (#8659) (#15703)

This pull request extract tacacs support functions into library to share TACACS config file parse code with other project. Also fix memory leak issue in parse config code.

#### Why I did it
To support TACACS per command authorization, we need reuse the TACACS config file parse code in bash plugin project.

##### Work item tracking
- Microsoft ADO **(number only)**: 24433713

#### How I did it
Add libtacsupport.pc.in to extract tacacs support functions into library.
Fix memory leak issue in TACACS config parse code by convert the dynamic memory allocation memory to static memory allocation.

#### How to verify it
Pass all current UT.
Check shared library generated manually.

#### Tested branch (Please provide the tested image version)
Extract tacacs support functions into library, this will share TACACS config file parse code with other project.
Also fix memory leak issue in parse config code.

- [ ] SONiC.202012-15703.306864-1ef589c19

#### Description for the changelog
Extract tacacs support functions into library, this will share TACACS config file parse code with other project.
Also fix memory leak issue in parse config code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuh-80 @qiluo-msft