Fix dhcpmon bugs #9008
Merged
Fix dhcpmon bugs #9008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Oct 19, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Oct 20, 2021
* Exclude incrementing on aggregate device if packet received on mgmt interface * Fix DHCPv6 header offset calculation
5 tasks
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Dec 13, 2021
…ernal branch Related work items: sonic-net#525, sonic-net#534, sonic-net#909, sonic-net#927, sonic-net#930, sonic-net#934, sonic-net#935, sonic-net#937, sonic-net#938, sonic-net#939, sonic-net#940, sonic-net#943, sonic-net#944, sonic-net#945, sonic-net#946, sonic-net#948, sonic-net#1702, sonic-net#1923, sonic-net#1936, sonic-net#1942, sonic-net#2315, sonic-net#7281, sonic-net#7375, sonic-net#8659, sonic-net#8799, sonic-net#8868, sonic-net#8875, sonic-net#8935, sonic-net#8942, sonic-net#8956, sonic-net#8961, sonic-net#8966, sonic-net#8969, sonic-net#8971, sonic-net#8978, sonic-net#8991, sonic-net#8996, sonic-net#9001, sonic-net#9008, #3146150
kellyyeh
added a commit
to kellyyeh/sonic-buildimage
that referenced
this pull request
Apr 5, 2022
This reverts commit 14aca81.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Cherry picked from #8975
Why I did it
DHCPmon was crashing due to DHCPv6 header offset miscalculation
How I did it
Fix DHCPv6 header offset calculation in dhcpmon.
Get the correct option ID in order to get the inner DHCP message.
Fix 'dhcpmon', exclude incrementing the aggregate device if packets received on the MGMT interface.
The MGMT is incremented to check if DHCP packets are traveling through MGMT interface, it is not part of the aggregate device counters.
To allow checking the MGMT interface health as well, we need to check the counters of MGMT interface also, so in function 'dhcp_device_check_health' we need to check the current device counters, not only the aggregate device.
How to verify it
Configure DHCPv6 Relay
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)
Signed off by: Kelly Yeh kellyyeh@microsoft.com