[chassis-packet] minigraph parsing and BGP template changes #8966
Conversation
df46ed418e661a9bccdb2639d8873def356f8ba0 (HEAD -> master, origin/master, origin/HEAD) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (sonic-net#39) e487532e11cc0e97cfce573b6b997fdd0beeb660 [CI] Set up CI&PR with Azure Pipelines (sonic-net#38) 3c9f488490a1dbded20dbf2d8a88a5ab4dbda8df Replace swsssdk's SonicV2Connector with swsscommon's implementation (sonic-net#35) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
• Internal BGP Peering between LCx-ASICy is done using Loopback4096 • Internal BGP Peer will be classified as BGP_INTERNAL_NEIGHBOR with source updated as Loopback4096 • DEVICE_METADATA will have “switch_type” define as “chassis-packet”. We already have “voq” define. This will be used in BGP template. • Static Routes are define using SONiC schema. * Fixed Vlan Sub Interface Parsing in Graph when configured on Port-Channel. * Added Unit test cases of graph and BGP template changes. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
abdosi
force-pushed
the
chassis-packet
branch
from
d6eb589
to
3e74182
Compare
abdosi
changed the title
|
@anamehra Please review from your side also. |
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
| address-family ipv6 | ||
| network fc01::1/64 |
There was a problem hiding this comment.
These two lines are present in lines 40 and 41, seems repeated here
There was a problem hiding this comment.
working on another PR.. will fix it there.
| elif intf[0][0:11] == 'PortChannel': | ||
| pc_intfs[intf] = {} | ||
| pc_intfs[intf[0]] = {} | ||
| else: |
There was a problem hiding this comment.
Is this to allow the vlan sub interface table to pick up the portchannel subinterfaces? If so, where is the portchannel subinterface parsed?
There was a problem hiding this comment.
yes for PortChannel Vlan SubInterface. Parsing is done by existing code: https://github.com/Azure/sonic-buildimage/blob/6e2fecfa6b8be3cf2605c6673438339d20902a32/src/sonic-config-engine/minigraph.py#L448
| @@ -0,0 +1,60 @@ | |||
| # name lanes alias index speed asic_port_name role source_npu target_npu | |||
There was a problem hiding this comment.
Fix the file formatting as well
There was a problem hiding this comment.
working on another PR.. will fix it there.
| ) | ||
|
|
||
| def test_minigraph_bgp_packet_chassis_static_route(self): |
There was a problem hiding this comment.
add a tests for the single asic linecard?
There was a problem hiding this comment.
working on another PR.. will fix it there.
|
@arlakshm i will take care of this comment as part of next pr as these are not blocking. Would like to merge this PR |
Also address review comments for PR:sonic-net#8966 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
What I did: Fix the typo in Internal Peer Group template for Packet-based Chassis. Address Review comments of PR: [chassis-packet] minigraph parsing and BGP template changes #8966 - Static Route Parsing for Host - Formatting of chassis port_config.ini
…ernal branch Related work items: sonic-net#525, sonic-net#534, sonic-net#909, sonic-net#927, sonic-net#930, sonic-net#934, sonic-net#935, sonic-net#937, sonic-net#938, sonic-net#939, sonic-net#940, sonic-net#943, sonic-net#944, sonic-net#945, sonic-net#946, sonic-net#948, sonic-net#1702, sonic-net#1923, sonic-net#1936, sonic-net#1942, sonic-net#2315, sonic-net#7281, sonic-net#7375, sonic-net#8659, sonic-net#8799, sonic-net#8868, sonic-net#8875, sonic-net#8935, sonic-net#8942, sonic-net#8956, sonic-net#8961, sonic-net#8966, sonic-net#8969, sonic-net#8971, sonic-net#8978, sonic-net#8991, sonic-net#8996, sonic-net#9001, sonic-net#9008, #3146150
What I did:
How I Verify: