Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis-dump-load: Pin the redis package to use 3.5.3 #9001

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

saiarcot895
Copy link
Contributor

@saiarcot895 saiarcot895 commented Oct 18, 2021

Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).

Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.

Signed-off-by: Saikrishna Arcot sarcot@microsoft.com

Why I did it

How I did it

How to verify it

Make sure that redis-dump-load for Python 2 builds today.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).

Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@saiarcot895 saiarcot895 force-pushed the redis-pypi-version-fix branch from a9ac9e5 to 9722b38 Compare October 18, 2021 17:22
@MalteJ
Copy link

MalteJ commented Oct 18, 2021

Duplicate of / related to #8997 and #8999

@jusherma
Copy link
Contributor

Can this be double-committed into 202012 too please?

@qiluo-msft qiluo-msft merged commit 6432b50 into sonic-net:master Oct 19, 2021
liorghub pushed a commit to liorghub/sonic-buildimage that referenced this pull request Oct 19, 2021
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).

Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.

#### How to verify it

Make sure that redis-dump-load for Python 2 builds today.
lguohan pushed a commit that referenced this pull request Oct 19, 2021
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).

Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.

#### How to verify it

Make sure that redis-dump-load for Python 2 builds today.
qiluo-msft added a commit to qiluo-msft/sonic-buildimage that referenced this pull request Oct 20, 2021
judyjoseph pushed a commit that referenced this pull request Oct 21, 2021
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).

Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.

#### How to verify it

Make sure that redis-dump-load for Python 2 builds today.
@saiarcot895 saiarcot895 deleted the redis-pypi-version-fix branch October 27, 2021 17:53
praveen-li pushed a commit to praveen-li/sonic-buildimage that referenced this pull request Feb 15, 2022
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).

Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.

Make sure that redis-dump-load for Python 2 builds today.

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>

RB=2942507
G=lnos-reviewers
R=pchaudha,pmao,samaity,stexu,zxu
A=
AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this pull request Apr 14, 2022
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).

Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.

#### How to verify it

Make sure that redis-dump-load for Python 2 builds today.
guxianghong pushed a commit to CentecNetworks/sonic-buildimage that referenced this pull request May 21, 2022
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).

Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.

#### How to verify it

Make sure that redis-dump-load for Python 2 builds today.
liuyuefengcn pushed a commit to liuyuefengcn/sonic-net-buildimage that referenced this pull request Nov 14, 2023
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).

Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.

#### How to verify it

Make sure that redis-dump-load for Python 2 builds today.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants