merge azure sonic-swss master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Align with swss-common table name separator changes * Get appropriate table name separators by calling getTableNameSeparator() method * Align with new method name
* [pfcwd]: enable BIG_RED_SWITCH mode Signed-off-by: Sihui Han <sihan@microsoft.com> * update as comments
* Remove deprecated parameter from select() * Convert Selectables to new interface
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
* [crmorch]: neighbor used counter increased twice
…he fec configuration is blank (#468)
…other thread (#478) * Remove global mutex for the DB * Don't set event notifications on the switch * Adding notification handlers enable notification in syncd
Signed-off-by: Sihui Han <sihan@microsoft.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
* Fix tables handling race condition in buffermgr Signed-off-by: Andriy Moroz <c_andriym@mellanox.com> * Fixed status lose in loop Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Sihui Han <sihan@microsoft.com>
* [buffermgr]: remove the item from consumer queue if invalid Signed-off-by: Sihui Han <sihan@microsoft.com> * change error to task_invalid_entry Signed-off-by: Sihui Han <sihan@microsoft.com>
* Get the switch attribute SAI_SWITCH_ATTR_QOS_MAX_NUMBER_OF_CHILDS_PER_SCHEDULER_GROUP just once * Compress scheduler group creation time in 2.5 times * Inprove style
* Populate existing interface cache, bring down before configDone * simplify the logic and add logging Signed-off-by: Guohan Lu <gulv@microsoft.com> * add logging for publish event to state db Signed-off-by: Guohan Lu <gulv@microsoft.com>
Signed-off-by: Sihui Han <sihan@microsoft.com>
* [PFCWD]: Periodically poll WD counters For every action handler call commitCounters on a periodic basis Signed-off-by: marian-pritsak <marianp@mellanox.com> * Set polling interval to 1s
Without the return value check, it is possible that ifname is empty due to interface not found. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
…:PortConfigDone error (#503)
…pe (#504) Signed-off-by: Sihui Han <sihan@microsoft.com>
Signed-off-by: Guohan Lu <gulv@microsoft.com>
* Add new test case for ACL - Rule Priority New test case - I created 4 rules with priorities 10, 20, 30, 40, then I added a fifth rule with priority 21. Made sure they were all programmed correctly in the DB * new acl test case: added a rule in between configured rules I configured five rules with priorities 10, 20, 30, 40, then configured another rule with priority 21. Verified that all five rules were pushed to the ASICDB * Delete test_acl.py mistakenly added this file * removing redundant code by inserting via a loop * created helper function to check proper rule config
…ch (#506) * We have enough logging inside of the method. Remove the excessive one * Rewrite portsorch::validatespeed. Use true lazy approach to minimize SAI get operations on each port * Restore the missed attr.id * Rename validatePortSpeed to isSpeedSupported. Change logic to return true for erross also. Even we receive an error, we could move further. It's not critical
…#499) Signed-off-by: Sihui Han <sihan@microsoft.com>
Signed-off-by: Sihui Han <sihan@microsoft.com>
tylerlinp
pushed a commit
that referenced
this pull request
Apr 20, 2020
* Fix the stack-overflow issue in AclOrch::getTableById()
In case the table_id and m_mirrorTableId/m_mirrorTableId are empty
The function would be called recursively without ending.
```
If we have some rule that does not have table defined, it will trigger this issue.
(gdb) bt
#0 0x00007f77ac5af3a9 in swss::Logger::write (this=0x7f77ac801ec0 <swss::Logger::getInstance()::m_logger>, prio=swss::Logger::SWSS_DEBUG, fmt=0x7f77ac5f1690 ":> %s: enter")
at logger.cpp:209
#1 0x00000000004a5792 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2617
#2 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634
#3 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634
...
#20944 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634
#20945 0x00000000004ad3ce in AclOrch::doAclRuleTask (this=this@entry=0x1c722a0, consumer=...) at aclorch.cpp:2437
#20946 0x00000000004b04cd in AclOrch::doTask (this=0x1c722a0, consumer=...) at aclorch.cpp:2141
#20947 0x00000000004231b2 in Orch::doTask (this=0x1c722a0) at orch.cpp:369
#20948 0x000000000041c4e9 in OrchDaemon::start (this=this@entry=0x1c19960) at orchdaemon.cpp:376
#20949 0x0000000000409ffc in main (argc=<optimized out>, argv=0x7ffe2e392d68) at main.cpp:295
(gdb) p table_id
$1 = ""
(gdb) p m_mirrorTableId
$2 = ""
(gdb) p m_mirrorV6TableId
$3 = ""
```
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
How I verified it
Details if related