Chunking Context Refactor pt. 3: Address PR comments from pt. 2 #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
✅ This changes can build |
🟢 CI successful 🟢Thanks |
alexkirsz
force-pushed
the
alexkirsz/web-891-step-3-address-pr-comments-from-step-2
branch
2 times, most recently
from
2ed14e8 to
e8830f3
Compare
alexkirsz
commented
Apr 12, 2023
| optimize_ecmascript_chunks(EcmascriptChunksVc::cell(ecmascript_chunks)).await?; | ||
| let css_chunks = optimize_css_chunks(CssChunksVc::cell(css_chunks)).await?; | ||
|
|
||
| let chunks = ecmascript_chunks |
There was a problem hiding this comment.
This creates an explicit order between JS and CSS chunks in the output asset list, which causes the changes in snapshots.
| #[turbo_tasks::value_trait] | ||
| pub trait OptimizableChunk: Chunk + Asset { | ||
| fn get_optimizer(&self) -> ChunkOptimizerVc; | ||
| } |
There was a problem hiding this comment.
This is no longer relevant, as the chunking context has to know about all the different chunk types it can handle anyway. So instead of the chunks themselves implementing this trait, it's the chunking context which resolves chunks to particular types, and optimizes them accordingly.
kdy1
reviewed
Apr 13, 2023
| } | ||
|
|
||
| fn skip_unnessary_nodes<T>(trees: &mut IndexMap<FileSystemPathVc, Rc<RefCell<Node<T>>>>) { | ||
| for tree in trees.values_mut() { |
There was a problem hiding this comment.
I was checking if let mut tree = tree.get_mut() will work at the line below
alexkirsz
commented
Apr 13, 2023
| @@ -0,0 +1,220 @@ | |||
| use std::{cell::RefCell, mem::take, rc::Rc}; | |||
There was a problem hiding this comment.
This was extracted from turbopack_core::chunk::optimize. The only difference is that the tree now operates on a generic T type instead of ChunkVc.
sokra
approved these changes
Apr 14, 2023
alexkirsz
force-pushed
the
alexkirsz/web-891-step-3-address-pr-comments-from-step-2
branch
from
e8830f3 to
92f5e52
Compare
alexkirsz
added
the
pr: automerge
Benchmark for 33edc64Click to view benchmark
|
kodiakhq
bot
deleted the
alexkirsz/web-891-step-3-address-pr-comments-from-step-2
branch
sokra
added a commit
that referenced
this pull request
Apr 14, 2023
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Apr 14, 2023
### What? gives user code access to `process.env.PORT` as current server port avoid injecting env vars into code on server ### Why? it might need construct an addr to fetch from api routes fixes WEB-868 ### Turbopack changes * vercel/turborepo#4565 <!-- Tobias Koppers - Bind to IPv6 and IPv4 --> * vercel/turborepo#4570 <!-- Tobias Koppers - review follow ups --> * vercel/turborepo#4585 <!-- Tobias Koppers - fixup bind v6 PR: add missing listen call --> * ~vercel/turborepo#4546 <!-- Alex Kirszenberg - Chunking Context Refactor pt. 3: Address PR comments from pt. 2 --> * vercel/turborepo#4580 <!-- Tobias Koppers - remove circular dependency --> * vercel/turborepo#4582 <!-- Tobias Koppers - ignore internal and server-relative url() in CSS --> * vercel/turborepo#4579 <!-- Tobias Koppers - make node bootstrap asset lazy --> * vercel/turborepo#4581 <!-- Tobias Koppers - allow to create stress test for client components --> * vercel/turborepo#4584 <!-- Tobias Koppers - improve node.js receive timeout --> * vercel/turborepo#4583 <!-- Tobias Koppers - remove panic since this might happen due to eventual consistency --> fixes WEB-871
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
See #4546 for the first attempt. This causes Next.js tests to fail. ~~Currently figuring out what's wrong.~~ This surfaced an existing issue in our chunk optimization logic, where chunks of different chunking contexts (SSR and RSC) would be merged together, leading to invalid module ids. link WEB-891
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
…el#4546) ### Description This PR does two things, addressing related comments from vercel#4450: 1. Replace `ChunkReferenceVc` and `ParallelChunkReferenceVc` with `Chunk::parallel_chunks`. 2. Moves all non-generic optimization logic out of `turbopack-core` and into `turbopack-dev`. These optimization methods are very specific to a development environment, and `turbopack-build` will have different ones. ### Testing Instructions Snapshots link WEB-891
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
…el#4601) See vercel#4546 for the first attempt. This causes Next.js tests to fail. ~~Currently figuring out what's wrong.~~ This surfaced an existing issue in our chunk optimization logic, where chunks of different chunking contexts (SSR and RSC) would be merged together, leading to invalid module ids. link WEB-891
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…el/turborepo#4546) ### Description This PR does two things, addressing related comments from vercel/turborepo#4450: 1. Replace `ChunkReferenceVc` and `ParallelChunkReferenceVc` with `Chunk::parallel_chunks`. 2. Moves all non-generic optimization logic out of `turbopack-core` and into `turbopack-dev`. These optimization methods are very specific to a development environment, and `turbopack-build` will have different ones. ### Testing Instructions Snapshots link WEB-891
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…el/turborepo#4601) See vercel/turborepo#4546 for the first attempt. This causes Next.js tests to fail. ~~Currently figuring out what's wrong.~~ This surfaced an existing issue in our chunk optimization logic, where chunks of different chunking contexts (SSR and RSC) would be merged together, leading to invalid module ids. link WEB-891
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…el/turborepo#4546) ### Description This PR does two things, addressing related comments from vercel/turborepo#4450: 1. Replace `ChunkReferenceVc` and `ParallelChunkReferenceVc` with `Chunk::parallel_chunks`. 2. Moves all non-generic optimization logic out of `turbopack-core` and into `turbopack-dev`. These optimization methods are very specific to a development environment, and `turbopack-build` will have different ones. ### Testing Instructions Snapshots link WEB-891
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…el/turborepo#4601) See vercel/turborepo#4546 for the first attempt. This causes Next.js tests to fail. ~~Currently figuring out what's wrong.~~ This surfaced an existing issue in our chunk optimization logic, where chunks of different chunking contexts (SSR and RSC) would be merged together, leading to invalid module ids. link WEB-891
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…el/turborepo#4546) ### Description This PR does two things, addressing related comments from vercel/turborepo#4450: 1. Replace `ChunkReferenceVc` and `ParallelChunkReferenceVc` with `Chunk::parallel_chunks`. 2. Moves all non-generic optimization logic out of `turbopack-core` and into `turbopack-dev`. These optimization methods are very specific to a development environment, and `turbopack-build` will have different ones. ### Testing Instructions Snapshots link WEB-891
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…el/turborepo#4601) See vercel/turborepo#4546 for the first attempt. This causes Next.js tests to fail. ~~Currently figuring out what's wrong.~~ This surfaced an existing issue in our chunk optimization logic, where chunks of different chunking contexts (SSR and RSC) would be merged together, leading to invalid module ids. link WEB-891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things, addressing related comments from #4450:
ChunkReferenceVcandParallelChunkReferenceVcwithChunk::parallel_chunks.turbopack-coreand intoturbopack-dev. These optimization methods are very specific to a development environment, andturbopack-buildwill have different ones.Testing Instructions
Snapshots
link WEB-891