Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to create stress test for client components #4581

Merged
merged 2 commits into from
Apr 14, 2023
Merged

allow to create stress test for client components #4581

merged 2 commits into from
Apr 14, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 14, 2023

Description

adds --leaf-client-components to the test app generator to make all leaf components client components and allow to stress test an app with many client components

@sokra sokra requested a review from a team as a code owner April 14, 2023 10:47
@sokra sokra requested a review from alexkirsz April 14, 2023 10:47
@vercel
Copy link

vercel bot commented Apr 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo 🔄 Building (Inspect) Apr 14, 2023 1:34pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 1:34pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-cra-web ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-native-web ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm

@github-actions
Copy link
Contributor

✅ This changes can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Apr 14, 2023
@github-actions
Copy link
Contributor

Benchmark for 8641e47

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9661.60µs ± 112.26µs 9678.04µs ± 16.49µs +0.17%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8633.38µs ± 36.62µs 8774.78µs ± 198.18µs +1.64%
bench_startup/Turbopack CSR/1000 modules 893.27ms ± 2.24ms 896.00ms ± 3.43ms +0.31%

@kodiakhq kodiakhq bot merged commit 6f7bc5f into main Apr 14, 2023
@kodiakhq kodiakhq bot deleted the sokra/test-app-stress-client branch April 14, 2023 13:59
@sokra sokra mentioned this pull request Apr 14, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Apr 14, 2023
@sokra
provide the PORT env var based on server port, update turbopack (#48347)
51defb2 
### What?

gives user code access to `process.env.PORT` as current server port
avoid injecting env vars into code on server

### Why?

it might need construct an addr to fetch from api routes

fixes WEB-868

### Turbopack changes

* vercel/turborepo#4565 <!-- Tobias Koppers - Bind
to IPv6 and IPv4 -->
* vercel/turborepo#4570 <!-- Tobias Koppers - review
follow ups -->
* vercel/turborepo#4585 <!-- Tobias Koppers - fixup
bind v6 PR: add missing listen call -->
* ~vercel/turborepo#4546 <!-- Alex Kirszenberg -
Chunking Context Refactor pt. 3: Address PR comments from pt. 2 -->
* vercel/turborepo#4580 <!-- Tobias Koppers - remove
circular dependency -->
* vercel/turborepo#4582 <!-- Tobias Koppers - ignore
internal and server-relative url() in CSS -->
* vercel/turborepo#4579 <!-- Tobias Koppers - make
node bootstrap asset lazy -->
* vercel/turborepo#4581 <!-- Tobias Koppers - allow
to create stress test for client components -->
* vercel/turborepo#4584 <!-- Tobias Koppers -
improve node.js receive timeout -->
* vercel/turborepo#4583 <!-- Tobias Koppers - remove
panic since this might happen due to eventual consistency -->

fixes WEB-871
NicholasLYang pushed a commit to NicholasLYang/turbo that referenced this pull request Apr 21, 2023
@sokra @NicholasLYang
allow to create stress test for client components (vercel#4581)
2b87421 
### Description

adds `--leaf-client-components` to the test app generator to make all
leaf components client components and allow to stress test an app with
many client components
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
allow to create stress test for client components (vercel/turborepo#4581
3aab962 
)

### Description

adds `--leaf-client-components` to the test app generator to make all
leaf components client components and allow to stress test an app with
many client components
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
allow to create stress test for client components (vercel/turborepo#4581
29bfd4f 
)

### Description

adds `--leaf-client-components` to the test app generator to make all
leaf components client components and allow to stress test an app with
many client components
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
allow to create stress test for client components (vercel/turborepo#4581
6b6f5dd 
)

### Description

adds `--leaf-client-components` to the test app generator to make all
leaf components client components and allow to stress test an app with
many client components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @alexkirsz