remove circular dependency #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
✅ This changes can build |
|
alexkirsz
approved these changes
Apr 14, 2023
sokra
force-pushed
the
sokra/remove-circular-dependency
branch
from
88d0a1d to
35a2dbf
Compare
sokra
added
the
pr: automerge
Benchmark for c6133b0
Click to view full benchmark
|
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Apr 14, 2023
### What? gives user code access to `process.env.PORT` as current server port avoid injecting env vars into code on server ### Why? it might need construct an addr to fetch from api routes fixes WEB-868 ### Turbopack changes * vercel/turborepo#4565 <!-- Tobias Koppers - Bind to IPv6 and IPv4 --> * vercel/turborepo#4570 <!-- Tobias Koppers - review follow ups --> * vercel/turborepo#4585 <!-- Tobias Koppers - fixup bind v6 PR: add missing listen call --> * ~vercel/turborepo#4546 <!-- Alex Kirszenberg - Chunking Context Refactor pt. 3: Address PR comments from pt. 2 --> * vercel/turborepo#4580 <!-- Tobias Koppers - remove circular dependency --> * vercel/turborepo#4582 <!-- Tobias Koppers - ignore internal and server-relative url() in CSS --> * vercel/turborepo#4579 <!-- Tobias Koppers - make node bootstrap asset lazy --> * vercel/turborepo#4581 <!-- Tobias Koppers - allow to create stress test for client components --> * vercel/turborepo#4584 <!-- Tobias Koppers - improve node.js receive timeout --> * vercel/turborepo#4583 <!-- Tobias Koppers - remove panic since this might happen due to eventual consistency --> fixes WEB-871
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
### Description rust-analyzer seem to be unhappy about this circular dependency and in fact we don't need this dependency anyway
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description rust-analyzer seem to be unhappy about this circular dependency and in fact we don't need this dependency anyway
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description rust-analyzer seem to be unhappy about this circular dependency and in fact we don't need this dependency anyway
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description rust-analyzer seem to be unhappy about this circular dependency and in fact we don't need this dependency anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rust-analyzer seem to be unhappy about this circular dependency and in fact we don't need this dependency anyway