Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore internal and server-relative url() in CSS #4582

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 14, 2023

Description

  • ignore internal urls like url(#noiseFilter)
  • ignore server-relative urls like url(/foo)

WEB-363

@sokra sokra requested a review from a team as a code owner April 14, 2023 10:47
@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Apr 14, 2023 1:34pm
examples-native-web 🔄 Building (Inspect) Apr 14, 2023 1:34pm
examples-tailwind-web 🔄 Building (Inspect) Apr 14, 2023 1:34pm
examples-vite-web 🔄 Building (Inspect) Apr 14, 2023 1:34pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 1:34pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 14, 2023 1:34pm

@github-actions
Copy link
Contributor

✅ This changes can build next-swc

.into(),
);
// ignore internal urls like `url(#noiseFilter)`
// ignore server-relative urls like `url(/foo)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server-relative URLs don't have any special behavior?

What about absolute URLs?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

🟢 CI successful 🟢

Thanks

@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Apr 14, 2023
@github-actions
Copy link
Contributor

Benchmark for 1dece51

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9129.36µs ± 56.84µs 9076.52µs ± 43.29µs -0.58%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8178.40µs ± 38.53µs 8439.61µs ± 181.89µs +3.19%
bench_startup/Turbopack CSR/1000 modules 872.32ms ± 2.43ms 868.96ms ± 4.66ms -0.39%

@kodiakhq kodiakhq bot merged commit 973cf41 into main Apr 14, 2023
@kodiakhq kodiakhq bot deleted the sokra/css-ignore-non-project-urls branch April 14, 2023 14:11
sokra added a commit to vercel/next.js that referenced this pull request Apr 14, 2023
### What?

gives user code access to `process.env.PORT` as current server port
avoid injecting env vars into code on server

### Why?

it might need construct an addr to fetch from api routes

fixes WEB-868

### Turbopack changes

* vercel/turborepo#4565 <!-- Tobias Koppers - Bind
to IPv6 and IPv4 -->
* vercel/turborepo#4570 <!-- Tobias Koppers - review
follow ups -->
* vercel/turborepo#4585 <!-- Tobias Koppers - fixup
bind v6 PR: add missing listen call -->
* ~vercel/turborepo#4546 <!-- Alex Kirszenberg -
Chunking Context Refactor pt. 3: Address PR comments from pt. 2 -->
* vercel/turborepo#4580 <!-- Tobias Koppers - remove
circular dependency -->
* vercel/turborepo#4582 <!-- Tobias Koppers - ignore
internal and server-relative url() in CSS -->
* vercel/turborepo#4579 <!-- Tobias Koppers - make
node bootstrap asset lazy -->
* vercel/turborepo#4581 <!-- Tobias Koppers - allow
to create stress test for client components -->
* vercel/turborepo#4584 <!-- Tobias Koppers -
improve node.js receive timeout -->
* vercel/turborepo#4583 <!-- Tobias Koppers - remove
panic since this might happen due to eventual consistency -->

fixes WEB-871
NicholasLYang pushed a commit to NicholasLYang/turbo that referenced this pull request Apr 21, 2023
### Description

* ignore internal urls like `url(#noiseFilter)`
* ignore server-relative urls like `url(/foo)`

WEB-363
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

* ignore internal urls like `url(#noiseFilter)`
* ignore server-relative urls like `url(/foo)`

WEB-363
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

* ignore internal urls like `url(#noiseFilter)`
* ignore server-relative urls like `url(/foo)`

WEB-363
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

* ignore internal urls like `url(#noiseFilter)`
* ignore server-relative urls like `url(/foo)`

WEB-363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants