Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability for Rewrites to overwrite request headers #5139

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Add ability for Rewrites to overwrite request headers #5139

merged 2 commits into from
Jun 6, 2023

Conversation

jridgewell
Copy link
Contributor

@jridgewell jridgewell commented May 31, 2023 •
edited
Loading

Description

Adds a request_headers override to RewriteVc, allowing middleware to modify the request headers for further lookups.

Testing Instructions

vercel/next.js#50567
Re: WEB-1121

@jridgewell jridgewell requested a review from a team as a code owner May 31, 2023 06:51
@vercel
Copy link

vercel bot commented May 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 4:36pm
examples-cra-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 4:36pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 4:36pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 4:36pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 4:36pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 4:36pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 4:36pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 4:36pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 4:36pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 4:36pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Jun 6, 2023 4:36pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@jridgewell jridgewell mentioned this pull request May 31, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for 4d71c70

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8786.47µs ± 85.66µs 8580.30µs ± 82.58µs -2.35%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7630.97µs ± 52.50µs 7579.86µs ± 55.97µs -0.67%
bench_startup/Turbopack CSR/1000 modules 875.76ms ± 1.36ms 871.20ms ± 1.63ms -0.52%

@github-actions
Copy link
Contributor

MacOS Benchmark for 4d71c70

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.84ms ± 0.13ms 26.50ms ± 0.07ms +2.58% +1.04%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.03ms ± 0.10ms 26.87ms ± 0.13ms -0.58%
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.84ms ± 0.13ms 26.50ms ± 0.07ms +2.58% +1.04%
bench_startup/Turbopack CSR/1000 modules 2589.29ms ± 5.00ms 2646.00ms ± 28.67ms +2.19%

@jridgewell jridgewell requested a review from kwonoj June 1, 2023 16:55
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Linux Benchmark for 14df20f

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8860.98µs ± 66.08µs 8822.38µs ± 31.39µs -0.44%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7911.66µs ± 43.53µs 8045.44µs ± 72.64µs +1.69%
bench_startup/Turbopack CSR/1000 modules 903.93ms ± 2.10ms 899.17ms ± 2.96ms -0.53%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

MacOS Benchmark for 14df20f

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 7804.56ms ± 1999.00ms 2842.71ms ± 29.86ms -63.58% -23.75%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.17ms ± 0.14ms 26.62ms ± 0.14ms +1.72%
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.29ms ± 0.19ms 28.15ms ± 2.11ms +11.28%
bench_startup/Turbopack CSR/1000 modules 7804.56ms ± 1999.00ms 2842.71ms ± 29.86ms -63.58% -23.75%

@jridgewell jridgewell added the pr: automerge Kodiak will merge these automatically after checks pass label Jun 6, 2023
@jridgewell jridgewell merged commit 715fc0f into main Jun 6, 2023
@jridgewell jridgewell deleted the jrl-middleware-tests branch June 6, 2023 20:13
@ForsakenHarmony ForsakenHarmony mentioned this pull request Jun 8, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jun 8, 2023
@ForsakenHarmony
update turbopack (#50819)
0d46361 
### Turbopack Updates
* vercel/turborepo#5156 
* vercel/turborepo#5159 
* vercel/turborepo#5162 
* vercel/turborepo#5161 

* vercel/turborepo#5174 
* vercel/turborepo#5178 
* vercel/turborepo#5121 
* vercel/turborepo#5200 
* vercel/turborepo#5207 
* vercel/turborepo#5211 
* vercel/turborepo#5210 
* vercel/turborepo#5221 
* vercel/turborepo#5218 
* vercel/turborepo#5226 
* vercel/turborepo#5139 
* vercel/turborepo#5227 
* vercel/turborepo#5189
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
@ForsakenHarmony @hydRAnger
update turbopack (vercel#50819)
fea2213 
### Turbopack Updates
* vercel/turborepo#5156 
* vercel/turborepo#5159 
* vercel/turborepo#5162 
* vercel/turborepo#5161 

* vercel/turborepo#5174 
* vercel/turborepo#5178 
* vercel/turborepo#5121 
* vercel/turborepo#5200 
* vercel/turborepo#5207 
* vercel/turborepo#5211 
* vercel/turborepo#5210 
* vercel/turborepo#5221 
* vercel/turborepo#5218 
* vercel/turborepo#5226 
* vercel/turborepo#5139 
* vercel/turborepo#5227 
* vercel/turborepo#5189
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@jridgewell
Add ability for Rewrites to overwrite request headers (vercel/turbore…
4c3c601 
…po#5139)

### Description

Adds a `request_headers` override to `RewriteVc`, allowing middleware to
modify the request headers for further lookups.

### Testing Instructions

#50567
Re: WEB-1121
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@jridgewell
Add ability for Rewrites to overwrite request headers (vercel/turbore…
89f6d42 
…po#5139)

### Description

Adds a `request_headers` override to `RewriteVc`, allowing middleware to
modify the request headers for further lookups.

### Testing Instructions

#50567
Re: WEB-1121
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@jridgewell
Add ability for Rewrites to overwrite request headers (vercel/turbore…
2fc550f 
…po#5139)

### Description

Adds a `request_headers` override to `RewriteVc`, allowing middleware to
modify the request headers for further lookups.

### Testing Instructions

#50567
Re: WEB-1121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwonoj kwonoj kwonoj approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jridgewell @kwonoj