make HMR re-execute modules that self invalidate #5161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
✅ This change can build |
|
Linux Benchmark for bd7e186Click to view benchmark
|
ForsakenHarmony
force-pushed
the
hrmny/web-1136-hmr-fix-invalidate
branch
from
a2a77d9 to
33cf929
Compare
ForsakenHarmony
commented
Jun 1, 2023
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| // This file must not use `import` and `export` statements. Otherwise, it | |||
| // becomes impossible to augment interfaces declared in `<reference>`d files | |||
| // (e.g. `Module`). Hence the need for `import()` here. | |||
| // (e.g. `Module`). Hence, the need for `import()` here. | |||
There was a problem hiding this comment.
my IDE made a bunch of grammar suggestions 🙃
Linux Benchmark for c872103Click to view benchmark
|
jridgewell
approved these changes
Jun 1, 2023
alexkirsz
reviewed
Jun 5, 2023
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| // This file must not use `import` and `export` statements. Otherwise, it | |||
| // becomes impossible to augment interfaces declared in `<reference>`d files | |||
| // (e.g. `Module`). Hence the need for `import()` here. | |||
| // (e.g. `Module`). Hence, the need for `import()` here. | |||
| * Removes a module from a chunk. Returns true there are no remaining chunks | ||
| * including this module. | ||
| * Removes a module from a chunk. | ||
| * Returns `true` if there are no remaining chunks, including this module. |
There was a problem hiding this comment.
This no longer means the same thing. It should be:
Returns `true` if there are no remaining chunks including this module.
(the chunks include a module)
There was a problem hiding this comment.
you are right, will fix in my next PR
This was referenced Jun 2, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jun 8, 2023
### Turbopack Updates * vercel/turborepo#5156 * vercel/turborepo#5159 * vercel/turborepo#5162 * vercel/turborepo#5161 * vercel/turborepo#5174 * vercel/turborepo#5178 * vercel/turborepo#5121 * vercel/turborepo#5200 * vercel/turborepo#5207 * vercel/turborepo#5211 * vercel/turborepo#5210 * vercel/turborepo#5221 * vercel/turborepo#5218 * vercel/turborepo#5226 * vercel/turborepo#5139 * vercel/turborepo#5227 * vercel/turborepo#5189
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
### Turbopack Updates * vercel/turborepo#5156 * vercel/turborepo#5159 * vercel/turborepo#5162 * vercel/turborepo#5161 * vercel/turborepo#5174 * vercel/turborepo#5178 * vercel/turborepo#5121 * vercel/turborepo#5200 * vercel/turborepo#5207 * vercel/turborepo#5211 * vercel/turborepo#5210 * vercel/turborepo#5221 * vercel/turborepo#5218 * vercel/turborepo#5226 * vercel/turborepo#5139 * vercel/turborepo#5227 * vercel/turborepo#5189
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description This can happen when a module that previously exported a React component no longer does, the next react refresh integration will then call `module.hot.invalidate()` fixes the `acceptance/ReactRefreshRequire.test.ts` next.js integration test
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description This can happen when a module that previously exported a React component no longer does, the next react refresh integration will then call `module.hot.invalidate()` fixes the `acceptance/ReactRefreshRequire.test.ts` next.js integration test
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description This can happen when a module that previously exported a React component no longer does, the next react refresh integration will then call `module.hot.invalidate()` fixes the `acceptance/ReactRefreshRequire.test.ts` next.js integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This can happen when a module that previously exported a React component no longer does, the next react refresh integration will then call
module.hot.invalidate()fixes the
acceptance/ReactRefreshRequire.test.tsnext.js integration test