Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PrefixedRouterContentSourceVc's debug_assertion #5227

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

jridgewell
Copy link
Contributor

Description

ContentSource paths do not begin with a /, and the prefix should match that. 🤦

Testing Instructions

`ContentSource` paths do not begin with a `/`, and the prefix should match that.
@jridgewell jridgewell requested a review from a team as a code owner June 6, 2023 20:06
@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 8:07pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jun 6, 2023 8:07pm
examples-cra-web ⬜️ Ignored (Inspect) Jun 6, 2023 8:07pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 6, 2023 8:07pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jun 6, 2023 8:07pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jun 6, 2023 8:07pm
examples-native-web ⬜️ Ignored (Inspect) Jun 6, 2023 8:07pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Jun 6, 2023 8:07pm
examples-svelte-web ⬜️ Ignored (Inspect) Jun 6, 2023 8:07pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 6, 2023 8:07pm
examples-vite-web ⬜️ Ignored (Inspect) Jun 6, 2023 8:07pm

@jridgewell jridgewell changed the title Fix PrefixedRouterContentSourceVc debug_assertion Fix PrefixedRouterContentSourceVc's debug_assertion Jun 6, 2023
@jridgewell jridgewell added the pr: automerge Kodiak will merge these automatically after checks pass label Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

✅ This change can build next-swc

@jridgewell jridgewell merged commit 1801472 into main Jun 6, 2023
@jridgewell jridgewell deleted the jrl-base-path-4 branch June 6, 2023 20:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Linux Benchmark for 2189abf

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8805.91µs ± 113.21µs 8856.32µs ± 61.86µs +0.57%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7816.37µs ± 150.31µs 8306.37µs ± 198.00µs +6.27%
bench_startup/Turbopack CSR/1000 modules 923.24ms ± 1.65ms 913.48ms ± 5.14ms -1.06%

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

MacOS Benchmark for 2189abf

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.54ms ± 0.36ms 60.14ms ± 1.76ms +126.59% +107.76%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.54ms ± 0.36ms 60.14ms ± 1.76ms +126.59% +107.76%
bench_hmr_to_eval/Turbopack CSR/1000 modules 29.97ms ± 2.25ms 26.25ms ± 0.32ms -12.43%
bench_startup/Turbopack CSR/1000 modules 3040.74ms ± 33.27ms 3012.73ms ± 29.32ms -0.92%

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…repo#5227)

### Description

`ContentSource` paths do not begin with a `/`, and the prefix should
match that. 🤦

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…repo#5227)

### Description

`ContentSource` paths do not begin with a `/`, and the prefix should
match that. 🤦

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…repo#5227)

### Description

`ContentSource` paths do not begin with a `/`, and the prefix should
match that. 🤦

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants