Move build time directives from title to body of PR #7060

mhagen-vmware · 2018-01-09T17:39:06Z

mdharamadas1 · 2018-01-09T17:51:10Z

tests/integration-test.sh

    echo "Running specific CI as per commit message"
-    buildtype=$(echo $buildinfo | grep "\[specific ci=")
+    buildtype=$(echo $prBody | grep "\[specific ci=")


I think it would be good if this can also run multiple specific groups if someone wants to run more than one groups.

@anchal-agrawal has commented on this in the past. This actually gets passed in as a raw string, so if commas or the pybot delimiter is put in properly it already can. correct me if I am wrong @anchal-agrawal :)

Correct! Multiple groups/suites can be specified by saying, for instance, [specific ci=foo bar].

mdharamadas1

Just one suggestion but this LGTM.

zjs · 2018-01-09T20:49:56Z

tests/integration-test.sh


 if [[ $DRONE_BRANCH == "master" || $DRONE_BRANCH == "releases/"* ]] && [[ $DRONE_REPO == "vmware/vic" ]] && [[ $DRONE_BUILD_EVENT == "push" ]]; then
    echo "Running full CI for $DRONE_BUILD_EVENT on $DRONE_BRANCH"
    pybot --removekeywords TAG:secret --exclude skip tests/test-cases
 elif [[ $DRONE_BRANCH == *"refs/tags"* ]] && [[ $DRONE_REPO == "vmware/vic" ]] && [[ $DRONE_BUILD_EVENT == "tag" ]]; then
    echo "Running only Group11-Upgrade and 7-01-Regression for $DRONE_BUILD_EVENT on $DRONE_BRANCH"
    pybot --removekeywords TAG:secret --suite Group11-Upgrade --suite 7-01-Regression tests/test-cases
-elif grep -q "\[full ci\]" <(drone build info vmware/vic $DRONE_BUILD_NUMBER); then
+elif grep -q "\[full ci\]" <$prBody; then


I don't think this is valid bash syntax. I think you'll want to rewrite it as (echo $prBody | grep -q "\[full ci\]").

anchal-agrawal

We should update the corresponding notes in https://github.com/vmware/vic/blob/master/CONTRIBUTING.md#automated-testing and https://raw.githubusercontent.com/vmware/vic/master/.github/PULL_REQUEST_TEMPLATE.md as well.

Also, is there an example of a successful full/specific ci parsed build with this PR? The current build timed out.

gigawhitlocks · 2018-01-16T19:13:04Z

🚢 🇮🇹 LTGM

hickeng

Enhancement request, but should simply be checking the specific line for a - [x] before the current pattern if want to keep change minimal

hickeng · 2018-01-28T06:34:51Z

tests/integration-test.sh


 if [[ $DRONE_BRANCH == "master" || $DRONE_BRANCH == "releases/"* ]] && [[ $DRONE_REPO == "vmware/vic" ]] && [[ $DRONE_BUILD_EVENT == "push" ]]; then
    echo "Running full CI for $DRONE_BUILD_EVENT on $DRONE_BRANCH"
    pybot --removekeywords TAG:secret --exclude skip tests/test-cases
 elif [[ $DRONE_BRANCH == *"refs/tags"* ]] && [[ $DRONE_REPO == "vmware/vic" ]] && [[ $DRONE_BUILD_EVENT == "tag" ]]; then
    echo "Running only Group11-Upgrade and 7-01-Regression for $DRONE_BUILD_EVENT on $DRONE_BRANCH"
    pybot --removekeywords TAG:secret --suite Group11-Upgrade --suite 7-01-Regression tests/test-cases
-elif grep -q "\[full ci\]" <(drone build info vmware/vic $DRONE_BUILD_NUMBER); then
+elif (echo $prBody | grep -q "\[full ci\]"); then


Any chance we could have these match for the following for example:

run full CI

run unit tests

run group23

- [x] run full CI - [x] run unit tests - [x] run group23

This would make it quick and easy to switch between multiple groups or focused groups/tests.
Admittedly most PRs won't really benefit that much from it, but I would have found it really useful for my most recent few.

I'm envisaging some staple ones added to the template, and then provision for customization

hickeng · 2018-02-15T19:42:21Z

@mhagen-vmware think we should just merge this if it's functional, and enhancements to come later.

* Dump dmesg if container rootfs blocks or fails mount (#7260) This is to enable bridging of the guest side state with the virtual hardware if we see issues such as disks not presenting on a pvscsi controller or a mount operation hanging. * updating priority definitions to include features (#7292) * Change default fellows for gandalf (#7310) * Avoid exposing test credentials in 12-01-Delete (#7306) To avoid exposing test credentials, use the established `Run VIC Machine Delete Command` keyword, which in turn calls a secret keyword. This changes the behavior of the test slightly: - It no longer checks for the absence of "delete failed" in output. - It will wait up to 30 seconds for the deletion to succeed. - It will clean up cert files at the end of the deletion. * Bug fix in API delete test: disable volume store cleanup (#7303) * Remove volume store cleanup before re-installing VIC appliance using existing volume stores * Cleanup dangling volume stores on test teardown * Add logging for image upload (#7296) * Reduce datastore searches during non-vSAN delete operations (#6951) * Optimize portlayer volume cache rebuild on startup (#7267) This commit modifies the portlayer volume cache's rebuildCache func to only process the volumes from the volume store that is currently being added to the cache. rebuildCache is invoked for every volume store during portlayer startup. Before this change, rebuildCache would process volumes from all volume stores in the cache every time a volume store was added. This led to unneeded extra computation which could slow down portlayer startup and overwhelm NFS endpoints if NFS volume stores are being used. Fixes #6991 * Added local ci testing target to makefile (#7170) Make testing locally as friction-free as possible by 1. Adding a makefile target 'local-ci-test' 2. Using TARGET_VCH added in VIC 1.3 to use an existing VCH 3. Using a custom script that doesn't utilize drone so that if the test fails and craters, we can still access the logs 4. Parameters can come from env vars, arguments, or secrets file Resolves #7162 * Added upload progress bar tracker for ISO images. (#7320) * Added upload progress bar tracker for ISO images. Removed concurrent upload since it doesn't make any significant performance imapact. When I tried to measure performance differene with and without concurrent uppload, the results were fluctuating in a wide range so no good measurement was possible. * Document the design for the vic-machine API (#6702) This document proposes a design for a comprehensive vic-machine API, the implementation of which will be tracked by #6116. Subsets of this API (tracked by #5721, #6123, and eventually others) will be implemented incrementally, and the design will be revised as those efforts progress to reflect changes to the long-term vision. * Remove superfluous calls to Set Test VCH Name (#7304) Several tests explicitly call the `Set Test VCH Name` keyword shortly after calling `Set Test Environment Variables`. This can lead to test failures when a VCH name collision occurs; subsequent tests which re-use the VCH name fail because there may be leftover certificates from the first VCH with that name. `Set Test Environment Variables` itself calls `Set Test VCH Name` and then cleans up old certificate directories. Therefore, the explicit calls to `Set Test VCH Name` are both superfluous and problematic. * Ensure that static ip worker is on the same nimbus pod as VC otherwise network connectivity not guaranteed (#7307) * [skip ci] Add ROBO test plans (#7297) This commit adds test plans for the ROBO support features in a new directory (Group19-ROBO) under manual test cases. The existing ROBO-SKU test has been moved into this directory. The test plans include tests for the container limit feature, placement without DRS, the license/ feature checks and WAN connectivity. Fixes #7294 * Add hosts to DVS within the test bed as well (#7326) * Setup updated for Longevity Tests (#7298) * Setup updated for Longevity Tests to run on 6.5U1 * [skip ci] Terminate gracefully to gather logs (#7331) * Terminate gracefully to gather logs * Remove extra whitespace * Increase timeout to 70 minutes * Increase ELM timeout to 70 minutes * Add repo to slack message since we have multiple repos reporting now (#7334) * Not sending user credentials with every request (#6382) * Add concurrent testing tool to tests folder (#6534) Adds a minimized test case for testing our core vSphere interactions at varying degrees of concurrency. This is intended to simplify debugging issues that are suspected to be platform problems, or API usage issues that are conceptually divorced from the VIC engine product code. * Refactor Install Harbor To Test Server keyword (#7335) The secret tag on the `Install Harbor To Test Server` makes it difficult to investigate failures when they occur. Only one out of 30+ lines actually uses secret information. Refactor the keyword to extract the secret information into its own keyword, allowing the tag to be applied in a more focused way. This is similar to the pattern used by keywords in `VCH-Util`. * Add ability to cache generated dependency. (#7340) * Add ability to cache generated dependency, so not much time wasted during the build process. * Added documentation to reflect necessary steps to leverage such improvements. * Ignore not-supported result from RetrieveUserGroups in VC 6.0 (#7328) * Move build time directives from title to body of PR (#7060) * Retry the harbor setup as well (#7336) * Skip non vSphere managed datastores when granting perms (#7346) * Fix volume leak on group 23 test (#7358) * Fix github status automation filtering (#7344) Adds filtering for the event source and consolidates remote API calls. Details the specific builds and their status for quick reference. * Drone 0.8 and HaaS updates (#7364) * Add tether.debug in integration test log bundle (#7422) * Update the gcs plugin (#7421) * [skip ci] Suggest subnet/gateway to static ip worker * Ensure that static ip worker is on the same nimbus pod as VC otherwise network connectivity not guaranteed (#7307) * Refactored some proxy code to reuse with wolfpack Refactored the system, volume, container, and stream swagger code into proxy code. 1) Moved the errors.go from backends to a new folder to be accessed by all folders outside of the backends folder. 2) Refactored Container proxy and moved from engine/backends to engine/proxy 3) Refactored Volume proxy and moved from engine/backends to engine/proxy 4) Refactored System proxy and moved from engine/backends to engine/proxy 5) Refactored Stream proxy and moved from engine/backends to engine/proxy 6) Adopted some common patterns in all the proxies 7) Moved common networking util calls to engine/networking 8) Fix up unit tests 9) Changed all "not yet implemented messages" 10) Updated robot scripts More refactoring will be needed to make these proxy less dependent on docker types and portlayer swagger types. Helps resolves #7210 and #7232 * Add virtual-kubelet binary to VIC ISO (#7315) * Start virtual-kubelet inside the VCH (#7369) * Fix value of the PORTLAYER_ADDR environment variable (#7400) * Use vic kubelet provider * Made modifications for virtual kubelet * Added admin log collection and fix env variable content (#7404) * Added most-vkubelet target (#7418)

mhagen-vmware requested review from hickeng, anchal-agrawal and mdharamadas1 January 9, 2018 17:39

vmwclabot added the cla-not-required label Jan 9, 2018

mdharamadas1 reviewed Jan 9, 2018

View reviewed changes

mdharamadas1 approved these changes Jan 9, 2018

View reviewed changes

zjs reviewed Jan 9, 2018

View reviewed changes

anchal-agrawal reviewed Jan 11, 2018

View reviewed changes

mhagen-vmware mentioned this pull request Jan 18, 2018

[skip ci] Make it a fatal error if vic machine fails to cleanup a VCH #6980

Merged

hickeng approved these changes Jan 28, 2018

View reviewed changes

mhagen-vmware force-pushed the feature/brackets-in-body branch 2 times, most recently from c12a4c8 to 34eb013 Compare February 21, 2018 15:25

[skip ci] try merge again

e706038

mhagen-vmware force-pushed the feature/brackets-in-body branch from 8f9fd17 to e706038 Compare February 21, 2018 15:41

mhagen-vmware added 2 commits February 21, 2018 09:47

[skip ci] force fix pull approve

80c39ea

[skip ci] fix it

f103310

mhagen-vmware merged commit 216d9ef into master Feb 21, 2018

mhagen-vmware deleted the feature/brackets-in-body branch February 21, 2018 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move build time directives from title to body of PR #7060

Move build time directives from title to body of PR #7060

mhagen-vmware commented Jan 9, 2018 •

edited

Loading

mdharamadas1 Jan 9, 2018

matthewavery Jan 16, 2018

anchal-agrawal Jan 16, 2018

mdharamadas1 left a comment

zjs Jan 9, 2018

anchal-agrawal left a comment •

edited

Loading

gigawhitlocks commented Jan 16, 2018

hickeng left a comment

hickeng Jan 28, 2018 •

edited

Loading

hickeng commented Feb 15, 2018

Move build time directives from title to body of PR #7060

Move build time directives from title to body of PR #7060

Conversation

mhagen-vmware commented Jan 9, 2018 • edited Loading

mdharamadas1 Jan 9, 2018

Choose a reason for hiding this comment

matthewavery Jan 16, 2018

Choose a reason for hiding this comment

anchal-agrawal Jan 16, 2018

Choose a reason for hiding this comment

mdharamadas1 left a comment

Choose a reason for hiding this comment

zjs Jan 9, 2018

Choose a reason for hiding this comment

anchal-agrawal left a comment • edited Loading

Choose a reason for hiding this comment

gigawhitlocks commented Jan 16, 2018

hickeng left a comment

Choose a reason for hiding this comment

hickeng Jan 28, 2018 • edited Loading

Choose a reason for hiding this comment

hickeng commented Feb 15, 2018

mhagen-vmware commented Jan 9, 2018 •

edited

Loading

anchal-agrawal left a comment •

edited

Loading

hickeng Jan 28, 2018 •

edited

Loading