Ignore not-supported result from RetrieveUserGroups in VC 6.0 #7328
Conversation
| @@ -393,6 +394,20 @@ func (am *AuthzManager) getRoleName(resource *Resource) string { | |||
| } | |||
| } | |||
|
|
|||
| func isNotSupportedError(ctx context.Context, err error) bool { | |||
There was a problem hiding this comment.
Feels like this and isNotFound should roll into base govmomi somehow. @dougm?
Not needed for this PR unless already available in govmomi.
There was a problem hiding this comment.
govmomi probably should have some of these error helpers, but it doesn't other than types.IsFileNotFound that VIC already makes use of.
|
|
||
| *** Keywords *** | ||
|
|
||
| Gather VC Logs |
There was a problem hiding this comment.
This should go into one of the utility libraries.
I'm also unsure whether it will download the ESX log bundles or just VC - a keyword comment noting which would be good.
| Gather VC Logs | ||
| Log To Console Collecting VC logs .. | ||
| Run Keyword And Ignore Error Run govc logs.download | ||
| Run Keyword And Ignore Error Run mv vcsupport*.tgz vcsupport.tgz.log |
There was a problem hiding this comment.
presume this is so that the bundle gets gathered by the test harness? We already gather the container-logs bundle from the run (which seem to be .zip) - is it as simple as updating a pattern somewhere to grab .tgz as well? @mhagen-vmware
There was a problem hiding this comment.
Yep, the place for this would be https://github.com/vmware/vic/blob/master/tests/resources/VCH-Util.robot#L367
With an additional: Run Keyword If '%{HOST_TYPE}' == 'VC' gather what logs you want, however as you can see in that keyword already it pulls specific logs. Otherwise, this govc logs.download would just add 5-15 minutes to every single test case which we probably don't want - esp as we are moving CI to VC which would hit that case every time as well. As we discussed in slack the current bundle inclusion pattern is .zip .log .debug... zip is very specific because that is the only archive extension that github allows attaching so if you are pulling the whole govc logs.download you really should just dump that archive into a zip archive I guess.
There was a problem hiding this comment.
If you just wanted to gather all the logs, we have that already here - although could be better named as it will work on either esx or vc:
https://github.com/vmware/vic/blob/master/tests/resources/Vsphere-Util.robot#L193
| @@ -17,8 +17,16 @@ Documentation Test 5-25 - OPS-User-Grant | |||
| Resource ../../resources/Util.robot | |||
| Suite Setup Wait Until Keyword Succeeds 10x 10m Ops User Create | |||
| Suite Teardown Run Keyword And Ignore Error Nimbus Cleanup ${list} | |||
| Test Teardown Run Keyword And Ignore Error Gather VC Logs | |||
There was a problem hiding this comment.
presume this is going to be removed after we have a bundle? Could we have it as a separate commit so it can just be reverted.
| Gather VC Logs | ||
| Log To Console Collecting VC logs .. | ||
| Run Keyword And Ignore Error Run govc logs.download | ||
| Run Keyword And Ignore Error Run mv vcsupport*.tgz vcsupport.tgz.log |
There was a problem hiding this comment.
Yep, the place for this would be https://github.com/vmware/vic/blob/master/tests/resources/VCH-Util.robot#L367
With an additional: Run Keyword If '%{HOST_TYPE}' == 'VC' gather what logs you want, however as you can see in that keyword already it pulls specific logs. Otherwise, this govc logs.download would just add 5-15 minutes to every single test case which we probably don't want - esp as we are moving CI to VC which would hit that case every time as well. As we discussed in slack the current bundle inclusion pattern is .zip .log .debug... zip is very specific because that is the only archive extension that github allows attaching so if you are pulling the whole govc logs.download you really should just dump that archive into a zip archive I guess.
| Gather VC Logs | ||
| Log To Console Collecting VC logs .. | ||
| Run Keyword And Ignore Error Run govc logs.download | ||
| Run Keyword And Ignore Error Run mv vcsupport*.tgz vcsupport.tgz.log |
There was a problem hiding this comment.
If you just wanted to gather all the logs, we have that already here - although could be better named as it will work on either esx or vc:
https://github.com/vmware/vic/blob/master/tests/resources/Vsphere-Util.robot#L193
lcastellano
force-pushed
the
ops-user
branch
from
fe41ee1
to
e3efeb3
Compare
| Gather VC Logs | ||
| Log To Console Collecting VC logs .. | ||
| Run Keyword And Ignore Error Gather Logs From ESX Server | ||
| Run Keyword And Ignore Error Run mv vcsupport*.tgz vcsupport.tgz.log |
There was a problem hiding this comment.
Don't just move this to a different extension, please zip the file into a zip archive.
There was a problem hiding this comment.
@mhagen-vmware can we add .tgz as a recognized archive type? Seems a little ott to have a .tar.gz.zip
| @@ -17,8 +17,16 @@ Documentation Test 5-25 - OPS-User-Grant | |||
| Resource ../../resources/Util.robot | |||
| Suite Setup Wait Until Keyword Succeeds 10x 10m Ops User Create | |||
| Suite Teardown Run Keyword And Ignore Error Nimbus Cleanup ${list} | |||
| Test Teardown Run Keyword And Ignore Error Gather VC Logs | |||
There was a problem hiding this comment.
Test Teardown Run Keyword If Test Failed Gather VC Logs
lcastellano
force-pushed
the
ops-user
branch
from
a04dfc1
to
46b4198
Compare
* Dump dmesg if container rootfs blocks or fails mount (#7260) This is to enable bridging of the guest side state with the virtual hardware if we see issues such as disks not presenting on a pvscsi controller or a mount operation hanging. * updating priority definitions to include features (#7292) * Change default fellows for gandalf (#7310) * Avoid exposing test credentials in 12-01-Delete (#7306) To avoid exposing test credentials, use the established `Run VIC Machine Delete Command` keyword, which in turn calls a secret keyword. This changes the behavior of the test slightly: - It no longer checks for the absence of "delete failed" in output. - It will wait up to 30 seconds for the deletion to succeed. - It will clean up cert files at the end of the deletion. * Bug fix in API delete test: disable volume store cleanup (#7303) * Remove volume store cleanup before re-installing VIC appliance using existing volume stores * Cleanup dangling volume stores on test teardown * Add logging for image upload (#7296) * Reduce datastore searches during non-vSAN delete operations (#6951) * Optimize portlayer volume cache rebuild on startup (#7267) This commit modifies the portlayer volume cache's rebuildCache func to only process the volumes from the volume store that is currently being added to the cache. rebuildCache is invoked for every volume store during portlayer startup. Before this change, rebuildCache would process volumes from all volume stores in the cache every time a volume store was added. This led to unneeded extra computation which could slow down portlayer startup and overwhelm NFS endpoints if NFS volume stores are being used. Fixes #6991 * Added local ci testing target to makefile (#7170) Make testing locally as friction-free as possible by 1. Adding a makefile target 'local-ci-test' 2. Using TARGET_VCH added in VIC 1.3 to use an existing VCH 3. Using a custom script that doesn't utilize drone so that if the test fails and craters, we can still access the logs 4. Parameters can come from env vars, arguments, or secrets file Resolves #7162 * Added upload progress bar tracker for ISO images. (#7320) * Added upload progress bar tracker for ISO images. Removed concurrent upload since it doesn't make any significant performance imapact. When I tried to measure performance differene with and without concurrent uppload, the results were fluctuating in a wide range so no good measurement was possible. * Document the design for the vic-machine API (#6702) This document proposes a design for a comprehensive vic-machine API, the implementation of which will be tracked by #6116. Subsets of this API (tracked by #5721, #6123, and eventually others) will be implemented incrementally, and the design will be revised as those efforts progress to reflect changes to the long-term vision. * Remove superfluous calls to Set Test VCH Name (#7304) Several tests explicitly call the `Set Test VCH Name` keyword shortly after calling `Set Test Environment Variables`. This can lead to test failures when a VCH name collision occurs; subsequent tests which re-use the VCH name fail because there may be leftover certificates from the first VCH with that name. `Set Test Environment Variables` itself calls `Set Test VCH Name` and then cleans up old certificate directories. Therefore, the explicit calls to `Set Test VCH Name` are both superfluous and problematic. * Ensure that static ip worker is on the same nimbus pod as VC otherwise network connectivity not guaranteed (#7307) * [skip ci] Add ROBO test plans (#7297) This commit adds test plans for the ROBO support features in a new directory (Group19-ROBO) under manual test cases. The existing ROBO-SKU test has been moved into this directory. The test plans include tests for the container limit feature, placement without DRS, the license/ feature checks and WAN connectivity. Fixes #7294 * Add hosts to DVS within the test bed as well (#7326) * Setup updated for Longevity Tests (#7298) * Setup updated for Longevity Tests to run on 6.5U1 * [skip ci] Terminate gracefully to gather logs (#7331) * Terminate gracefully to gather logs * Remove extra whitespace * Increase timeout to 70 minutes * Increase ELM timeout to 70 minutes * Add repo to slack message since we have multiple repos reporting now (#7334) * Not sending user credentials with every request (#6382) * Add concurrent testing tool to tests folder (#6534) Adds a minimized test case for testing our core vSphere interactions at varying degrees of concurrency. This is intended to simplify debugging issues that are suspected to be platform problems, or API usage issues that are conceptually divorced from the VIC engine product code. * Refactor Install Harbor To Test Server keyword (#7335) The secret tag on the `Install Harbor To Test Server` makes it difficult to investigate failures when they occur. Only one out of 30+ lines actually uses secret information. Refactor the keyword to extract the secret information into its own keyword, allowing the tag to be applied in a more focused way. This is similar to the pattern used by keywords in `VCH-Util`. * Add ability to cache generated dependency. (#7340) * Add ability to cache generated dependency, so not much time wasted during the build process. * Added documentation to reflect necessary steps to leverage such improvements. * Ignore not-supported result from RetrieveUserGroups in VC 6.0 (#7328) * Move build time directives from title to body of PR (#7060) * Retry the harbor setup as well (#7336) * Skip non vSphere managed datastores when granting perms (#7346) * Fix volume leak on group 23 test (#7358) * Fix github status automation filtering (#7344) Adds filtering for the event source and consolidates remote API calls. Details the specific builds and their status for quick reference. * Drone 0.8 and HaaS updates (#7364) * Add tether.debug in integration test log bundle (#7422) * Update the gcs plugin (#7421) * [skip ci] Suggest subnet/gateway to static ip worker * Ensure that static ip worker is on the same nimbus pod as VC otherwise network connectivity not guaranteed (#7307) * Refactored some proxy code to reuse with wolfpack Refactored the system, volume, container, and stream swagger code into proxy code. 1) Moved the errors.go from backends to a new folder to be accessed by all folders outside of the backends folder. 2) Refactored Container proxy and moved from engine/backends to engine/proxy 3) Refactored Volume proxy and moved from engine/backends to engine/proxy 4) Refactored System proxy and moved from engine/backends to engine/proxy 5) Refactored Stream proxy and moved from engine/backends to engine/proxy 6) Adopted some common patterns in all the proxies 7) Moved common networking util calls to engine/networking 8) Fix up unit tests 9) Changed all "not yet implemented messages" 10) Updated robot scripts More refactoring will be needed to make these proxy less dependent on docker types and portlayer swagger types. Helps resolves #7210 and #7232 * Add virtual-kubelet binary to VIC ISO (#7315) * Start virtual-kubelet inside the VCH (#7369) * Fix value of the PORTLAYER_ADDR environment variable (#7400) * Use vic kubelet provider * Made modifications for virtual kubelet * Added admin log collection and fix env variable content (#7404) * Added most-vkubelet target (#7418)
On VC 6.0, the API RetrieveUserGroups is not implemented. Return success and print warning message when running against 6.0. This PR also add the collection of the VC logs when the test 5-25-OPS-User-Grant test fails.
Fixes: #7251