Added upload progress bar tracker for ISO images. #7320
Conversation
Removed concurrent upload since it doesn't make any significant performance imapact. When I tried to measure performance differene with and without concurrent uppload, the results were fluctuating in a wide range so not good measurement was possible.
lib/install/management/create.go
Outdated
| "time" | ||
|
|
||
| "github.com/vmware/govmomi/object" | ||
| "github.com/vmware/vic/lib/progresslog" | ||
|
|
There was a problem hiding this comment.
Is there a reason for the extra new line here? Looks like this is all from the same pathing for the most part.
There was a problem hiding this comment.
Agreed, per the current state of the file there should only be two import groups - standard pkgs and vmware pkgs.
There was a problem hiding this comment.
Unless vmware/govmomi counts as third-party. I've seen govmomi pkgs included in the same group as vmware/vic pkgs everywhere in our repo though.
There was a problem hiding this comment.
No, there should not be a new line. It seems like an autoimport bug.
|
|
||
| // Sink returns a channel that receives current upload progress status. | ||
| // Channel has to be closed by the caller. | ||
| func (ul *UploadLogger) Sink() chan<- progress.Report { |
There was a problem hiding this comment.
Are there multiple calls to this function per download?
There was a problem hiding this comment.
Never mind, I missed the range ticker.C :)
lib/progresslog/progresslog_test.go
Outdated
| ) | ||
|
|
||
| /* | ||
| type Report interface { |
There was a problem hiding this comment.
We should delete dead code unless it's for future reference.
There was a problem hiding this comment.
It was for a reference, however, it doesn't make sense to keep it there.
lib/progresslog/progresslog_test.go
Outdated
| assert.Contains(t, logs[last-1], "100.00%") | ||
| assert.Contains(t, logs[last], "complete") | ||
| } | ||
|
|
There was a problem hiding this comment.
Nit: unneeded whitespace.
lib/progresslog/progresslog.go
Outdated
| return ch | ||
| } | ||
|
|
||
| // Wait is waiting for Sink to complete its work, due to it async nature logging messages may be not sequential. |
There was a problem hiding this comment.
We can refine the func comment as it's a bit unclear:
Wait is waiting for -> Wait waits for
due to it async nature -> due to its async nature
due to its async nature
Not clear on what its applies to - the logging messages or the Sink function?
lib/progresslog/progresslog.go
Outdated
| mu := sync.Mutex{} | ||
| ticker := time.NewTicker(ul.interval) | ||
|
|
||
| // Print progress every 3 |
There was a problem hiding this comment.
Looks like we're missing something - every 3 seconds maybe?
lib/progresslog/progresslog.go
Outdated
| return ¶ms | ||
| } | ||
|
|
||
| // UploadLogger io used to track upload progress to ESXi/VC of a specific file. |
lib/install/management/create.go
Outdated
| finalMessage = fmt.Sprintf("%s\t\tNote: The VCH will not function without %q...", finalMessage, image) | ||
| } | ||
| d.op.Error(finalMessage) | ||
| return errors.New("Failed to upload iso images successfully.") |
There was a problem hiding this comment.
Nit: including successfully in the same sentence as Failed may be confusing - Failed to upload iso images conveys the same intent IMO.
There was a problem hiding this comment.
I see this string was present before this change - it'd be nice to fix it here.
lib/install/management/create.go
Outdated
| d.op.Error(err) | ||
| uploadFailed = true | ||
| // Build retry config | ||
| backoffConf := retry.NewBackoffConfig() |
There was a problem hiding this comment.
Looks like backoffConfig is the same for each file we're uploading, in which case we should be able to define and set it just once outside the for key, image := range files { loop.
There was a problem hiding this comment.
I do not want to touch that piece of code in this PR, it looks like it was changed, but it was basically shifted.
There was a problem hiding this comment.
Yeah it can be moved out, there is no reason why it cannot since it is just a config struct to pass to the expoenential backoff ticker. At any rate I do not know if it is critical for this. Should definitely be refactored in the future.
lib/progresslog/progresslog.go
Outdated
| } | ||
|
|
||
| if curProgress == 100.0 { | ||
| ul.logTo("Uploading of %s has been complete", ul.filename) |
There was a problem hiding this comment.
Uploading of %s has been complete -> Upload of %s is complete
There was a problem hiding this comment.
Alternatively, we could just s/complete/completed.
lib/install/management/create.go
Outdated
| d.op.Warnf("Attempted upload a total of %d times without success, Upload process failed.", uploadRetryLimit) | ||
| return false | ||
| } | ||
| d.op.Warnf("failed an attempt to upload isos with err (%s), %d retries remain", err.Error(), retryCount) |
There was a problem hiding this comment.
While this string has been present before this change, it would be a good idea to refine it since we're making changes here anyway. Suggest replacing failed with Failed to maintain consistent casing for log messages (other log messages start with uppercase).
* Dump dmesg if container rootfs blocks or fails mount (#7260) This is to enable bridging of the guest side state with the virtual hardware if we see issues such as disks not presenting on a pvscsi controller or a mount operation hanging. * updating priority definitions to include features (#7292) * Change default fellows for gandalf (#7310) * Avoid exposing test credentials in 12-01-Delete (#7306) To avoid exposing test credentials, use the established `Run VIC Machine Delete Command` keyword, which in turn calls a secret keyword. This changes the behavior of the test slightly: - It no longer checks for the absence of "delete failed" in output. - It will wait up to 30 seconds for the deletion to succeed. - It will clean up cert files at the end of the deletion. * Bug fix in API delete test: disable volume store cleanup (#7303) * Remove volume store cleanup before re-installing VIC appliance using existing volume stores * Cleanup dangling volume stores on test teardown * Add logging for image upload (#7296) * Reduce datastore searches during non-vSAN delete operations (#6951) * Optimize portlayer volume cache rebuild on startup (#7267) This commit modifies the portlayer volume cache's rebuildCache func to only process the volumes from the volume store that is currently being added to the cache. rebuildCache is invoked for every volume store during portlayer startup. Before this change, rebuildCache would process volumes from all volume stores in the cache every time a volume store was added. This led to unneeded extra computation which could slow down portlayer startup and overwhelm NFS endpoints if NFS volume stores are being used. Fixes #6991 * Added local ci testing target to makefile (#7170) Make testing locally as friction-free as possible by 1. Adding a makefile target 'local-ci-test' 2. Using TARGET_VCH added in VIC 1.3 to use an existing VCH 3. Using a custom script that doesn't utilize drone so that if the test fails and craters, we can still access the logs 4. Parameters can come from env vars, arguments, or secrets file Resolves #7162 * Added upload progress bar tracker for ISO images. (#7320) * Added upload progress bar tracker for ISO images. Removed concurrent upload since it doesn't make any significant performance imapact. When I tried to measure performance differene with and without concurrent uppload, the results were fluctuating in a wide range so no good measurement was possible. * Document the design for the vic-machine API (#6702) This document proposes a design for a comprehensive vic-machine API, the implementation of which will be tracked by #6116. Subsets of this API (tracked by #5721, #6123, and eventually others) will be implemented incrementally, and the design will be revised as those efforts progress to reflect changes to the long-term vision. * Remove superfluous calls to Set Test VCH Name (#7304) Several tests explicitly call the `Set Test VCH Name` keyword shortly after calling `Set Test Environment Variables`. This can lead to test failures when a VCH name collision occurs; subsequent tests which re-use the VCH name fail because there may be leftover certificates from the first VCH with that name. `Set Test Environment Variables` itself calls `Set Test VCH Name` and then cleans up old certificate directories. Therefore, the explicit calls to `Set Test VCH Name` are both superfluous and problematic. * Ensure that static ip worker is on the same nimbus pod as VC otherwise network connectivity not guaranteed (#7307) * [skip ci] Add ROBO test plans (#7297) This commit adds test plans for the ROBO support features in a new directory (Group19-ROBO) under manual test cases. The existing ROBO-SKU test has been moved into this directory. The test plans include tests for the container limit feature, placement without DRS, the license/ feature checks and WAN connectivity. Fixes #7294 * Add hosts to DVS within the test bed as well (#7326) * Setup updated for Longevity Tests (#7298) * Setup updated for Longevity Tests to run on 6.5U1 * [skip ci] Terminate gracefully to gather logs (#7331) * Terminate gracefully to gather logs * Remove extra whitespace * Increase timeout to 70 minutes * Increase ELM timeout to 70 minutes * Add repo to slack message since we have multiple repos reporting now (#7334) * Not sending user credentials with every request (#6382) * Add concurrent testing tool to tests folder (#6534) Adds a minimized test case for testing our core vSphere interactions at varying degrees of concurrency. This is intended to simplify debugging issues that are suspected to be platform problems, or API usage issues that are conceptually divorced from the VIC engine product code. * Refactor Install Harbor To Test Server keyword (#7335) The secret tag on the `Install Harbor To Test Server` makes it difficult to investigate failures when they occur. Only one out of 30+ lines actually uses secret information. Refactor the keyword to extract the secret information into its own keyword, allowing the tag to be applied in a more focused way. This is similar to the pattern used by keywords in `VCH-Util`. * Add ability to cache generated dependency. (#7340) * Add ability to cache generated dependency, so not much time wasted during the build process. * Added documentation to reflect necessary steps to leverage such improvements. * Ignore not-supported result from RetrieveUserGroups in VC 6.0 (#7328) * Move build time directives from title to body of PR (#7060) * Retry the harbor setup as well (#7336) * Skip non vSphere managed datastores when granting perms (#7346) * Fix volume leak on group 23 test (#7358) * Fix github status automation filtering (#7344) Adds filtering for the event source and consolidates remote API calls. Details the specific builds and their status for quick reference. * Drone 0.8 and HaaS updates (#7364) * Add tether.debug in integration test log bundle (#7422) * Update the gcs plugin (#7421) * [skip ci] Suggest subnet/gateway to static ip worker * Ensure that static ip worker is on the same nimbus pod as VC otherwise network connectivity not guaranteed (#7307) * Refactored some proxy code to reuse with wolfpack Refactored the system, volume, container, and stream swagger code into proxy code. 1) Moved the errors.go from backends to a new folder to be accessed by all folders outside of the backends folder. 2) Refactored Container proxy and moved from engine/backends to engine/proxy 3) Refactored Volume proxy and moved from engine/backends to engine/proxy 4) Refactored System proxy and moved from engine/backends to engine/proxy 5) Refactored Stream proxy and moved from engine/backends to engine/proxy 6) Adopted some common patterns in all the proxies 7) Moved common networking util calls to engine/networking 8) Fix up unit tests 9) Changed all "not yet implemented messages" 10) Updated robot scripts More refactoring will be needed to make these proxy less dependent on docker types and portlayer swagger types. Helps resolves #7210 and #7232 * Add virtual-kubelet binary to VIC ISO (#7315) * Start virtual-kubelet inside the VCH (#7369) * Fix value of the PORTLAYER_ADDR environment variable (#7400) * Use vic kubelet provider * Made modifications for virtual kubelet * Added admin log collection and fix env variable content (#7404) * Added most-vkubelet target (#7418)
Removed concurrent upload since it doesn't make any significant performance imapact.
When I tried to measure performance differene with and without concurrent uppload,
the results were fluctuating in a wide range so not good measurement was possible.
Fixes #7317