Drone 0.8 and HaaS updates #7364

mdharamadas1 · 2018-02-22T19:28:30Z

[full ci]

This will be merged only after new drone is active.

Outstanding Issues:

codecov-io · 2018-02-27T16:41:58Z

Codecov Report

Merging #7364 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7364      +/-   ##
==========================================
- Coverage   31.64%   31.56%   -0.08%     
==========================================
  Files         278      278              
  Lines       41882    41882              
==========================================
- Hits        13252    13219      -33     
- Misses      27469    27503      +34     
+ Partials     1161     1160       -1

Impacted Files	Coverage Δ
lib/portlayer/attach/communication/lazy.go	`68.18% <0%> (-22.73%)`	⬇️
lib/portlayer/attach/communication/connector.go	`54.2% <0%> (-7.48%)`	⬇️
lib/portlayer/attach/communication/interactor.go	`24.08% <0%> (-2.92%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08edfab...23ee1d3. Read the comment docs.

mdubya66

Nice work.

jzt · 2018-02-27T17:01:39Z

tests/resources/VCH-Util.robot

@@ -382,6 +395,8 @@ Secret Curl Container Logs
    Log  ${out}
    ${out}=  Run  curl -k -b vic-admin-cookies %{VIC-ADMIN}/container-logs.zip -o ${SUITE NAME}-%{VCH-NAME}-container-logs${name-suffix}.zip
    Log  ${out}
+    ${out}=  Run  curl -k -b vic-admin-cookies %{VIC-ADMIN}/logs/port-layer.log
+    Should Not Contain  ${out}  SIGSEGV: segmentation violation


yeah, what? Does the port layer log sometimes break curl??

That's a check for panic - checking for the Go panic decorations is probably more portable across error types. I should have caught that when reviewing.
This could be altered to \npanic: if Robot understands newlines in that fashion.

sgairo · 2018-02-27T17:06:08Z

.drone.yml

    username: drone
-    template: >
-      Build https://ci.vcna.io/vmware/vic/{{ build.number }} by {{ build.author }} finished with a {{ build.status }} status, find the build at: https://storage.googleapis.com/vic-engine-builds/vic_{{ build.number }}.tar.gz
+    template: "Build https://ci.vcna.io/vmware/vic/{{ build.number }} by {{ build.author }} finished with a {{ build.status }} status, find the build at: https://storage.googleapis.com/vic-engine-builds/vic_{{ build.number }}.tar.gz\n"


Is this still ci.vcna.io? or is it ci-vic.vmware.com?

I have PR open for that, will merge it in few min.

mhagen-vmware · 2018-02-27T17:38:04Z

tests/resources/dynamic-vars.py

            TestEnvironment.LONGEVITY: 'vic-executor1.vcna.io/library/{}'.format(image),
-            TestEnvironment.LOCAL: image}[getEnvironment()]
+            TestEnvironment.LOCAL: 'wdc-harbor-ci.eng.vmware.com/default-project/{}'.format(image)}[getEnvironment()]


I don't think we want to make this local change

should still just point to docker hub

mhagen-vmware · 2018-02-27T17:40:07Z

tests/manual-test-cases/Group5-Functional-Tests/5-7-NSX.robot

    Run Keyword If  ${certs}  Should Contain  ${output}  Installer completed successfully
    Return From Keyword If  ${certs}  ${output}

-    ${output}=  Run Keyword Unless  ${certs}  Run  ${vic-machine} create --debug ${debug} --name=%{VCH-NAME} --target=%{TEST_URL}%{TEST_DATACENTER} --thumbprint=%{TEST_THUMBPRINT} --user=%{TEST_USERNAME} --image-store=%{TEST_DATASTORE} --appliance-iso=${appliance-iso} --bootstrap-iso=${bootstrap-iso} --password=%{TEST_PASSWORD} --force=true --bridge-network=%{BRIDGE_NETWORK} --public-network=%{PUBLIC_NETWORK} --compute-resource=%{TEST_RESOURCE} --timeout %{TEST_TIMEOUT} --insecure-registry harbor.ci.drone.local --volume-store=%{TEST_DATASTORE}/%{VCH-NAME}-VOL:${vol} --no-tlsverify ${additional-args}
+    ${output}=  Run Keyword Unless  ${certs}  Run  ${vic-machine} create --debug ${debug} --name=%{VCH-NAME} --target=%{TEST_URL}%{TEST_DATACENTER} --thumbprint=%{TEST_THUMBPRINT} --user=%{TEST_USERNAME} --image-store=%{TEST_DATASTORE} --appliance-iso=${appliance-iso} --bootstrap-iso=${bootstrap-iso} --password=%{TEST_PASSWORD} --force=true --bridge-network=%{BRIDGE_NETWORK} --public-network=%{PUBLIC_NETWORK} --compute-resource=%{TEST_RESOURCE} --timeout %{TEST_TIMEOUT} --insecure-registry wdc-harbor-ci.eng.vmware.com --volume-store=%{TEST_DATASTORE}/%{VCH-NAME}-VOL:${vol} --no-tlsverify ${additional-args}


this should not be changed

mhagen-vmware · 2018-02-27T17:40:24Z

tests/manual-test-cases/Group5-Functional-Tests/5-21-Datastore-Path.robot

@@ -89,5 +89,5 @@ Datastore - Space in Path with Scheme

    Log To Console  \nRunning custom vic-machine create - with DS Scheme in Volume Store with space in path
    # Need to run custom vic-machine create to specify volume store with DS scheme
-    ${output}=  Run  bin/vic-machine-linux create --debug 1 --name=%{VCH-NAME} --target=%{TEST_URL_ARRAY} --user=%{TEST_USERNAME} --bridge-network=%{BRIDGE_NETWORK} --public-network=%{PUBLIC_NETWORK} --image-store=%{TEST_DATASTORE} --volume-store=${dsScheme}%{TEST_DATASTORE}/images:default --password=%{TEST_PASSWORD} --appliance-iso=bin/appliance.iso --bootstrap-iso=bin/bootstrap.iso --insecure-registry harbor.ci.drone.local --force --kv
+    ${output}=  Run  bin/vic-machine-linux create --debug 1 --name=%{VCH-NAME} --target=%{TEST_URL_ARRAY} --user=%{TEST_USERNAME} --bridge-network=%{BRIDGE_NETWORK} --public-network=%{PUBLIC_NETWORK} --image-store=%{TEST_DATASTORE} --volume-store=${dsScheme}%{TEST_DATASTORE}/images:default --password=%{TEST_PASSWORD} --appliance-iso=bin/appliance.iso --bootstrap-iso=bin/bootstrap.iso --insecure-registry wdc-harbor-ci.eng.vmware.com --force --kv


don't make this change

mhagen-vmware · 2018-02-27T17:44:52Z

tests/manual-test-cases/Group5-Functional-Tests/5-21-Datastore-Path.robot

@@ -57,7 +57,7 @@ Datastore - DS Scheme Specified in Volume Store

    Log To Console  \nRunning custom vic-machine create - with DS Scheme in Volume Store
    # Need to run custom vic-machine create to specify volume store with DS scheme
-    ${output}=  Run  bin/vic-machine-linux create --debug 1 --name=%{VCH-NAME} --target=%{TEST_URL_ARRAY} --user=%{TEST_USERNAME} --bridge-network=%{BRIDGE_NETWORK} --public-network=%{PUBLIC_NETWORK} --image-store=%{TEST_DATASTORE} --volume-store=${dsScheme}%{TEST_DATASTORE}/images:default --password=%{TEST_PASSWORD} --appliance-iso=bin/appliance.iso --bootstrap-iso=bin/bootstrap.iso --insecure-registry harbor.ci.drone.local --force --kv
+    ${output}=  Run  bin/vic-machine-linux create --debug 1 --name=%{VCH-NAME} --target=%{TEST_URL_ARRAY} --user=%{TEST_USERNAME} --bridge-network=%{BRIDGE_NETWORK} --public-network=%{PUBLIC_NETWORK} --image-store=%{TEST_DATASTORE} --volume-store=${dsScheme}%{TEST_DATASTORE}/images:default --password=%{TEST_PASSWORD} --appliance-iso=bin/appliance.iso --bootstrap-iso=bin/bootstrap.iso --insecure-registry wdc-harbor-ci.eng.vmware.com --force --kv


mhagen-vmware · 2018-02-27T17:45:02Z

tests/manual-test-cases/Group5-Functional-Tests/5-7-NSX.robot

@@ -45,11 +45,11 @@ NSX Install VIC Appliance To Test Server
 NSX Run VIC Machine Command
    [Tags]  secret
    [Arguments]  ${vic-machine}  ${appliance-iso}  ${bootstrap-iso}  ${certs}  ${vol}  ${debug}  ${additional-args}
-    ${output}=  Run Keyword If  ${certs}  Run  ${vic-machine} create --debug ${debug} --name=%{VCH-NAME} --target=%{TEST_URL}%{TEST_DATACENTER} --thumbprint=%{TEST_THUMBPRINT} --user=%{TEST_USERNAME} --image-store=%{TEST_DATASTORE} --appliance-iso=${appliance-iso} --bootstrap-iso=${bootstrap-iso} --password=%{TEST_PASSWORD} --force=true --bridge-network=%{BRIDGE_NETWORK} --public-network=%{PUBLIC_NETWORK} --compute-resource=%{TEST_RESOURCE} --timeout %{TEST_TIMEOUT} --insecure-registry harbor.ci.drone.local --volume-store=%{TEST_DATASTORE}/%{VCH-NAME}-VOL:${vol} ${vicmachinetls} ${additional-args}
+    ${output}=  Run Keyword If  ${certs}  Run  ${vic-machine} create --debug ${debug} --name=%{VCH-NAME} --target=%{TEST_URL}%{TEST_DATACENTER} --thumbprint=%{TEST_THUMBPRINT} --user=%{TEST_USERNAME} --image-store=%{TEST_DATASTORE} --appliance-iso=${appliance-iso} --bootstrap-iso=${bootstrap-iso} --password=%{TEST_PASSWORD} --force=true --bridge-network=%{BRIDGE_NETWORK} --public-network=%{PUBLIC_NETWORK} --compute-resource=%{TEST_RESOURCE} --timeout %{TEST_TIMEOUT} --insecure-registry wdc-harbor-ci.eng.vmware.com --volume-store=%{TEST_DATASTORE}/%{VCH-NAME}-VOL:${vol} ${vicmachinetls} ${additional-args}


mhagen-vmware

lgtm

hickeng · 2018-02-27T18:23:20Z

.drone.yml

+      - 'export COMMIT=${DRONE_COMMIT}'
+      - 'echo "Expecting ${DRONE_COMMIT}"'
+      - 'git log -5'
+      - 'git log -1 --pretty=oneline | grep "^${DRONE_COMMIT}" > /dev/null && echo ''Build matches'' || (git log -1 --pretty=oneline | grep "Merge ${DRONE_COMMIT}" > /dev/null && echo ''Build is of a merge commit'' || (echo ''Build does not match!'' && exit 1))'

  wait-for-build:


Note to self: why is this step still needed? Has the wait script been updated to provide different admission control?

Result: didn't see wait script updates - does that mean we're still going to block based on modulo build number? Seems... wrong for VC.

Agree but this is "as is" update, improvements needs to be planned in a separate PRs.

hickeng · 2018-02-27T18:26:50Z

.drone.yml

+      - 'export COMMIT=${DRONE_COMMIT}'
+      - 'echo "Expecting ${DRONE_COMMIT}"'
+      - 'git log -5'
+      - 'git log -1 --pretty=oneline | grep "^${DRONE_COMMIT}" > /dev/null && echo ''Build matches'' || (git log -1 --pretty=oneline | grep "Merge ${DRONE_COMMIT}" > /dev/null && echo ''Build is of a merge commit'' || (echo ''Build does not match!'' && exit 1))'


Note to self: thought we had a different approach for this now, one that explicitly gets and checks out the correct commit? Cannot compare with old CI due to cert errors.

We haven't investigated that either yet, @mhagen-vmware wants to keep it for now.

yep, just waiting until confidence returns - then we can remove this step again

hickeng · 2018-02-27T18:28:57Z

.drone.local.yml

+      - 'export GOVC_USERNAME=${TEST_USERNAME}'
+      - 'export GOVC_PASSWORD=${TEST_PASSWORD}'
+      - 'export GOVC_DATASTORE=${TEST_DATASTORE}'
+      - 'export DOMAIN=${CI_DOMAIN}'


Why is this using ${CI_DOMAIN} instead of ${DOMAIN} - the script tests/local-integration-test.sh sets the latter, but not the former.

This is no change to existing master version, its just that secrets format has changed. @mhagen-vmware should be able to clarify.

Ignore previous comment, will correct it.

hickeng · 2018-02-27T18:38:53Z

.drone.yml

-      - tar -xvzf $BIN/vic_ui_*.tar.gz
-      - ls -la ./$BIN && ./$BIN/ui/sync-vic-ui-version.sh -p bin/ 2>&1
-      - rm $BIN/vic_ui_*.tar.gz
+      - 'export BUILD_NUMBER=${DRONE_BUILD_NUMBER}'


I don't see BUILD_NUMBER being using in the commands below and the only script that runs explicitly sets BUILD_NUMBER for itself (./$BIN/ui/sync-vic-ui-version.sh -p bin/)

This is no change to existing master version, its just that secrets format has changed. @mhagen-vmware should be able to clarify.

hickeng · 2018-02-27T18:47:47Z

.drone.yml

-      status:  success
-      branch: [ releases/*, refs/tags/* ]
+     status: success
+     branch: ['releases/*', 'refs/tags/*']


I think both this step AND the previous step (vic-ui) will run when master is tagged. I suspect that's not what we want as both modify the bin directory for the engine build, unlike the release targets that upload to separate locations.

vic-ui will run for all events and vic-ui-release runs for release branches and tags. No change as part of this PR.
vic-ui scheduled to run in PR build: https://ci-vic.vmware.com/vmware/vic/17065

hickeng · 2018-02-27T19:16:49Z

tests/test-cases/Group1-Docker-Commands/1-02-Docker-Pull.robot

@@ -89,7 +89,7 @@ Pull the same image concurrently
    \   Log  ${res.stdout}
    \   Log  ${res.stderr}
    \   Should Be Equal As Integers  ${res.rc}  0
-    \   Should Contain  ${res.stdout}  Downloaded newer image for library/redis:latest
+    \   Should Contain  ${res.stdout}  Downloaded newer image for default-project/redis:latest


This is remote registry specific - we can use a RegExp match to avoid hardcoding details about the remote project name we're using.

Agree but I would prefer a separate PR for any improvements. This is "as is" update.

hickeng · 2018-02-27T19:18:50Z

tests/test-cases/Group1-Docker-Commands/1-04-Docker-Create.robot

+    ${status}=  Run Keyword And Return Status  Environment Variable Should Be Set  DOCKER_CERT_PATH
+    ${certs}=  Set Variable If  ${status}  --cert %{DOCKER_CERT_PATH}/cert.pem --key %{DOCKER_CERT_PATH}/key.pem  ${EMPTY}
+
+    ${output}=  Run  curl -sk ${certs} -H "Content-Type: application/json" -d '{"Image": "${busybox}", "Cmd": ["ping", "127.0.0.1"], "NetworkMode": "bridge"}' https://%{VCH-IP}:2376/containers/create


Use %{VCH-PORT} instead of 2376.

@mhagen-vmware ?

hickeng · 2018-02-27T19:25:26Z

tests/test-cases/Group1-Docker-Commands/1-12-Docker-RMI.robot

@@ -29,7 +29,7 @@ Basic docker pull, restart, and remove image
    # Gather logs before rebooting
    Run Keyword And Continue On Failure  Gather Logs From Test Server  -before-reboot-1
    Reboot VM  %{VCH-NAME}
-    Wait For VCH Initialization  20x  5 seconds
+    Wait For VCH Initialization  30x  10 seconds


These looong wait times - I can see why we end up with them but it would be good to have some cross build tracking and anomaly detection. The VCH should come up fast with the main variables being:

dhcp response time

vSphere infrastructure response time

number of existing images/containers for the VCH.

vSphere incorrect host routing in HA cases

The first 3 of these should be under our control so a much more predictable time interval for restart will allow us to catch incorrect behaviours. The latter should be occurring only in specific tests and even then we should be getting vSphere to improve it.

When I say fast I'm talking on the order of 20seconds with a small number of images (which is all these tests ever have). Time to return to function after reboot should be a performance metric for us and a quality measure.

@mhagen-vmware ?

We don't currently have any performance tests within this infra, and we aren't going to add them in this PR. We have 2 options: 1. have our perf folks actually test reboot (which I don't think they do), 2. create a story and we can do it in a future PR.

hickeng · 2018-02-27T19:30:25Z

tests/test-cases/Group1-Docker-Commands/1-19-Docker-Volume-Create.robot

-	${rc}  ${output}=  Run And Return Rc And Output  docker %{VCH-PARAMS} run --name verify-named-1 -v test15:/etc/example jakedsouza/group-1-19-docker-verify-volume-files:1.0 cat /etc/example/testfile.txt
-    Should Be Equal As Integers  ${rc}  0
-    Should Contain  ${output}  TestFile
+    ${status}=  Get State Of Github Issue  7365


@mhagen-vmware identified 1-25: Container to container traffic via VCH public interface as the test that was failing repeatedly for #7365.

Given it appears to be specific to cleanup of a container with 4 network endpoints defined I do not see why this test would be hitting it. Please revisit the diagnosis that cause this to be commented out with that as the blocker.
If it was due to similar docker client level symptoms then you may be seeing a port layer panic for other reasons and we need a separate issue to investigate.

@mhagen-vmware ?

I am working on it, but isn't gating this PR.

hickeng · 2018-02-27T19:40:15Z

tests/test-cases/Group10-VCH-Restart/10-01-VCH-Restart.robot

@@ -155,6 +155,8 @@ Container on Open Network And Port Forwarding Persist After Reboot

    Log To Console  Create Port Groups For Container network
    ${out}=  Run Keyword If  '%{HOST_TYPE}' == 'ESXi'  Run  govc host.portgroup.add -vswitch vSwitchLAN open-net
+    ${out}=  Run Keyword If  '%{HOST_TYPE}' == 'VC'  Add VC Distributed Portgroup  test-ds  open-net


Looks like this will fail if test-ds and open-net already exist, which would be the case if the test fails with FAST_FAIL set because we do not have the removal as part of the test cleanup.

We aren't actually parsing the response here, so it can and will fail if it is already created, but doesn't affect anything.

@andrewtchin ?

* Dump dmesg if container rootfs blocks or fails mount (#7260) This is to enable bridging of the guest side state with the virtual hardware if we see issues such as disks not presenting on a pvscsi controller or a mount operation hanging. * updating priority definitions to include features (#7292) * Change default fellows for gandalf (#7310) * Avoid exposing test credentials in 12-01-Delete (#7306) To avoid exposing test credentials, use the established `Run VIC Machine Delete Command` keyword, which in turn calls a secret keyword. This changes the behavior of the test slightly: - It no longer checks for the absence of "delete failed" in output. - It will wait up to 30 seconds for the deletion to succeed. - It will clean up cert files at the end of the deletion. * Bug fix in API delete test: disable volume store cleanup (#7303) * Remove volume store cleanup before re-installing VIC appliance using existing volume stores * Cleanup dangling volume stores on test teardown * Add logging for image upload (#7296) * Reduce datastore searches during non-vSAN delete operations (#6951) * Optimize portlayer volume cache rebuild on startup (#7267) This commit modifies the portlayer volume cache's rebuildCache func to only process the volumes from the volume store that is currently being added to the cache. rebuildCache is invoked for every volume store during portlayer startup. Before this change, rebuildCache would process volumes from all volume stores in the cache every time a volume store was added. This led to unneeded extra computation which could slow down portlayer startup and overwhelm NFS endpoints if NFS volume stores are being used. Fixes #6991 * Added local ci testing target to makefile (#7170) Make testing locally as friction-free as possible by 1. Adding a makefile target 'local-ci-test' 2. Using TARGET_VCH added in VIC 1.3 to use an existing VCH 3. Using a custom script that doesn't utilize drone so that if the test fails and craters, we can still access the logs 4. Parameters can come from env vars, arguments, or secrets file Resolves #7162 * Added upload progress bar tracker for ISO images. (#7320) * Added upload progress bar tracker for ISO images. Removed concurrent upload since it doesn't make any significant performance imapact. When I tried to measure performance differene with and without concurrent uppload, the results were fluctuating in a wide range so no good measurement was possible. * Document the design for the vic-machine API (#6702) This document proposes a design for a comprehensive vic-machine API, the implementation of which will be tracked by #6116. Subsets of this API (tracked by #5721, #6123, and eventually others) will be implemented incrementally, and the design will be revised as those efforts progress to reflect changes to the long-term vision. * Remove superfluous calls to Set Test VCH Name (#7304) Several tests explicitly call the `Set Test VCH Name` keyword shortly after calling `Set Test Environment Variables`. This can lead to test failures when a VCH name collision occurs; subsequent tests which re-use the VCH name fail because there may be leftover certificates from the first VCH with that name. `Set Test Environment Variables` itself calls `Set Test VCH Name` and then cleans up old certificate directories. Therefore, the explicit calls to `Set Test VCH Name` are both superfluous and problematic. * Ensure that static ip worker is on the same nimbus pod as VC otherwise network connectivity not guaranteed (#7307) * [skip ci] Add ROBO test plans (#7297) This commit adds test plans for the ROBO support features in a new directory (Group19-ROBO) under manual test cases. The existing ROBO-SKU test has been moved into this directory. The test plans include tests for the container limit feature, placement without DRS, the license/ feature checks and WAN connectivity. Fixes #7294 * Add hosts to DVS within the test bed as well (#7326) * Setup updated for Longevity Tests (#7298) * Setup updated for Longevity Tests to run on 6.5U1 * [skip ci] Terminate gracefully to gather logs (#7331) * Terminate gracefully to gather logs * Remove extra whitespace * Increase timeout to 70 minutes * Increase ELM timeout to 70 minutes * Add repo to slack message since we have multiple repos reporting now (#7334) * Not sending user credentials with every request (#6382) * Add concurrent testing tool to tests folder (#6534) Adds a minimized test case for testing our core vSphere interactions at varying degrees of concurrency. This is intended to simplify debugging issues that are suspected to be platform problems, or API usage issues that are conceptually divorced from the VIC engine product code. * Refactor Install Harbor To Test Server keyword (#7335) The secret tag on the `Install Harbor To Test Server` makes it difficult to investigate failures when they occur. Only one out of 30+ lines actually uses secret information. Refactor the keyword to extract the secret information into its own keyword, allowing the tag to be applied in a more focused way. This is similar to the pattern used by keywords in `VCH-Util`. * Add ability to cache generated dependency. (#7340) * Add ability to cache generated dependency, so not much time wasted during the build process. * Added documentation to reflect necessary steps to leverage such improvements. * Ignore not-supported result from RetrieveUserGroups in VC 6.0 (#7328) * Move build time directives from title to body of PR (#7060) * Retry the harbor setup as well (#7336) * Skip non vSphere managed datastores when granting perms (#7346) * Fix volume leak on group 23 test (#7358) * Fix github status automation filtering (#7344) Adds filtering for the event source and consolidates remote API calls. Details the specific builds and their status for quick reference. * Drone 0.8 and HaaS updates (#7364) * Add tether.debug in integration test log bundle (#7422) * Update the gcs plugin (#7421) * [skip ci] Suggest subnet/gateway to static ip worker * Ensure that static ip worker is on the same nimbus pod as VC otherwise network connectivity not guaranteed (#7307) * Refactored some proxy code to reuse with wolfpack Refactored the system, volume, container, and stream swagger code into proxy code. 1) Moved the errors.go from backends to a new folder to be accessed by all folders outside of the backends folder. 2) Refactored Container proxy and moved from engine/backends to engine/proxy 3) Refactored Volume proxy and moved from engine/backends to engine/proxy 4) Refactored System proxy and moved from engine/backends to engine/proxy 5) Refactored Stream proxy and moved from engine/backends to engine/proxy 6) Adopted some common patterns in all the proxies 7) Moved common networking util calls to engine/networking 8) Fix up unit tests 9) Changed all "not yet implemented messages" 10) Updated robot scripts More refactoring will be needed to make these proxy less dependent on docker types and portlayer swagger types. Helps resolves #7210 and #7232 * Add virtual-kubelet binary to VIC ISO (#7315) * Start virtual-kubelet inside the VCH (#7369) * Fix value of the PORTLAYER_ADDR environment variable (#7400) * Use vic kubelet provider * Made modifications for virtual kubelet * Added admin log collection and fix env variable content (#7404) * Added most-vkubelet target (#7418)

vmwclabot added the cla-not-required label Feb 22, 2018

mdharamadas1 force-pushed the feature/drone-haas-updates branch from 22f65fa to 751a05f Compare February 26, 2018 21:34

mdharamadas1 changed the title ~~Feature/drone haas updates~~ Drone 0.8 and HaaS updates Feb 27, 2018

Drone 0.8 and HaaS updates

099c4d4

mdharamadas1 force-pushed the feature/drone-haas-updates branch from 2023e64 to 099c4d4 Compare February 27, 2018 16:41

mdubya66 approved these changes Feb 27, 2018

View reviewed changes

jzt reviewed Feb 27, 2018

View reviewed changes

sgairo reviewed Feb 27, 2018

View reviewed changes

Update general docs and not tests (#7402)

e903341

sgairo approved these changes Feb 27, 2018

View reviewed changes

andrewtchin approved these changes Feb 27, 2018

View reviewed changes

anchal-agrawal approved these changes Feb 27, 2018

View reviewed changes

mhagen-vmware suggested changes Feb 27, 2018

View reviewed changes

AngieCris approved these changes Feb 27, 2018

View reviewed changes

mhagen-vmware reviewed Feb 27, 2018

View reviewed changes

jzt approved these changes Feb 27, 2018

View reviewed changes

Revert insecure registry changes for manual tests

4508262

gigawhitlocks approved these changes Feb 27, 2018

View reviewed changes

mhagen-vmware approved these changes Feb 27, 2018

View reviewed changes

hickeng reviewed Feb 27, 2018

View reviewed changes

mdharamadas1 added 2 commits February 27, 2018 14:11

Correct secret name

23ee1d3

review comments

881f668

mhagen-vmware merged commit 47d90ef into master Feb 27, 2018

mhagen-vmware deleted the feature/drone-haas-updates branch March 27, 2018 19:54

singhshwetaQE pushed a commit to singhshwetaQE/vic that referenced this pull request Apr 3, 2018

Drone 0.8 and HaaS updates (vmware#7364)

01a04bc

Drone 0.8 and HaaS updates #7364

Drone 0.8 and HaaS updates #7364

Conversation

mdharamadas1 commented Feb 22, 2018 • edited Loading

codecov-io commented Feb 27, 2018 • edited Loading

Codecov Report

mdubya66 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hickeng Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhagen-vmware left a comment

Choose a reason for hiding this comment

hickeng Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

mdharamadas1 Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdharamadas1 Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdharamadas1 commented Feb 22, 2018 •

edited

Loading

codecov-io commented Feb 27, 2018 •

edited

Loading

hickeng Feb 27, 2018 •

edited

Loading

hickeng Feb 27, 2018 •

edited

Loading

mdharamadas1 Feb 27, 2018 •

edited

Loading

mdharamadas1 Feb 27, 2018 •

edited

Loading