[bug] Use Identity instead of FullPath on _CompressObjCBindingNativeFrameworkResources target #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameworkResources target Using the FullPath property breaks the build from Windows, since the metadata will contain a Windows path. Partial fix for Bug #51759 - Getting build error for iOS sample 'Simpleapp-with-framework' https://bugzilla.xamarin.com/show_bug.cgi?id=51759
jstedfast
approved these changes
Aug 16, 2017
spouliot
approved these changes
Aug 16, 2017
There was a problem hiding this comment.
@emaf this seems to be a bad pattern, e.g.
msbuild/Xamarin.Mac.Tasks/Xamarin.Mac.ObjCBinding.CSharp.targets:
WorkingDirectory="%(_NativeFramework.FullPath)" >
also has something similar (for XM).
If that's the case maybe we should include a simple grep-based check in our tests ? If so what other bad patterns should we look for ?
|
Build failure |
|
build failed due to git issues |
|
build |
|
Build success |
|
@spouliot good catch, that shouldn't be an issue for now since we're not building Mac projects from Windows (actually we're building those offline), but we should fix that target too. Probably we should include a check for FullPath and Directory metadata. |
rolfbjarne
added a commit
that referenced
this pull request
Aug 24, 2021
New commits in xamarin/maccore: * xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498) Diff: https://github.com/xamarin/maccore/compare/93d046943764b6f7320e8cb7f22fa789ae286b9f..8bb7dc6c38f40cab45fd916f082d794313b0855d
Merged
rolfbjarne
added a commit
that referenced
this pull request
Aug 25, 2021
New commits in xamarin/maccore: * xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498) Diff: https://github.com/xamarin/maccore/compare/93d046943764b6f7320e8cb7f22fa789ae286b9f..8bb7dc6c38f40cab45fd916f082d794313b0855d
rolfbjarne
added a commit
that referenced
this pull request
Aug 26, 2021
New commits in xamarin/maccore: * xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506) * xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504) * xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503) * xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502) * xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499) * xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501) * xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500) * xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498) * xamarin/maccore@93d0469437 [Xamarin.Hosting] Increase needed verbosity when logging loaded frameworks (#2497) Diff: https://github.com/xamarin/maccore/compare/49c78df930c108297fcce4501432b451656190de..3e591cbcb15081d34a9512ca39d9df55c331bdbd
rolfbjarne
added a commit
that referenced
this pull request
Aug 27, 2021
New commits in xamarin/maccore: * xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506) * xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504) * xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503) * xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502) * xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499) * xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501) * xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500) * xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498) * xamarin/maccore@93d0469437 [Xamarin.Hosting] Increase needed verbosity when logging loaded frameworks (#2497) Diff: https://github.com/xamarin/maccore/compare/49c78df930c108297fcce4501432b451656190de..3e591cbcb15081d34a9512ca39d9df55c331bdbd Co-authored-by: Alex Soto <alex@alexsoto.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the FullPath property breaks the build from Windows, since the metadata will contain a Windows path.
Partial fix for Bug #51759 - Getting build error for iOS sample 'Simpleapp-with-framework'
https://bugzilla.xamarin.com/show_bug.cgi?id=51759