[mtouch] Show MT0091 as a warning if we're using the dynamic registrar. #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't break currently working scenarios, but it might continue to fail for some people, but in more confusing ways (thus we end up with some happy customers and some even more confused customers). |
|
Build failure |
rolfbjarne
force-pushed
the
weaken-mt0091
branch
from
6f9a5c4 to
c194f1c
Compare
|
Build failure |
…ings and errors errors. This also requires fixing a few tests that used the wrong Assert.
Even if using an Xcode older than the bindings we're shipping, everything might just happen to work when using the dynamic registrar, so downgrade the MT0091 error to a warning in that case (and cross fingers, because things might still break). Hopefully this makes it easier when using older Xcodes, because the typical scenario of Sim+DontLink and Dev+LinkSdk/LinkAll will now just work (if the app developer also crosses fingers piously and sacrifies the appropriate amount of pizza to the proper deity). Reference: https://trello.com/c/wP3Pcb1q/692-targeting-older-xcodes-without-enabling-managed-linking
rolfbjarne
force-pushed
the
weaken-mt0091
branch
from
c194f1c to
11af318
Compare
|
Build failure |
|
git clone failure 😞 |
|
build |
|
Build failure |
|
git clone failure 😞 |
|
build |
|
Build success |
|
This also appears to fix https://bugzilla.xamarin.com/show_bug.cgi?id=58977 |
dalexsoto
approved these changes
Aug 24, 2017
|
We decided to not do this for now. |
rolfbjarne
added a commit
that referenced
this pull request
Aug 26, 2021
New commits in xamarin/maccore: * xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504) * xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503) * xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502) * xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499) * xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501) * xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500) Diff: https://github.com/xamarin/maccore/compare/8bb7dc6c38f40cab45fd916f082d794313b0855d..62e6757515dc46b3a99bfbc348932f25861f27bd
Merged
rolfbjarne
added a commit
that referenced
this pull request
Aug 26, 2021
* Bump maccore. New commits in xamarin/maccore: * xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504) * xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503) * xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502) * xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499) * xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501) * xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500) Diff: https://github.com/xamarin/maccore/compare/8bb7dc6c38f40cab45fd916f082d794313b0855d..62e6757515dc46b3a99bfbc348932f25861f27bd * Bump again. New commits in xamarin/maccore: * xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506) Diff: https://github.com/xamarin/maccore/compare/62e6757515dc46b3a99bfbc348932f25861f27bd..3e591cbcb15081d34a9512ca39d9df55c331bdbd
rolfbjarne
added a commit
that referenced
this pull request
Aug 26, 2021
New commits in xamarin/maccore: * xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506) * xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504) * xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503) * xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502) * xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499) * xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501) * xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500) * xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498) * xamarin/maccore@93d0469437 [Xamarin.Hosting] Increase needed verbosity when logging loaded frameworks (#2497) Diff: https://github.com/xamarin/maccore/compare/49c78df930c108297fcce4501432b451656190de..3e591cbcb15081d34a9512ca39d9df55c331bdbd
rolfbjarne
added a commit
that referenced
this pull request
Aug 27, 2021
New commits in xamarin/maccore: * xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506) * xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504) * xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503) * xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502) * xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499) * xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501) * xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500) * xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498) * xamarin/maccore@93d0469437 [Xamarin.Hosting] Increase needed verbosity when logging loaded frameworks (#2497) Diff: https://github.com/xamarin/maccore/compare/49c78df930c108297fcce4501432b451656190de..3e591cbcb15081d34a9512ca39d9df55c331bdbd Co-authored-by: Alex Soto <alex@alexsoto.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if using an Xcode older than the bindings we're shipping, everything
might just happen to work when using the dynamic registrar, so downgrade the
MT0091 error to a warning in that case (and cross fingers, because things
might still break).
Hopefully this makes it easier when using older Xcodes, because the typical
scenario of Sim+DontLink and Dev+LinkSdk/LinkAll will now just work (if the
app developer also crosses fingers piously and sacrifies the appropriate
amount of pizza to the proper deity).
Reference: https://trello.com/c/wP3Pcb1q/692-targeting-older-xcodes-without-enabling-managed-linking