Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mmp] Fix symbol name for 32-bit Objective-C classes. Fixes #58861. #2506

Merged
merged 4 commits into from
Aug 24, 2017

Conversation

rolfbjarne
Copy link
Member

@monojenkins
Copy link
Collaborator

Build failure

Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really like a test for this, as 32-bit anything is not something that is covered often in manual / user testing.

I can hack something up if you'd like a hand.

@spouliot
Copy link
Contributor

build

@monojenkins
Copy link
Collaborator

Build failure

@rolfbjarne
Copy link
Member Author

@chamons I've added a test now.

Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@monojenkins
Copy link
Collaborator

Build failure

@spouliot
Copy link
Contributor

build

@monojenkins
Copy link
Collaborator

Build failure

@spouliot
Copy link
Contributor

@rolfbjarne @chamons please check why Xamarin.MMP.Tests.MMPTests.Unified_WithStaticNativeRef_32bit failed, thanks!

@chamons
Copy link
Contributor

chamons commented Aug 23, 2017

@rolfbjarne changed tests/mac-binding-project/Makefile so it is likely not an intermittent failure.

Fixes this:

> tests/common/mac/ProjectTestHelpers.cs(93,68): error CS0117: 'Driver' does not contain a definition for 'Verbosity'
This makes sure tests that need MobileBinding.dll actually have it.
@monojenkins
Copy link
Collaborator

Build failure

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (xammac test failure due to bug #58394).

@rolfbjarne rolfbjarne merged commit dbc7810 into xamarin:master Aug 24, 2017
rolfbjarne added a commit that referenced this pull request Aug 26, 2021
rolfbjarne added a commit that referenced this pull request Aug 26, 2021
* Bump maccore.

New commits in xamarin/maccore:

* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)

Diff: https://github.com/xamarin/maccore/compare/8bb7dc6c38f40cab45fd916f082d794313b0855d..62e6757515dc46b3a99bfbc348932f25861f27bd

* Bump again.

New commits in xamarin/maccore:

* xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506)

Diff: https://github.com/xamarin/maccore/compare/62e6757515dc46b3a99bfbc348932f25861f27bd..3e591cbcb15081d34a9512ca39d9df55c331bdbd
rolfbjarne added a commit that referenced this pull request Aug 26, 2021
New commits in xamarin/maccore:

* xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506)
* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)
* xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498)
* xamarin/maccore@93d0469437 [Xamarin.Hosting] Increase needed verbosity when logging loaded frameworks (#2497)

Diff: https://github.com/xamarin/maccore/compare/49c78df930c108297fcce4501432b451656190de..3e591cbcb15081d34a9512ca39d9df55c331bdbd
rolfbjarne added a commit that referenced this pull request Aug 27, 2021
New commits in xamarin/maccore:

* xamarin/maccore@3e591cbcb1 [provisioning-profiles] Add intermediate cert to the keychain. (#2506)
* xamarin/maccore@62e6757515 [provisioning-profiles] Show more output from fetching the latest provisioning profiles. (#2504)
* xamarin/maccore@d9dcac2172 [submissions] Add ported samples. (#2503)
* xamarin/maccore@9473912ea3 [submission] Use a different bundle identifier for FSharpMacCoolApp to not clash with another test app. (#2502)
* xamarin/maccore@f235bd6454 Update vseng-xamarin-mac-devices.p12 (#2499)
* xamarin/maccore@2fba9b0761 [submissions] Fix string interpolation. (#2501)
* xamarin/maccore@32acd3aa82 [certificates] Update la_dev_apple.p12, la_distr_apple.p12 and la_mac_installer_distr.p12. (#2500)
* xamarin/maccore@8bb7dc6c38 [docfixer] Add error checking to fix #xamarin/maccore@2479. (#2498)
* xamarin/maccore@93d0469437 [Xamarin.Hosting] Increase needed verbosity when logging loaded frameworks (#2497)

Diff: https://github.com/xamarin/maccore/compare/49c78df930c108297fcce4501432b451656190de..3e591cbcb15081d34a9512ca39d9df55c331bdbd

Co-authored-by: Alex Soto <alex@alexsoto.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants