Fix a bug #4
Closed
Fix a bug #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orms (sonic-net#6304) Mellanox already supports multiple destination IPs in IPinIP tunnel configuration, thus removing mellanox exception for IPinIP configuration. - How I did it Removed "dst_ip" field generation in mellanox platform condition. Sorted the "dst_ip" list, so that it is easier to test against sample configuration in unit tests. Aligned unit test sample. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
instruct azure pipeline to use node.js in the docker. https://docs.microsoft.com/en-us/azure/devops/pipelines/process/container-phases?view=azure-devops#bring-your-own-nodejs Signed-off-by: Guohan Lu <lguohan@gmail.com>
…et#6301) - No longer install Python 2 packages in host: - libpython2.7-dev - docker - ipaddress - netifaces - azure-storage - watchdog - futures - Install Python 3 versions of the following packages in host: - docker - azure-storage - watchdog - redis - swsssdk (install unconditionally)
- Convert system-health scripts to Python 3 - Build and install system-health as a Python 3 wheel - Also convert newlines from DOS to UNIX
use bash -t test flag to check if input device is tty or not Signed-off-by: Guohan Lu <lguohan@gmail.com>
…onic-net#6319) sonic-slave tag only allows all lower case. In case the user name is mixed case, we need to change user name to all lower case. Signed-off-by: Guohan Lu <lguohan@gmail.com>
…rk (sonic-net#6315) Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Depending on the performance characteristics of a given hardware platform, it's possible to exceed the default 120 second kernel timeout during I/O intensive operations like image installation. This can cause a kernel panic like so: kernel:[ 852.441781] Kernel panic - not syncing: hung_task: blocked tasks If this happens during image installation, it's possible for the install to become corrupted and leave the device in an unreachable state that requires a power cycle to resolve. This risk increases as image size continues to increase. So, we need to increase the timeout so that we don't encounter kernel panics on devices with lower disk throughput. Signed-off-by: Danny Allen <daall@microsoft.com>
- Why I did it Make EEPROM platform APIs Python3 compliant in Nokia platform. - How I did it Handle bytearray type returned by read_eeprom and read_eeprom_bytes methods. - How to verify it Boot Nokia ixs7215 and verify PMON docker running and show platform syseeprom Co-authored-by: Carl Keene <keene@nokia.com>
Why I did it To support FG_ECMP scenarios - How I did it Modified minigraph parser to parse ECMP fields in the case they are present in minigraph - How to verify it Loaded ensuing config_db file on a DUT to verify the fields are parsed and configure device correctly
…or hardware_reboot_cause (sonic-net#6325) What: Modify unit test to not call any platform dependent api in test_find_hardware_reboot_cause. - Why I did it MELLANOX build is failing for the recent PRs. The errors are due to platform library being invoked in a unit test for determine-reboot-cause script. Verified by running unit tests and a successful Mellanox build. Co-authored-by: Vaibhav Hemant Dixit <vadixit@microsoft.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
…sonic-net#6298) Enable the notify mode of rsyslogd imfile module used for supervisord logs in docker container
Including commits in sonic-swss-common repo: b423b9c Add support for hexists call (sonic-net#432) [Tony Titus] 0982996 Remove extension of tableNameSeparatorMap (sonic-net#430) [Qi Luo] d16cc76 [build]: add azure pipeline build badge (sonic-net#429) [lguohan] f2aaf55 Set up CI with Azure Pipelines (sonic-net#428) [lguohan]
…net#6333) Features: Spectrum-3 | Systems | Added GA-level support for SN4700 A0 system All | Shared headroom | Added GA-level support for Shared headroom between PGs Bugs fixes: All | Counters | Sent traffic in certain size is wrongly increase to a smaller size counter, because port extended counter has a counter for sent traffic per packet-size range All | Shared buffer | Configuring shared buffer on the fly may, on occasion, cause the chip to get stuck Spectrum-2 | Modules | On occasion, link down is experienced with INPHI COLORZ PAM4 100G optic cables on SN3700 systems
Accton util applies lsmod to check if drivers are installed. But lsmod may return error on startup and skip module installation. Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
fix a bug when there are multiple debian packages to be uninstalled Signed-off-by: Guohan Lu <lguohan@gmail.com>
in case conflicting packages have same name but different version, the install step needs to wait till package with the conflicting version is uninstalled Signed-off-by: Guohan Lu <lguohan@gmail.com>
no instalation of frr during the build process Signed-off-by: Guohan Lu <lguohan@gmail.com>
frr build requires libyang 1.0.184 which conflicts with libyang 1.0.73. Solution here is to compile frr and libyang 1.0.184 first, and then uninstall libyang 1.0.184 after frr build. Then, compile libyang 1.0.73 and all packages depend on it later. Signed-off-by: Guohan Lu <lguohan@gmail.com>
…ion (sonic-net#6309) * [sonic-py-common] add an API to get file path containing SONiC version so that the API can be mocked for unit tests.
…on (sonic-net#6339) the control file version is 4.2.1.5-7 sonic$ sudo dpkg -i target/debs/buster/libsaibcm-dev_4.2.1.5-8_amd64.deb (Reading database ... 175880 files and directories currently installed.) Preparing to unpack .../libsaibcm-dev_4.2.1.5-8_amd64.deb ... Unpacking libsaibcm-dev (4.2.1.5-7) over (4.2.1.5-7) ... Setting up libsaibcm-dev (4.2.1.5-7) ... lgh@491d842369cf:/sonic$ sudo dpkg -i target/debs/buster/libsaibcm_4.2.1.5-8_amd64.deb (Reading database ... 175880 files and directories currently installed.) Preparing to unpack .../libsaibcm_4.2.1.5-8_amd64.deb ... Unpacking libsaibcm (4.2.1.5-7) over (4.2.1.5-7) ... Setting up libsaibcm (4.2.1.5-7) ... Processing triggers for libc-bin (2.28-10) ... Signed-off-by: Guohan Lu <lguohan@gmail.com>
… image (sonic-net#6340) build frr dbg image force to install frr in the build process which breaks the current build and is uneccessary. Signed-off-by: Guohan Lu <lguohan@gmail.com>
* Add changes to allow migration of bfn syncd to buster * Update BFN packages for Debian 10 Signed-off-by: Denys Petryshyn <denysx.petryshyn@intel.com>
In the emulated armhf environment, the function readdir()returns NULL on a ext4 file system directory. When running the libyang1 test cases, it will require to load the plugins from the files (such as metadata.so), because the readdir() is failing, the plugins can’t be loaded in the emulated armhf environment, so it causes libyang1 test error. This error is a combination of the following reasons. • Emulation of a 32-bit target from a 64-bit host –> qemu from x86_64 to armhf • Glibc version > 2.27 – Debian buster is using glibc 2.28 - How I did it Enabled large file support by setting _FILE_OFFSET_BITS=64 for libyang1. Signed-off-by: Sabareesh Kumar Anandan <sanandan@marvell.com>
Fix syntax errors during xcvrd start with Python 3 daemons
…rse_dom_capability' (sonic-net#6695) **- Why I did it** PR sonic-net/sonic-platform-common#102 modified the name of the SFF-8436 (QSFP) method to align the method name between all drivers, renaming it from `parse_qsfp_dom_capability` to `parse_dom_capability`. Once the submodule was updated, the callers using the old nomenclature broke. This PR updates all callers to use the new naming convention. **- How I did it** Update the name of the function globally for all calls into the SFF-8436 driver. Note that the QSFP-DD driver still uses the old nomenclature and should be modified similarly. I will open a PR to handle this separately.
**- Why I did it** To support nightly build for master branch **- How to verify it** confirm from azure pipeline page.
Port_config update for hwsku 7050CX3-32S-C3 - add two 10G ports. This change is added to fix issue of "PortsOrch initialization failure" seen by previous removal of these 10G ports. Tested on the device with new minigraph, and the PortsOrch initialization failure is not seen.
Signed-off-by: Guohan Lu <lguohan@gmail.com>
* Remove makefile and As part of sonic-net#6046 we have moved to python3 of dbsyncd. Cleanup the python2 makefile and dependency. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Revert "Remove makefile and dependency for python2 of dbsyncd." This reverts commit ceaa4f8. * Fix Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
…6696) prerm is needed for platform modules package to be properly removed. Added prerm to remove installed in postinst wheel packages. Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
official build only use scheduled build Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
check the uid before modify local user account.
when run sudo, the process the invoke nss_tacplus library
does not have priviledge to modify the user profile, and
will generate below error messages:
user_rw@sonic:~$ sudo bash
usermod: Permission denied.
usermod: cannot lock /etc/passwd; try again later.
usermod: Permission denied.
usermod: cannot lock /etc/passwd; try again later.
Signed-off-by: Guohan Lu <lguohan@gmail.com>
sonic-utilities will become dependent upon sonic-platform-common as of sonic-net/sonic-utilities#1386.
…ic-net#6321) Accton util applies lsmod to check if drivers are installed. But lsmod may return error on startup and skip module installation. Signed-off-by: roy_lee <roy_lee@edge-core.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
- [ci]: add default values to build template - [ci]: add marvel armhf official build Signed-off-by: Guohan Lu <lguohan@gmail.com>
* [device] add platform.json hwsku.json for Montara * [device] add autonge, fec fields to hwsku
**- Why I did it** After migrating to python3, the operator '/' always get a float result, but it gets integer result in python2. Need fix this in thermal_conditions. **- How I did it** 1. cast float value to int 2. change the unit test case to cover this situation **- How to verify it** Manually test and regression test
proper bool comparision Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
…ic-net#6713) Fix sonic-net#6711 the requirement was introduced in commit 75104bb to support sflow in stretch build. in buster build, the requirement is met, no need to pin down the version. Signed-off-by: Guohan Lu <lguohan@gmail.com>
restructure repo clean up to make it robust Signed-off-by: Guohan Lu <lguohan@gmail.com>
… IN_PORTS for TD3 (sonic-net#6718) ACL entry set attribute updates all the entries in the table. The correct behavior is to set the attribute on single entry. - How I did it Current SDK code, while setting the new attribute, is going through all the entries and updating it. Added a logic to check for requested entry and only allow for that ACL entry. A case has filed with BRCM. Once an official fix is provided by BRCM, we will then remove this in house fix and apply the official fix.
) - Why I did it To move ‘sonic-host-service’ which is currently built as a separate package to ‘sonic-host-services' package. - How I did it - Moved 'sonic-host-server' to 'src/sonic-host-services' and included it as part of the python3 wheel. - Other files were moved to 'src/sonic-host-services-data' and included as part of the deb package. - Changed build option ‘INCLUDE_HOST_SERVICE’ to ‘ENABLE_HOST_SERVICE_ON_START’ for enabling sonic-hostservice at boot-up by default.
xumia
pushed a commit
that referenced
this pull request
Nov 14, 2021
Ported Iptables patch for supporting fullcone NAT option to 5.10 kernel. Signed-off-by: Kiran Kella <kiran.kella@broadcom.com>
xumia
pushed a commit
that referenced
this pull request
Nov 25, 2021
Submodule update for sonic-linkmgrd Incorporates: c11a576 (2021-11-22 09:38:46) [ci]: show code coverage in azure pipeline (#4) 4ceb01d (2021-11-18 20:24:20) Fix MUX toggling issue (#1) d640527 (2021-11-12 22:31:44) [ci]: fix artifact download b9f247d (2021-11-12 22:31:44) [ci]: use native arm64/armhf build 3059122 (2021-09-27 11:32:23) [linkgrd] Add Missing Apache License Header
xumia
pushed a commit
that referenced
this pull request
Nov 26, 2021
Submodule update for sonic-linkmgrd Incorporates: c11a576 (2021-11-22 09:38:46) [ci]: show code coverage in azure pipeline (#4) 4ceb01d (2021-11-18 20:24:20) Fix MUX toggling issue (#1) d640527 (2021-11-12 22:31:44) [ci]: fix artifact download b9f247d (2021-11-12 22:31:44) [ci]: use native arm64/armhf build 3059122 (2021-09-27 11:32:23) [linkgrd] Add Missing Apache License Header signed-off-by: Jing Zhang zhangjing@microsoft.com
xumia
pushed a commit
that referenced
this pull request
Oct 27, 2022
#### Why I did it Update sonic-host-services submodule to include below commits: ``` bc8698d Merge pull request #21 from abdosi/feature 557a110 Fix the issue where if dest port is not specified in ACL rule than for multi-asic where we create NAT rule to forward traffic from Namespace to host fail with exception. 6e45acc (master) Merge pull request #14 from abdosi/feature 4d6cad7 Merge remote-tracking branch 'upstream/master' into feature bceb13e Install libyang to azure pipeline (#20) 82299f5 Merge pull request #13 from SuvarnaMeenakshi/cacl_fabricns 15d3bf4 Merge branch 'master' into cacl_fabricns de54082 Merge pull request #16 from ZhaohuiS/feature/caclmgrd_external_client_warning_log b4b368d Add warning log if destination port is not defined d4bb96d Merge branch 'master' into cacl_fabricns 35c76cb Add unit-test and fix typo. 17d44c2 Made Changes to be Python 3.7 compatible 978afb5 Aligning Code 1fbf8fb Merge remote-tracking branch 'upstream/master' into feature 7b8c7d1 Added UT for the changes 91c4c42 Merge pull request #9 from ZhaohuiS/feature/caclmgrd_external_client 7c0b56a Add 4 test cases for external_client_acl, including single port and port range for ipv4 and ipv6 b71e507 Merge remote-tracking branch 'origin/master' into HEAD d992dc0 Merge branch 'master' into feature/caclmgrd_external_client bd7b172 DST_PORT is configuralbe in json config file for EXTERNAL_CLIENT_ACL f9af7ae [CLI] Move hostname, mgmt interface/vrf config to hostcfgd (#2) 70ce6a3 Merge pull request #10 from sujinmkang/cold_reset 29be8d2 Added Support to render Feature Table using Device running metadata. Also added support to render 'has_asic_scope' field of Feature Table. 3437e35 [caclmgrd][chassis]: Add ip tables rules to accept internal docker traffic from fabric asic namespaces. 8720561 Fix and add hardware reboot cause determination tests 0dcc7fe remove the empty bracket if no hardware reboot cause minor e47d831 fix the wrong expected result comparision ef86b53 Fix startswith Attribute error 8a630bb fix mock patch 8543ddf update the reboot cause logic and update the unit test 53ad7cd fix the mock patch function 7c8003d fix the reboot-cause regix for test 1ba611f fix typo 25379d3 Add unit test case a56133b Add hardware reboot cause as actual reboot cause for soft reboot failed c7d3833 Support Restapi/gnmi control plane acls f6ea036 caclmgrd: Don't block traffic to mgmt by default a712fc4 Update test cases adc058b caclmgrd: Don't block traffic to mgmt by default 06ff918 Merge pull request #7 from bluecmd/patch-1 e3e23bc ci: Rename sonic-buildimage repository e83a858 Merge pull request #4 from kamelnetworks/acl-ip2me-test f5a2e50 [caclmgrd]: Tests for IP2ME rules generation ```
xumia
pushed a commit
that referenced
this pull request
Jul 7, 2023
…est HEAD automatically (sonic-net#15725) #### Why I did it src/sonic-dash-api/sonic-dash-api ``` * 3f728d1 - (HEAD -> master, origin/master, origin/HEAD) Update vnet_direct in route.proto (#4) (11 days ago) [Ze Gan] ``` #### How I did it #### How to verify it #### Description for the changelog
xumia
pushed a commit
that referenced
this pull request
Mar 6, 2024
…ing fastboot Fix fastreboot path to shutdown SLB neighbors during fastboot This issue was found when the new build on internal branch started failing. Build failure log: ``` Applying patch ../sonic-utilities.patch/0002-Stopping-all-BGP-SLB-neighbors-if-they-re-presented-.patch patching file scripts/fast-reboot Hunk #1 succeeded at 43 with fuzz 1 (offset 7 lines). Hunk #2 FAILED at 123. Hunk #3 succeeded at 502 with fuzz 1 (offset 81 lines). Hunk #4 succeeded at 582 (offset 95 lines). 1 out of 4 hunks FAILED -- rejects in file scripts/fast-reboot ``` Repro'd this locally: ``` vadixit@DevVM-20:~/workspace/Networking-acs-buildimage/src/sonic-utilities$ quilt push -a Applying patch patches/0002-Stopping-all-BGP-SLB-neighbors-if-they-re-presented-.patch patching file scripts/fast-reboot Hunk #1 succeeded at 42 with fuzz 1 (offset 6 lines). Hunk #2 FAILED at 123. Hunk #3 succeeded at 489 with fuzz 1 (offset 68 lines). Hunk #4 succeeded at 569 (offset 82 lines). 1 out of 4 hunks FAILED -- rejects in file scripts/fast-reboot Patch patches/0002-Stopping-all-BGP-SLB-neighbors-if-they-re-presented-.patch does not apply (enforce with -f) ``` Issue fixed with this change: ``` vadixit@DevVM-20:~/workspace/Networking-acs-buildimage/src/sonic-utilities$ quilt push -a Applying patch patches/0001-fast-reboot-patch-Handle-SLB-neighbors-shutdown-duri.patch patching file scripts/fast-reboot Now at patch patches/0001-fast-reboot-patch-Handle-SLB-neighbors-shutdown-duri.patch ``` Additionally, changed the series file and renamed the 0002 patch as 0001 patch as this is the only patch on this branch right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test3