-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: +TOKEN modifier for side-effect functions #15
base: master
Are you sure you want to change the base?
Conversation
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
Just didi it. Is it understood what I'm trying to achieve? |
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
===========================================
+ Coverage 77.87% 91.01% +13.14%
===========================================
Files 5 6 +1
Lines 348 501 +153
===========================================
+ Hits 271 456 +185
+ Misses 77 45 -32
Continue to review full report at Codecov.
|
c307f28
to
5101e8f
Compare
5101e8f
to
df4dc47
Compare
were writing in text-mode in PY3. and failing as encoding error.
Tokens work as usual while solving the DAG but they are never assigned any values to/from the operation's functions. + TC included. + Docs updated.\+ Added `modifiers` superclass to facilitate identification code. + refactored FunctionalOperation._compute().
+ _norm_kwargs: + use isinstance() instead of type-equality checks, to support new modier classes; + avoid excessive dict searches with local vars.
not really needed, better be explicit which modifier is searched.
df4dc47
to
47c6c1d
Compare
receiving partial inputs, needed for other operations.
+ The x2 TCs added just before are now passing.
NOTE dict are not deterministic in <PY3.6. So this commit would not improve determinism in those pythons. + build: add `boltons` dependency for ndexedSet. + doc: mark all set usage if affect determinism. + e.g. see reproducibility problem in yahoo#14.
the later described in yahoo#21.
not after compose(). + All TCs pass ok. + NOTE this is not yet what is described in yahoo#21.
... based on Law of Demeter simplify kwargs, defined in one place. + enh: plotters "suggest" kwargs, possinly to override them (no duplcate arg when attempted).
+ FIX: apply thickness as in legend also for operators. + enh: don't cluster if no nodes pruned. + enh: netop includes its name a graph-title. + color palette: wheat filled nodes. + reuse common func.
... bugged in the opening commit d403783 of this PR, and discovered 68(!) commits later, and all that time had to live with x4 broken TCs with asked-outputs.
+ ENH: strongly refatctored TC to detect nulls & dupes.
+ Partial fix deterministic results (yahoo#22-2.4.3i).
+ test: some refacts on vars & for the uploaded images. + MARK SPURIOUS FAILS in < PY3.6 due to unordered dicts eg https://travis-ci.org/ankostis/graphkit/jobs/594813119
to support _repr_svg(), and it works without any flag.
+ graphop label renames, + DOT shortening.
+ FIX: `graph` is a DOT keyword, eg pydot/pydot#111 + Replaced `graph` --> `graphop`, inline with future refactoring. + Refactored example code. + New "Plotting" section under Quickstart. + Copy README instructions to main docs. + Abandoned `example_graph.svg`, replaced with `intro.svg`. + Recommend `.png` --> `.svg`, to save storage space. - discovered BUG in MERGE saumple code (empty!).
... to adopt pytest args + mark wheel a universal.
got values from v1.2.4 - ALL MERGE TCs FAIL!
many commits ago. Never got it bc TC were not checking merges!
needed to give the sidefeect as input.
Inputs & outputs in
needs
&provides
kwargs designated astoken
work as usual while solving the DAG but they are never assigned any values to/from the operation's functions:I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.