-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: +TOKEN modifier for side-effect functions #15
base: master
Are you sure you want to change the base?
Commits on Sep 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 617e577 - Browse repository at this point
Copy the full SHA 617e577View commit details
Commits on Sep 29, 2019
-
FIX(yahoo#13): BUG in plot-diagram writtin from PY2 era,
were writing in text-mode in PY3. and failing as encoding error.
Configuration menu - View commit details
-
Copy full SHA for f58d148 - Browse repository at this point
Copy the full SHA f58d148View commit details -
Configuration menu - View commit details
-
Copy full SHA for c75a2c0 - Browse repository at this point
Copy the full SHA c75a2c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a005bd6 - Browse repository at this point
Copy the full SHA a005bd6View commit details
Commits on Sep 30, 2019
-
FEAT: +TOKEN modifier for side-effect functions
Tokens work as usual while solving the DAG but they are never assigned any values to/from the operation's functions. + TC included. + Docs updated.\+ Added `modifiers` superclass to facilitate identification code. + refactored FunctionalOperation._compute().
Configuration menu - View commit details
-
Copy full SHA for 506be80 - Browse repository at this point
Copy the full SHA 506be80View commit details -
fix(func): 1-item outs broke with token modifiers...
+ _norm_kwargs: + use isinstance() instead of type-equality checks, to support new modier classes; + avoid excessive dict searches with local vars.
Configuration menu - View commit details
-
Copy full SHA for 4e6d543 - Browse repository at this point
Copy the full SHA 4e6d543View commit details -
refact(token): undo adding of new
modifier
class...not really needed, better be explicit which modifier is searched.
Configuration menu - View commit details
-
Copy full SHA for 62cf0a0 - Browse repository at this point
Copy the full SHA 62cf0a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47c6c1d - Browse repository at this point
Copy the full SHA 47c6c1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94b7291 - Browse repository at this point
Copy the full SHA 94b7291View commit details
Commits on Oct 1, 2019
-
enh(test): + x2 TC breaking UNSATISFIED operations...
receiving partial inputs, needed for other operations.
Configuration menu - View commit details
-
Copy full SHA for 52c0d77 - Browse repository at this point
Copy the full SHA 52c0d77View commit details -
ENH(net,yahoo#18): ignore UN-SATISFIABLE operations with partial inputs
+ The x2 TCs added just before are now passing.
Configuration menu - View commit details
-
Copy full SHA for bc4c221 - Browse repository at this point
Copy the full SHA bc4c221View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8daa07 - Browse repository at this point
Copy the full SHA b8daa07View commit details -
ENH(core): ORDERED SETs for DETERMINISTIC results
NOTE dict are not deterministic in <PY3.6. So this commit would not improve determinism in those pythons. + build: add `boltons` dependency for ndexedSet. + doc: mark all set usage if affect determinism. + e.g. see reproducibility problem in yahoo#14.
Configuration menu - View commit details
-
Copy full SHA for 12bdfe4 - Browse repository at this point
Copy the full SHA 12bdfe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8377ca - Browse repository at this point
Copy the full SHA b8377caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 489b32c - Browse repository at this point
Copy the full SHA 489b32cView commit details
Commits on Oct 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b102d44 - Browse repository at this point
Copy the full SHA b102d44View commit details -
Configuration menu - View commit details
-
Copy full SHA for de02885 - Browse repository at this point
Copy the full SHA de02885View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1454fd - Browse repository at this point
Copy the full SHA e1454fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3736738 - Browse repository at this point
Copy the full SHA 3736738View commit details -
DOC(net): explain DAG solution & compilation...
the later described in yahoo#21.
Configuration menu - View commit details
-
Copy full SHA for c273068 - Browse repository at this point
Copy the full SHA c273068View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16d42f1 - Browse repository at this point
Copy the full SHA 16d42f1View commit details -
refact(dag): call compile() before compute.compute...
not after compose(). + All TCs pass ok. + NOTE this is not yet what is described in yahoo#21.
Configuration menu - View commit details
-
Copy full SHA for b92f103 - Browse repository at this point
Copy the full SHA b92f103View commit details
Commits on Oct 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6d1884e - Browse repository at this point
Copy the full SHA 6d1884eView commit details -
ENH(net): move compile() after SOLVE DAG ...
to pass +TC checking DeleteInst vary when inputs change. - x4 TCs still failing, and need revamp of dag-solution.
Configuration menu - View commit details
-
Copy full SHA for 619cae7 - Browse repository at this point
Copy the full SHA 619cae7View commit details -
REFACT(NET) COMPILE+COMPUTE...
+ Read the next doc-only commit to understand changes. + Renamed: + net.steps --> net.execution_plan. + (old)compile() --> _build_execution_plan() + _find_necessary_steps() --> (new)compile() + _solve_dag() compile() became the master function invoking _solve_dag & _build-execution_plan(), and do the caching. + refact(compute()): extract common tasks from sequential/parallel. + refact show_layers() to allow full-print, geting also string (not just printing), and using custom classes for representation. + Raise AssertionError when invalid class in plan. it's a logic error, not a language type-error.
Configuration menu - View commit details
-
Copy full SHA for eff351d - Browse repository at this point
Copy the full SHA eff351dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d959485 - Browse repository at this point
Copy the full SHA d959485View commit details -
FIX(net): new Ops invalidate execution-plan cache...
Probaly unreported bug in v1.2.4 for '_neccessary_steps_cache`.
Configuration menu - View commit details
-
Copy full SHA for 17eb2fd - Browse repository at this point
Copy the full SHA 17eb2fdView commit details -
+ Pruning behaves correctly also when outputs given; this happens by breaking incoming provide-links to any given intermedediate inputs. + Unsatisfied detection now includes those without outputs due to broken links (above). + Remove some uneeded "glue" from unsatisfied-detection code, leftover from previous compile() refactoring. + Renamed satisfiable --> satisfied. + Improved unknown output requested raise-message. + x3 TCs PASS, x1 in yahoo#24 and the first x2 in yahoo#25. - 1x TCs in yahoo#25 still FAIL, and need "Pinning" of given-inputs (the operation MUST and MUST NOT run in these cases).
Configuration menu - View commit details
-
Copy full SHA for 0830b7c - Browse repository at this point
Copy the full SHA 0830b7cView commit details -
enh(build): replace numpy with pytest...
numpy was used just for its assert_raise
Configuration menu - View commit details
-
Copy full SHA for 32409f6 - Browse repository at this point
Copy the full SHA 32409f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f606ed1 - Browse repository at this point
Copy the full SHA f606ed1View commit details
Commits on Oct 4, 2019
-
WIP/FIX(prune,yahoo#26): PIN intermediate inputs if operation before …
…must run - WIP: PARALLEL execution not adding PINS! + Insert "PinInstructions" in the execution-plan to avoid overwritting. + Add `_overwrite_collector` in `compose()` to collect re-calculated values. + FIX the last TC in yahoo#25.
Configuration menu - View commit details
-
Copy full SHA for 0dc1293 - Browse repository at this point
Copy the full SHA 0dc1293View commit details -
REFACT(net): part 3 of new dag-solver & pin refactoring
- STILL buggy PIN on PARALLEL, 2 DISABLED TCs FAIL: - test_pruning_with_given_intermediate_and_asked_out() - test_unsatisfied_operations_same_out() + move check if value in asked outputs before cache-evicting it in build-execution-plan time - compute methods don't need outputs anymore. + test: speed up parallel/multihtread TCs by reducing delays & repetitions. + refact: network rightfully adopted stray functions for parallel processing - they all worke on the net.graph, + upd: networkx api by indexing on `dag.nodes` views. + enh: add log message when deleting in parallel (in par with sequential code). + refact: var-renames, if-then-else simplifications, pythonisms. + doc: A lot!
Configuration menu - View commit details
-
Copy full SHA for 06f6554 - Browse repository at this point
Copy the full SHA 06f6554View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cc733e - Browse repository at this point
Copy the full SHA 1cc733eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd1370b - Browse repository at this point
Copy the full SHA cd1370bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f676662 - Browse repository at this point
Copy the full SHA f676662View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65d1816 - Browse repository at this point
Copy the full SHA 65d1816View commit details -
WIP/FIX(PIN): PARALLEL DELs decide on PRUNED-dag (not full)...
- WIP: x4 TCs FAIL and still not discovered th bug :-( + BUT ALL+AUGMENTED PARALLEL TCs pass (yahoo#26 were failing some) + refact: net stores also `pruned_dag` (not only `steps`). + refact: _solve_dag() --> _prune_dag(). + doc: +a lot. + TODO: store pruned_dag in own ExePlan class.
Configuration menu - View commit details
-
Copy full SHA for d403783 - Browse repository at this point
Copy the full SHA d403783View commit details -
- SAME x4 TCs FAIL like parent. + refact: revive net.steps --> net.last_plan + BREAK: inverse the order of outputs/inputs args in net.compute() + refact: use iset() to merge.
Configuration menu - View commit details
-
Copy full SHA for 64e0028 - Browse repository at this point
Copy the full SHA 64e0028View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e55b30 - Browse repository at this point
Copy the full SHA 4e55b30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47b50f6 - Browse repository at this point
Copy the full SHA 47b50f6View commit details
Commits on Oct 5, 2019
-
refact(plot): extract plot function out of Network class...
to use it also on stary DAGs. Keep delegation.
Configuration menu - View commit details
-
Copy full SHA for b1d02a1 - Browse repository at this point
Copy the full SHA b1d02a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c11af2a - Browse repository at this point
Copy the full SHA c11af2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 344490b - Browse repository at this point
Copy the full SHA 344490bView commit details -
ENH(plot): +inputs, +outputs, +solution modify plotting
(see yahoo#13 for an example):
Configuration menu - View commit details
-
Copy full SHA for 23ef81e - Browse repository at this point
Copy the full SHA 23ef81eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e8601c - Browse repository at this point
Copy the full SHA 4e8601cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 834a8b0 - Browse repository at this point
Copy the full SHA 834a8b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2e28a4 - Browse repository at this point
Copy the full SHA c2e28a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e38c8ad - Browse repository at this point
Copy the full SHA e38c8adView commit details -
Configuration menu - View commit details
-
Copy full SHA for d855bf6 - Browse repository at this point
Copy the full SHA d855bf6View commit details -
test(plot): enhance plot test to try all yahoo#13 features;
+ test all chained plot() methods from netop.
Configuration menu - View commit details
-
Copy full SHA for ca5d243 - Browse repository at this point
Copy the full SHA ca5d243View commit details -
test(optional): +x1 TC to check selective optionals with same out...
+ enh TC with parallel. + Scavenged from yahoo#20.
Configuration menu - View commit details
-
Copy full SHA for f25f189 - Browse repository at this point
Copy the full SHA f25f189View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2de9ef - Browse repository at this point
Copy the full SHA a2de9efView commit details -
FIX(PLOT.TC): TC was always testing PNG, ...
+ retorfitted to try all available formats. + list of forbidden formats based on my failres
Configuration menu - View commit details
-
Copy full SHA for dc5a21a - Browse repository at this point
Copy the full SHA dc5a21aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 782d9b9 - Browse repository at this point
Copy the full SHA 782d9b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d389c3 - Browse repository at this point
Copy the full SHA 7d389c3View commit details -
ENH(plot): return SVG rendered in JUPYTER, ...
+ doc: rename in sample code: netop --> pipeline. + enh(build): add `ipython` in test dependencies. + include it in the plot TC.
Configuration menu - View commit details
-
Copy full SHA for 3fe0b40 - Browse repository at this point
Copy the full SHA 3fe0b40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1471551 - Browse repository at this point
Copy the full SHA 1471551View commit details -
Configuration menu - View commit details
-
Copy full SHA for af7ae0f - Browse repository at this point
Copy the full SHA af7ae0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b440196 - Browse repository at this point
Copy the full SHA b440196View commit details -
Configuration menu - View commit details
-
Copy full SHA for bde9b64 - Browse repository at this point
Copy the full SHA bde9b64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e361e6 - Browse repository at this point
Copy the full SHA 8e361e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b08a363 - Browse repository at this point
Copy the full SHA b08a363View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a87959 - Browse repository at this point
Copy the full SHA 3a87959View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17f18c2 - Browse repository at this point
Copy the full SHA 17f18c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d250d3 - Browse repository at this point
Copy the full SHA 4d250d3View commit details
Commits on Oct 6, 2019
-
ENH(plot,net): +plot() on ExecPlan; +PlotMixin ...
to avoid copying plot() doc+sig around
Configuration menu - View commit details
-
Copy full SHA for 18191e4 - Browse repository at this point
Copy the full SHA 18191e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7341529 - Browse repository at this point
Copy the full SHA 7341529View commit details -
Configuration menu - View commit details
-
Copy full SHA for 231ada5 - Browse repository at this point
Copy the full SHA 231ada5View commit details -
FIX(plot): distinguish Del/Pin cmds; +choice utils
- still x4 TCs fail...
Configuration menu - View commit details
-
Copy full SHA for 80f110a - Browse repository at this point
Copy the full SHA 80f110aView commit details -
refact(plot): inline imports, not to cycle with base...
to bring back PlotMixin to change together stuff.
Configuration menu - View commit details
-
Copy full SHA for 32eaa80 - Browse repository at this point
Copy the full SHA 32eaa80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b70cfb - Browse repository at this point
Copy the full SHA 4b70cfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4fa5e0 - Browse repository at this point
Copy the full SHA b4fa5e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6f2155 - Browse repository at this point
Copy the full SHA c6f2155View commit details -
ENH(plan,plot): executed operations drawn as filled
+ enh(plan): also sequential execution collects accounts executed. + refact(plan): executed_nodes-->executed.
Configuration menu - View commit details
-
Copy full SHA for ec69090 - Browse repository at this point
Copy the full SHA ec69090View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24a3d1e - Browse repository at this point
Copy the full SHA 24a3d1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77fc887 - Browse repository at this point
Copy the full SHA 77fc887View commit details -
Configuration menu - View commit details
-
Copy full SHA for da087df - Browse repository at this point
Copy the full SHA da087dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac73bbb - Browse repository at this point
Copy the full SHA ac73bbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2829a3 - Browse repository at this point
Copy the full SHA c2829a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c61947b - Browse repository at this point
Copy the full SHA c61947bView commit details -
REFACT(PLOT): Plotter builds dot & renders...
... based on Law of Demeter simplify kwargs, defined in one place. + enh: plotters "suggest" kwargs, possinly to override them (no duplcate arg when attempted).
Configuration menu - View commit details
-
Copy full SHA for 434d4e2 - Browse repository at this point
Copy the full SHA 434d4e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for dabc787 - Browse repository at this point
Copy the full SHA dabc787View commit details
Commits on Oct 7, 2019
-
FIX(plot): VISUAL fixes & COLOR-palettes:
+ FIX: apply thickness as in legend also for operators. + enh: don't cluster if no nodes pruned. + enh: netop includes its name a graph-title. + color palette: wheat filled nodes. + reuse common func.
Configuration menu - View commit details
-
Copy full SHA for c5b9167 - Browse repository at this point
Copy the full SHA c5b9167View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d443ce - Browse repository at this point
Copy the full SHA 1d443ceView commit details -
FIX(NET): were FORGETTING PRUNED ASKED-OUTPUTs...
... bugged in the opening commit d403783 of this PR, and discovered 68(!) commits later, and all that time had to live with x4 broken TCs with asked-outputs.
Configuration menu - View commit details
-
Copy full SHA for 77bec49 - Browse repository at this point
Copy the full SHA 77bec49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89e4edb - Browse repository at this point
Copy the full SHA 89e4edbView commit details -
FIX(plot.TC): formats-TC were testing dot-file, not rendered...
+ ENH: strongly refatctored TC to detect nulls & dupes.
Configuration menu - View commit details
-
Copy full SHA for cef7526 - Browse repository at this point
Copy the full SHA cef7526View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9b2415 - Browse repository at this point
Copy the full SHA f9b2415View commit details -
FIX(<PY3.5): ORDERED DiGRAPH for old Python to fix TCs
+ Partial fix deterministic results (yahoo#22-2.4.3i).
Configuration menu - View commit details
-
Copy full SHA for fce0515 - Browse repository at this point
Copy the full SHA fce0515View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8ba34f - Browse repository at this point
Copy the full SHA d8ba34fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8fec22 - Browse repository at this point
Copy the full SHA e8fec22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a87d61 - Browse repository at this point
Copy the full SHA 7a87d61View commit details
Commits on Oct 8, 2019
-
DOC(PLOT): +sample GRAPH & LEGEND into README...
+ test: some refacts on vars & for the uploaded images. + MARK SPURIOUS FAILS in < PY3.6 due to unordered dicts eg https://travis-ci.org/ankostis/graphkit/jobs/594813119
Configuration menu - View commit details
-
Copy full SHA for 53c6ce5 - Browse repository at this point
Copy the full SHA 53c6ce5View commit details -
DROP(plot) jupyter kw, simpler to monkeypath Dot class...
to support _repr_svg(), and it works without any flag.
Configuration menu - View commit details
-
Copy full SHA for ff754a1 - Browse repository at this point
Copy the full SHA ff754a1View commit details -
FIX(plot): LEGEND mistakes, SVGize, egg graphs, ...
+ graphop label renames, + DOT shortening.
Configuration menu - View commit details
-
Copy full SHA for f787f26 - Browse repository at this point
Copy the full SHA f787f26View commit details -
FIX(DOC): don't use
graph
in sample code, crash DOT, +more ...+ FIX: `graph` is a DOT keyword, eg pydot/pydot#111 + Replaced `graph` --> `graphop`, inline with future refactoring. + Refactored example code. + New "Plotting" section under Quickstart. + Copy README instructions to main docs. + Abandoned `example_graph.svg`, replaced with `intro.svg`. + Recommend `.png` --> `.svg`, to save storage space. - discovered BUG in MERGE saumple code (empty!).
Configuration menu - View commit details
-
Copy full SHA for 5cf7189 - Browse repository at this point
Copy the full SHA 5cf7189View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f637fe - Browse repository at this point
Copy the full SHA 7f637feView commit details -
chore(TCs): mark SLOW tests, when in hurry, +
setup.cfg
... to adopt pytest args + mark wheel a universal.
Configuration menu - View commit details
-
Copy full SHA for ae01163 - Browse repository at this point
Copy the full SHA ae01163View commit details -
FIX(TCs): MERGE TCs were not ASSERTING...
got values from v1.2.4 - ALL MERGE TCs FAIL!
Configuration menu - View commit details
-
Copy full SHA for 64838a5 - Browse repository at this point
Copy the full SHA 64838a5View commit details -
FIX(MERGE): broken by NEW_DAG_SOLVER (yahoo#26 ...
many commits ago. Never got it bc TC were not checking merges!
Configuration menu - View commit details
-
Copy full SHA for 8c41066 - Browse repository at this point
Copy the full SHA 8c41066View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b452f7 - Browse repository at this point
Copy the full SHA 6b452f7View commit details -
FIX(sideffect.TX): old TC was not with unsatisfied in mind,
needed to give the sidefeect as input.
Configuration menu - View commit details
-
Copy full SHA for 3e06148 - Browse repository at this point
Copy the full SHA 3e06148View commit details