filters/auth: cache yaml config #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
minor
AlexanderYastrebov
force-pushed
the
filters/auth/yamlconfig
branch
5 times, most recently
from
c6f326f to
fab869c
Compare
|
👍 |
filters/auth/jwt_metrics.go
Outdated
| @@ -27,34 +28,31 @@ type ( | |||
| ) | |||
|
|
|||
| func NewJwtMetrics() filters.Spec { | |||
| return &jwtMetricsSpec{} | |||
| return &jwtMetricsSpec{ | |||
| yamlConfig: newYamlConfig[jwtMetricsFilter](64), | |||
There was a problem hiding this comment.
64 is an arbitrary cache size here. In case number of distinct yaml configurations exceeds it the caching still has value because it will hold recently parsed configurations.
There was a problem hiding this comment.
Decided that currently it does not make sense to make it configurable, we can do it later if needed.
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
filters/auth/yamlconfig
branch
2 times, most recently
from
42b81bd to
c6228d1
Compare
Cache parsed yaml config for `jwtMetrics` and `oauthTokeninfoValidate`
filters to avoid parsing the same configuration over and over
when these filters are appended as default filters to all routes.
```
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
JwtMetrics_CreateFilter-8 30777.00n ± 6% 18.45n ± 11% -99.94% (p=0.000 n=10)
│ HEAD~1 │ HEAD │
│ B/op │ B/op vs base │
JwtMetrics_CreateFilter-8 24.33Ki ± 0% 0.00Ki ± 0% -100.00% (p=0.000 n=10)
│ HEAD~1 │ HEAD │
│ allocs/op │ allocs/op vs base │
JwtMetrics_CreateFilter-8 180.0 ± 0% 0.0 ± 0% -100.00% (p=0.000 n=10)
```
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
filters/auth/yamlconfig
branch
from
c6228d1 to
1ed2e45
Compare
| // yamlConfigParser parses and caches yaml configurations of type T. | ||
| // Use [newYamlConfigParser] to create instances and ensure that *T implements [yamlConfig]. | ||
| type yamlConfigParser[T any] struct { | ||
| initialize func(*T) error |
There was a problem hiding this comment.
why do we need to enforce this?
There was a problem hiding this comment.
The idea is to ensure that user of yamlConfigParser is aware that config values must be immutable.
|
👍 |
1 similar comment
|
👍 |
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 25, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 26, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 30, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 canary was updated #8214 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
Pushpalanka
pushed a commit
that referenced
this pull request
Oct 11, 2024
* filters/auth: benchmark jwtMetrics filter creation
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
* filters/auth: cache yaml config
Cache parsed yaml config for `jwtMetrics` and `oauthTokeninfoValidate`
filters to avoid parsing the same configuration over and over
when these filters are appended as default filters to all routes.
```
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
JwtMetrics_CreateFilter-8 30777.00n ± 6% 18.45n ± 11% -99.94% (p=0.000 n=10)
│ HEAD~1 │ HEAD │
│ B/op │ B/op vs base │
JwtMetrics_CreateFilter-8 24.33Ki ± 0% 0.00Ki ± 0% -100.00% (p=0.000 n=10)
│ HEAD~1 │ HEAD │
│ allocs/op │ allocs/op vs base │
JwtMetrics_CreateFilter-8 180.0 ± 0% 0.0 ± 0% -100.00% (p=0.000 n=10)
```
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
---------
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache parsed yaml config for
jwtMetricsandoauthTokeninfoValidatefilters to avoid parsing the same configuration over and over when these filters are appended as default filters to all routes.