Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filters/auth: fix assert usage in tokeninfocache tests #3240

Merged
merged 1 commit into from
Sep 19, 2024
Merged

filters/auth: fix assert usage in tokeninfocache tests #3240

merged 1 commit into from
Sep 19, 2024

Conversation

AlexanderYastrebov
Copy link
Member

Second argument of assert.Equal should be expected value.

@AlexanderYastrebov
filters/auth: fix assert usage in tokeninfocache tests
97107b4 
Second argument of assert.Equal should be expected value.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov added the minor no risk changes, for example new filters label Sep 19, 2024
@MustafaSaber
Copy link
Member

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit d161ac5 into master Sep 19, 2024
14 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the filters/auth/tokeninfocache-fix-assert branch September 19, 2024 20:25
@zalando-teapot-robot zalando-teapot-robot mentioned this pull request Sep 23, 2024
Merged
RomanZavodskikh pushed a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Sep 25, 2024
Update skipper version, step 1/2
81f39b8 
+ zalando/skipper#3227
+ zalando/skipper#3225
+ zalando/skipper#3234
+ zalando/skipper#3239
+ zalando/skipper#3240
+ zalando/skipper#3241
+ zalando/skipper#3242
+ zalando/skipper#3245
+ zalando/skipper#3246
+ zalando/skipper#3247
+ zalando/skipper#3249
+ zalando/skipper#3248

FYI zalando/skipper@v0.21.198...v0.21.208

Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
@RomanZavodskikh RomanZavodskikh mentioned this pull request Sep 25, 2024
Closed
RomanZavodskikh pushed a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Sep 26, 2024
Update skipper version, step 1/2
ed652be 
+ zalando/skipper#3227
+ zalando/skipper#3225
+ zalando/skipper#3234
+ zalando/skipper#3239
+ zalando/skipper#3240
+ zalando/skipper#3241
+ zalando/skipper#3242
+ zalando/skipper#3245
+ zalando/skipper#3246
+ zalando/skipper#3247
+ zalando/skipper#3249
+ zalando/skipper#3248

FYI zalando/skipper@v0.21.198...v0.21.208

Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
@RomanZavodskikh RomanZavodskikh mentioned this pull request Sep 26, 2024
Merged
RomanZavodskikh pushed a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Sep 30, 2024
skipper: update main fleet version to v0.21.208
5f37867 
+ zalando/skipper#3227
+ zalando/skipper#3225
+ zalando/skipper#3234
+ zalando/skipper#3239
+ zalando/skipper#3240
+ zalando/skipper#3241
+ zalando/skipper#3242
+ zalando/skipper#3245
+ zalando/skipper#3246
+ zalando/skipper#3247
+ zalando/skipper#3249
+ zalando/skipper#3248

FYI zalando/skipper@v0.21.198...v0.21.208

canary was updated #8214

Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
@RomanZavodskikh RomanZavodskikh mentioned this pull request Sep 30, 2024
Merged
Pushpalanka pushed a commit that referenced this pull request Oct 11, 2024
@AlexanderYastrebov @Pushpalanka
filters/auth: fix assert usage in tokeninfocache tests (#3240)
87b0789 
Second argument of assert.Equal should be expected value.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor no risk changes, for example new filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderYastrebov @MustafaSaber