predicates/host: add HostAny benchmark #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation uses linear probe that works well for small number
of hosts.
I thought about implementing it using map lookup but that is slower for
less than 50 hosts so I propose to only keep the benchmark that may be used
for future improvements.
Here is comparison with map-based implementation for reference:
```
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
HostAny/1-8 3.738n ± 3% 5.844n ± 3% +56.36% (p=0.000 n=10)
HostAny/2-8 7.728n ± 4% 9.274n ± 2% +20.02% (p=0.000 n=10)
HostAny/5-8 11.32n ± 4% 13.09n ± 4% +15.63% (p=0.000 n=10)
HostAny/10-8 22.35n ± 3% 11.86n ± 15% -46.94% (p=0.000 n=10)
HostAny/20-8 7.684n ± 2% 11.310n ± 9% +47.19% (p=0.000 n=10)
HostAny/50-8 66.75n ± 4% 12.10n ± 12% -81.87% (p=0.000 n=10)
HostAny/100-8 161.80n ± 1% 11.92n ± 13% -92.63% (p=0.000 n=10)
geomean 17.98n 10.46n -41.79%
│ HEAD~1 │ HEAD │
│ B/op │ B/op vs base │
HostAny/1-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/2-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/5-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/10-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/20-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/50-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/100-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
geomean ² +0.00% ²
¹ all samples are equal
² summaries must be >0 to compute geomean
│ HEAD~1 │ HEAD │
│ allocs/op │ allocs/op vs base │
HostAny/1-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/2-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/5-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/10-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/20-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/50-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/100-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
geomean ² +0.00% ²
¹ all samples are equal
² summaries must be >0 to compute geomean
```
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
|
👍 |
1 similar comment
|
👍 |
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 25, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 26, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 30, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 canary was updated #8214 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
Pushpalanka
pushed a commit
that referenced
this pull request
Oct 11, 2024
Current implementation uses linear probe that works well for small number
of hosts.
I thought about implementing it using map lookup but that is slower for
less than 50 hosts so I propose to only keep the benchmark that may be used
for future improvements.
Here is comparison with map-based implementation for reference:
```
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
HostAny/1-8 3.738n ± 3% 5.844n ± 3% +56.36% (p=0.000 n=10)
HostAny/2-8 7.728n ± 4% 9.274n ± 2% +20.02% (p=0.000 n=10)
HostAny/5-8 11.32n ± 4% 13.09n ± 4% +15.63% (p=0.000 n=10)
HostAny/10-8 22.35n ± 3% 11.86n ± 15% -46.94% (p=0.000 n=10)
HostAny/20-8 7.684n ± 2% 11.310n ± 9% +47.19% (p=0.000 n=10)
HostAny/50-8 66.75n ± 4% 12.10n ± 12% -81.87% (p=0.000 n=10)
HostAny/100-8 161.80n ± 1% 11.92n ± 13% -92.63% (p=0.000 n=10)
geomean 17.98n 10.46n -41.79%
│ HEAD~1 │ HEAD │
│ B/op │ B/op vs base │
HostAny/1-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/2-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/5-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/10-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/20-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/50-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/100-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
geomean ² +0.00% ²
¹ all samples are equal
² summaries must be >0 to compute geomean
│ HEAD~1 │ HEAD │
│ allocs/op │ allocs/op vs base │
HostAny/1-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/2-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/5-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/10-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/20-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/50-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
HostAny/100-8 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
geomean ² +0.00% ²
¹ all samples are equal
² summaries must be >0 to compute geomean
```
Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation uses linear probe that works well for small number of hosts.
I thought about implementing it using map lookup but that is slower for less than 50 hosts so I propose to only keep the benchmark that may be used for future improvements.
Here is comparison with map-based implementation for reference: