skipper: add server connection keepalive limits #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
the
major
AlexanderYastrebov
force-pushed
the
net/conn-keepalive
branch
from
bc17d16 to
0576c43
Compare
AlexanderYastrebov
changed the title
Clients may connect to a subset of Skipper fleet which leads to uneven request distribution and increased cpu usage. Autoscaling of Skipper fleet is not effective because clients stay connected to old instances while new instances are underutilized. This change adds ConnManager that tracks creation of new connections and closes connections when their age or number of requests served reaches configured limits. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
net/conn-keepalive
branch
from
0576c43 to
475b6e8
Compare
| @@ -243,6 +243,8 @@ type Config struct { | |||
| ReadHeaderTimeoutServer time.Duration `yaml:"read-header-timeout-server"` | |||
| WriteTimeoutServer time.Duration `yaml:"write-timeout-server"` | |||
| IdleTimeoutServer time.Duration `yaml:"idle-timeout-server"` | |||
| KeepaliveServer time.Duration `yaml:"keepalive-server"` | |||
There was a problem hiding this comment.
Named similar to existing keepalive-backend and *-server flags.
szuecs
reviewed
Sep 24, 2024
| } | ||
|
|
||
| func (cm *ConnManager) connState(_ net.Conn, state http.ConnState) { | ||
| cm.count(fmt.Sprintf("lb-conn-%s", state)) |
There was a problem hiding this comment.
👍 , I think this is to have the current metrics, right?
There was a problem hiding this comment.
Yes, moved it here
|
👍 |
1 similar comment
|
👍 |
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 25, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 26, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Sep 30, 2024
+ zalando/skipper#3227 + zalando/skipper#3225 + zalando/skipper#3234 + zalando/skipper#3239 + zalando/skipper#3240 + zalando/skipper#3241 + zalando/skipper#3242 + zalando/skipper#3245 + zalando/skipper#3246 + zalando/skipper#3247 + zalando/skipper#3249 + zalando/skipper#3248 FYI zalando/skipper@v0.21.198...v0.21.208 canary was updated #8214 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Oct 2, 2024
Add config items for server connection keepalive limits, set no limits by default. See zalando/skipper#3246 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Pushpalanka
pushed a commit
that referenced
this pull request
Oct 11, 2024
Clients may connect to a subset of Skipper fleet which leads to uneven request distribution and increased cpu usage. Autoscaling of Skipper fleet is not effective because clients stay connected to old instances while new instances are underutilized. This change adds ConnManager that tracks creation of new connections and closes connections when their age or number of requests served reaches configured limits. Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients may connect to a subset of Skipper fleet which leads to uneven request distribution and increased cpu usage.
Autoscaling of Skipper fleet is not effective because clients stay connected to old instances while new instances are underutilized.
This change adds ConnManager that tracks creation of new connections and closes connections when their age or number of requests served reaches configured limits.