merge with master #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* overwrite active styles for electron command buttons * overwrite active style for report export component * add active icon styling to InsightsCommandButton * use InsightsCommandButton for command bar buttons instead of ActionButton/CommandButton
* refactor: create nav link renderer * lint fix
…ore and toggle nav link expansion state (#2768) * Add callback for test header links * Add message for expanding test * Add assessment action for expanding test * Store currently expanded test when action is triggered * set isExpanded flag in test links * rename/change messages and actions to only expand a test * add message for collapsing test nav * collapse test nav in store * add separate action for collapsing nav
* create fluent side nav * clean up * add ut * add ut * lint fix * addressed comments * fix e2e test
This PR is a follow up of #2515, where the **Telemetry Viewer** was introduced. Adding a left nav for the debug tools page, which contains 2 navs: stores & telemetry viewer. Add actions, store and action creator and add them to the dependency tree from the debug tools init file. * add debug tools nav component * add debug tools nav actions * add debug tools nav action creator * add debug tools nave store * update telemetry viewer * add current view component * update debug tools view to rendere the nav and the current view, update tests, update debug tools init * address comments
…2777) - Updated Header to take in the nav menu as an optional prop - Updated InteractiveHeader to pass LeftNavHamburgerButton under a feature flag to Header - Updated LeftNavHamburgerButton to use the selectedPivot prop to determine which aria label to use (different labels for Assessment and FastPass)
… its default value to false and added a reference to the flag to the existing united-feature-flag.test file (#2781)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.