Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: change default settings tab depending on your role #13541

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Admin Page: change default settings tab depending on your role #13541

merged 1 commit into from
Sep 30, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 25, 2019

Changes proposed in this Pull Request:

Editors shouldn't see the Security tab when they load wp-admin/admin.php?page=jetpack#/settings, since they can't see anything on that tab. They should see the Writing tab instead, where they can use things like Post By Email.

Before

image

After

image

Testing instructions:

  • Go to Users > Add New, and add a new editor to your site.
  • Log to your site with that new user.
  • Go to Jetpack > Settings.
  • The Writing tab should load instead of the Security tab.

Proposed changelog entry for your changes:

  • Admin Page: change default settings tab depending on your role

@jeherve
Admin Page: change default settings tab depending on your role
c49b99e 
Editors shouldn't see the Security tab when they load wp-admin/admin.php?page=jetpack#/settings,
since they can't see anything on that tab. They should see the Writing tab instead, where they can use things like Post By Email.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Sep 25, 2019
@jeherve jeherve added this to the 7.9 milestone Sep 25, 2019
@jeherve jeherve requested a review from a team as a code owner September 25, 2019 13:00
@jeherve jeherve self-assigned this Sep 25, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against c49b99e

keoshi
keoshi approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great in my testing!

@kraftbj kraftbj merged commit 0ba89d5 into master Sep 30, 2019
@kraftbj kraftbj deleted the update/default-settings-tab branch September 30, 2019 20:31
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Sep 30, 2019
jeherve added a commit that referenced this pull request Oct 8, 2019
@jeherve
Admin Page: ensure user caps are available when picking active tab
ba67662 
Follow-up from #13541

We need to make sure this.props.userCanManageModules is available before we use it.
@jeherve jeherve mentioned this pull request Oct 8, 2019
Merged
jeherve added a commit that referenced this pull request Oct 11, 2019
@jeherve
Admin Page: ensure user caps are available when picking active… (#13689)
70ba68d 
Follow-up from #13541

We need to make sure this.props.userCanManageModules is available before we use it.
jeherve added a commit that referenced this pull request Oct 23, 2019
@jeherve
changelog: add #13541
d80af4e
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
jeherve added a commit that referenced this pull request May 13, 2021
@jeherve
Admin Page: display Sharing as new default tab for non-admins
b3915b7 
This commit changes the behaviour of the Settings screen for connected non-admins.

Non-admins currently need access to the Settings screen for 2 reasons:
- Publicize (Sharing tab)
- Post By Email (Writing tab)

Until now, we always defaulted to the Writing tab for connected non-admins. This has 2 problems:
- We did not check if the Post By Email module was actually enabled, so when the module was disabled editors loading the settings page would only see a Writing tab and its title, but no content.
- Publicize is more popular than Post By Email today, so it's more likely that editors will be interested in the Publicize settings first, even if both PBE and Publicize are enabled.

This commit changes that default behaviour, and introduces checks for the active modules to avoid displaying tabs when we do not need to.

Previous work on this: #13541
@jeherve jeherve mentioned this pull request May 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

@keoshi keoshi keoshi approved these changes

Assignees

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @jetpackbot @kraftbj @keoshi @matticbot