Site Logo: change enqueued CSS file depending on lang. & setti…

[jeherve]

Changes proposed in this Pull Request:

• When someone uses the SCRIPT_DEBUG constant, or has their site set to a RTL Language, they should get the right stylesheet enqueued.

Testing instructions:

• Add Site Logo support to your theme:

$args = array(
	'header-text' => array(
		'site-title',
		'site-description',
	),
	'size' => 'medium',
);
add_theme_support( 'site-logo', $args );

• Go to Appearance Customize, and check what files are enqueued on the page.
• You should see css/site-logo-control.min.css being enqueued.
• Go to Settings > General and switch your site language to Hebrew.
• You should see css/site-logo-control-rtl.min.css being enqueued.
• Add define( 'SCRIPT_DEBUG', true ); to wp-config.php
• You should see css/site-logo-control-rtl.css being enqueued.

Proposed changelog entry for your changes:

• Site Logo: ensure that the right stylesheet is loaded depending on your site's language.

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 288254c

[kraftbj]

Works as advertised. Note for anyone else testing, Jetpack will defer to the core custom logo option. If testing on a theme like Twenty Nineteen, you'd want to delete that section of functions.php OR use another theme that does not support core's custom logo.

[creativecoder]

Given I'm hoping to add this file to Fusion (D33578-code) to keep as much of the site-logo module in sync with wpcom as possible, will these changes work with wpcom?

[creativecoder]

Noting that there's something not quite right with the rtl styles here (See how "No logo set" is not centered in the rtl version). I think they need to be regenerated because the rtl version is not complete right now.

[jeherve]

@creativecoder Good catch indeed! It looks like those had never been updated. I just took care of it in f072285 and f93cd56. This should be ready for a new review.

[creativecoder]

Now tested and working as expected.

Note that the .min version is loading in my local Jetpack environment, even when the $min suffix is an empty string (because SCRIPT_DEBUG is true). But this is happening with a few other modules too, like widget-conditions, so I don’t think it's related to these changes.