-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection: Redirect plugins and dashboard connect buttons to the main flow #13599
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: October 1, 2019. |
I went though and tested the flows and they worked as expected. Thanks for fixing all the minor things I found a long the way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done.
Thanks for the review and for testing it Enej 🙌 |
* 7.9: Changelog * Update version number * Update stable tag and tested up to * Changelog: add #13530 * changelog: add #13578 * Changelog: add #13598 * Changelog: add entry for numerous block preview changes * Changelog: add #13599 * changelog: add #13541 * Changelog: add #13542 * Changelog: add #13331 * Changelog: add #13558 * Changelog: add #13409 * Changelog: add #13582 * Changelog: add #13600 * Changelog: add #13601 * Changelog: add #13595 * Changelog: add #12695 * Changelog: add #13009 * Changelog: add #13649 * Changelog: add #13450 * Changelog: add #13507 * Changelog: add #13658 * Changelog: add #13687 * changelog: add #13683 * Changelog: add #9323 * Changelog: add #13681 * Fix typos in readme * Add link to WordPress Beta Tester plugin * Changelog: add #13630 * Changelog: add #13695 * Changelog: add #13659 * Changelog: add #13716 * Changelog: add #13664 * Changelog: add #13682 * Changelog: add #13362 * Changelog: add #13563 * Add testing list for #13563 * Changelog: add #13735 * Changelog: add #13752 * Changelog: add #13624 * Changelog: add #13756 * Changelog: add #13745 * Changelog: add #13728 * Changelog: add #13779 * Changelog: add #13699 * Changelog: add #13804 * Changelog: add #13761 * Changelog: add #13637 * Changelog: add #13517 * Changelog: add #13521 * Changelog: add #13729 * Testing list: add testing instructions for #13729 * Changelog: add sync changes * Changelog: add #13807 * Changelog: add #13654 * Changelog: add #13795 * Changelog: add #13801 * Changelog: add #13818 * Changelog: add #13725 * Changelog: add #13831 * Changelog: add #13516 * Testing list: add Twenty Twenty instructions * Changelog: add #13799 * Changelog: add #13805 * Changelog: add #13688 * Changelog: add #13830
Currently, the main connection flow starting from
/wp-admin/admin.php?page=jetpack#/
has the connect-in-place flow, but the buttons starting from the WP-admin dashboard (/wp-admin/index.php
) and plugins screen (/wp-admin/plugins.php
) still work the old way.This PR updates these buttons so they respect the constant and A/B test, and based on them, redirect to either the original connection flow or the connect-in-place flow.
Changes proposed in this Pull Request:
JETPACK_SHOULD_USE_CONNECTION_IFRAME
constant.jetpack_connect_in_place_v2
A/B test.Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
npm build
.define( 'JETPACK_SHOULD_USE_CONNECTION_IFRAME', true );
/wp-admin/admin.php?page=jetpack#/
master
./wp-admin/index.php
./wp-admin/admin.php?page=jetpack#/setup
/wp-admin/plugins.php
./wp-admin/admin.php?page=jetpack#/setup
define( 'JETPACK_SHOULD_USE_CONNECTION_IFRAME', true );
/wp-admin/admin.php?page=jetpack#/
/wp-admin/index.php
./wp-admin/plugins.php
.Proposed changelog entry for your changes: