Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calypsoify: Update styles for parity with sidebar and masterbar #13659

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Calypsoify: Update styles for parity with sidebar and masterbar #13659

merged 2 commits into from
Oct 11, 2019

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Oct 4, 2019 •
edited
Loading

Changes proposed in this Pull Request:

  • Updates to margins and padding around elements in the masterbar
  • Adds 1px bottom border to the masterbar to match WP.com
  • Updates to colors, margins, and padding in the sidebar.
  • The intention here is to make subtle changes that help Calypsoify look less "off" compared to WP.com, so that transition is less jarring/disconcerting.

Before

Screen Shot 2019-10-04 at 4 23 40 PM

After

Screen Shot 2019-10-04 at 2 11 19 PM

Testing instructions:

  • Switch to this PR and navigate to /wp-admin/plugins.php?calypsoify=1. Ensure you're connected to WP.com.
  • Check out the sidebar and masterbar styles. Check for broken visuals.

Proposed changelog entry for your changes:

  • Update styles for visual parity with WP.com sidebar and masterbar

@sixhours sixhours requested a review from a team as a code owner October 4, 2019 19:53
@jetpackbot
Copy link

jetpackbot commented Oct 4, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 97f1cbf

@sixhours sixhours self-assigned this Oct 4, 2019
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Calypsoify labels Oct 7, 2019
@sixhours sixhours added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Oct 9, 2019
@sixhours
Copy link
Contributor Author

sixhours commented Oct 9, 2019

I was going to tweak some mobile-web styles, but in the interests of keeping this PR simple and straightforward, I'll do that in another PR. This is ready for a look-see.

@jeherve jeherve added this to the 7.9 milestone Oct 10, 2019
jeherve
jeherve approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 10, 2019
@kraftbj kraftbj merged commit 11aa749 into master Oct 11, 2019
@kraftbj kraftbj deleted the update/calypsoify-styles branch October 11, 2019 13:34
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 11, 2019
jeherve added a commit that referenced this pull request Oct 23, 2019
@jeherve
Changelog: add #13659
1233008
@jeherve jeherve mentioned this pull request Oct 28, 2019
Closed
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@sixhours sixhours

Labels
[Feature] Calypsoify [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
5 participants
@sixhours @jetpackbot @jeherve @kraftbj @matticbot