-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recurring Payments: AMP + analytics #14819
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 7, 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wfm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found an issue on Longreads with this patch. Don't merge until we figure out what's the cause.
The issue is that the popup modal that allows a user to subscribe isn't being displayed in a NON-AMP page - the user is being redirected to a the subscribe.wordpress.com instead.
Example - http://longreads.com/2020/01/15/whatever-happened-to-______/
The issue @eoigal found is related to how Wordpress.com VIP handles Google Analytics. |
artpi, Your synced wpcom patch D39464-code has been updated. |
As I understand the issue with needing to add the target property is because Longreads are using VIP google analytics plugin that is hijacking the links. Since the behaviour of adding the |
artpi, Your synced wpcom patch D39464-code has been updated. |
@eoigal you are right, I changed that. D39464-code will also require a change in themes/a8c/longreads/functions.php to test properly. |
ce987cc
to
096529a
Compare
artpi, Your synced wpcom patch D39464-code has been updated. |
1 similar comment
artpi, Your synced wpcom patch D39464-code has been updated. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to test well for me. I'd have a few notes below.
Howdy! The Jetpack team has disappeared for a few days to a secret island lair to concoct new ways to make Jetpack one hundred billion percent better. As a result, your Pull Request may not be reviewed right away. Do not worry, we will be back next week to look at your work! Thank you for your understanding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me. It should be good to merge!
artpi, Your synced wpcom patch D39464-code has been updated. |
156c6a8
to
72e22e1
Compare
artpi, Your synced wpcom patch D39464-code has been updated. |
* Initial changelog entry * Changelog: add #14904 * Changelog: add #14910 * Changelog: add #14913 * Changelog: add #14916 * Changelog: add #14922 * Changelog: add #14924 * Changelog: add #14925 * Changelog: add #14928 * Changelog: add #14840 * Changelog: add #14841 * Changelog: add #14842 * Changelog: add #14826 * Changelog: add #14835 * Changelog: add #14859 * Changelog: add #14884 * Changelog: add #14888 * Changelog: add #14817 * Changelog: add #14814 * Changelog: add #14819 * Changelog;: add #14797 * Changelog: add #14798 * Changelog: add #14802 * Changelog: add #13676 * Changelog: add #13744 * Changelog: add #13777 * Changelog: add #14446 * Changelog: add #14739 * Changelog: add #14770 * Changelog: add #14784 * Changelog: add #14897 * Changelog: add #14898 * Changelog: add #14968 * Changelog: add #14985 * Changelog: add #15044 * Changelog: add #15052 * Update to remove Podcast since it remains in Beta * Changelog: add #14803 * Changelog: add #15028 * Changelog: add #15065 * Changelog:add #14886 * Changelog: add #15118 * Changelog: add #14990 * Changelog: add #14528 * Changelog: add #15120 * Changelog: add #15126 * Changelog: add #15049 * Chanegelog: add #14852 * Changelog: add #15090 * Changelog: add #15138 * Changelog: add #15124 * Changelog:add #15055 * Changelog: add #15017 * Changelog: add #15109 * Changelog: add #15145 * Changelog:add #15096 * Changelog:add #15153 * Changelog: add #15133 * Changelog: add #14960 * Changelog: add #15127 * Changelog: add #15056 * Copy current changelog to changelog archive. * Clarify changelog description
There are no functional changes, this PR just reshuffles things in order to properly behave in AMP environment
Changes proposed in this Pull Request:
pid
parameter, which is the source post id. We want to start gathering this data, so we can provide analytics on which posts are most effective so our users can do proper testing of different approaches.Testing instructions:
/amp/
at the endProposed changelog entry for your changes:
Yes, checkout window is still WIP, but even in the current state it is better than the broken experience we have right now.