Update keywords for blocks #14842

scruffian · 2020-02-28T11:13:40Z

Some of the comments on the CfT for Google Calendar and Revue mentioned about our keyword use, so I reviewed every block and made a few changes to make our keywords more consistent.

Changes proposed in this Pull Request:

Added keywords where there were none.
Added additional keywords (up to 3) when there were more relevant ones
Removed pointless keywords, so that we only have 3 per block
Used _x for all keywords for consistency

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Changes to blocks

Testing instructions:

Try searching for blocks in the inserter using the relevant keywords and ensure they show

Proposed changelog entry for your changes:

no changelog

matticbot · 2020-02-28T11:13:46Z

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D39595-code before merging this PR. Thank you!

jetpackbot · 2020-02-28T11:15:40Z

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 4d8005d

apeatling

Looks good. I'm assuming "Map" as a search term was removed from the the map block because it matches on the block name already?

simison · 2020-03-01T07:36:33Z

The 3 keywords limit might've been removed. Wanna test and confirm? :-)

scruffian · 2020-03-02T11:54:50Z

Looks good. I'm assuming "Map" as a search term was removed from the the map block because it matches on the block name already?

Yep! Also, we have maps as a keyword, so map would match that too!

scruffian · 2020-03-02T15:23:06Z

The 3 keywords limit might've been removed. Wanna test and confirm? :-)

You're right, I'll add some more!

matticbot · 2020-03-02T15:32:42Z

scruffian, Your synced wpcom patch D39595-code has been updated.

apeatling · 2020-03-02T18:00:49Z

extensions/blocks/simple-payments/index.js

 		_x( 'sell', 'block search term', 'jetpack' ),
+		_x( 'shop', 'block search term', 'jetpack' ),
 		'PayPal',


What about "product"? There is products in the description, but not singular.

apeatling

Other than my suggestion above, this looks good. I rechecked call for testing posts and all suggestions were added. 👍

Copons · 2020-03-03T23:52:12Z

extensions/blocks/revue/index.js

+		_x( 'email', 'block search term', 'jetpack' ),
+		_x( 'subscription', 'block search term', 'jetpack' ),
+		_x( 'newsletter', 'block search term', 'jetpack' ),
+	],


What about also mailing list?
Might be redundant if the autocomplete matches mail with email anyway. 🤔

Good idea 👍

Copons · 2020-03-03T23:53:04Z

extensions/blocks/wordads/index.js

+	keywords: [
+		_x( 'ads', 'block search term', 'jetpack' ),
+		'WordAds',
+		_x( 'Advertisement', 'block search term', 'jetpack' ),


Extreme nitpick ahead: is this the only capitalized keyword? 😄

extensions/blocks/recurring-payments/index.js

extensions/blocks/slideshow/index.js

extensions/blocks/tiled-gallery/index.js

matticbot · 2020-03-04T11:57:14Z

scruffian, Your synced wpcom patch D39595-code has been updated.

scruffian · 2020-03-04T11:58:17Z

This is ready for another review.

matticbot · 2020-03-05T16:38:53Z

scruffian, Your synced wpcom patch D39595-code has been updated.

scruffian · 2020-03-05T16:51:39Z

r203912-wpcom

* Initial changelog entry * Changelog: add #14904 * Changelog: add #14910 * Changelog: add #14913 * Changelog: add #14916 * Changelog: add #14922 * Changelog: add #14924 * Changelog: add #14925 * Changelog: add #14928 * Changelog: add #14840 * Changelog: add #14841 * Changelog: add #14842 * Changelog: add #14826 * Changelog: add #14835 * Changelog: add #14859 * Changelog: add #14884 * Changelog: add #14888 * Changelog: add #14817 * Changelog: add #14814 * Changelog: add #14819 * Changelog;: add #14797 * Changelog: add #14798 * Changelog: add #14802 * Changelog: add #13676 * Changelog: add #13744 * Changelog: add #13777 * Changelog: add #14446 * Changelog: add #14739 * Changelog: add #14770 * Changelog: add #14784 * Changelog: add #14897 * Changelog: add #14898 * Changelog: add #14968 * Changelog: add #14985 * Changelog: add #15044 * Changelog: add #15052 * Update to remove Podcast since it remains in Beta * Changelog: add #14803 * Changelog: add #15028 * Changelog: add #15065 * Changelog:add #14886 * Changelog: add #15118 * Changelog: add #14990 * Changelog: add #14528 * Changelog: add #15120 * Changelog: add #15126 * Changelog: add #15049 * Chanegelog: add #14852 * Changelog: add #15090 * Changelog: add #15138 * Changelog: add #15124 * Changelog:add #15055 * Changelog: add #15017 * Changelog: add #15109 * Changelog: add #15145 * Changelog:add #15096 * Changelog:add #15153 * Changelog: add #15133 * Changelog: add #14960 * Changelog: add #15127 * Changelog: add #15056 * Copy current changelog to changelog archive. * Clarify changelog description

Update keywords for blocks

bd03418

scruffian added [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Eventbrite [Block] OpenTable [Block] Calendly [Block] Google Calendar labels Feb 28, 2020

scruffian requested a review from a team February 28, 2020 11:13

scruffian requested a review from a team as a code owner February 28, 2020 11:13

scruffian self-assigned this Feb 28, 2020

matticbot added Touches WP.com Files labels Feb 28, 2020

scruffian added [Block] Map [Block] Pinterest [Block] Revue [Feature] Related Posts [Feature] WordAds [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 28, 2020

apeatling previously approved these changes Feb 28, 2020

View reviewed changes

adding more keywords

6ee5ef6

scruffian dismissed apeatling’s stale review via 6ee5ef6 March 2, 2020 15:32

apeatling reviewed Mar 2, 2020

View reviewed changes

apeatling self-requested a review March 2, 2020 22:22

apeatling previously approved these changes Mar 2, 2020

View reviewed changes

Copons reviewed Mar 3, 2020

View reviewed changes

jeherve reviewed Mar 4, 2020

View reviewed changes

extensions/blocks/recurring-payments/index.js Outdated Show resolved Hide resolved

extensions/blocks/slideshow/index.js Outdated Show resolved Hide resolved

extensions/blocks/tiled-gallery/index.js Outdated Show resolved Hide resolved

jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 4, 2020

jeherve added this to the 8.4 milestone Mar 4, 2020

Update keywords

4d8005d

scruffian dismissed apeatling’s stale review via 4d8005d March 4, 2020 11:57

scruffian added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Mar 4, 2020

apeatling self-requested a review March 4, 2020 15:25

apeatling approved these changes Mar 4, 2020

View reviewed changes

Copons approved these changes Mar 4, 2020

View reviewed changes

jeherve approved these changes Mar 5, 2020

View reviewed changes

jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 5, 2020

scruffian merged commit 04bfea9 into master Mar 5, 2020

scruffian deleted the update/block-keywords branch March 5, 2020 16:40

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 5, 2020

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels Mar 20, 2020

jeherve added a commit that referenced this pull request Mar 20, 2020

Changelog: add #14842

0f38a8a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update keywords for blocks #14842

Update keywords for blocks #14842

scruffian commented Feb 28, 2020

matticbot commented Feb 28, 2020

jetpackbot commented Feb 28, 2020 •

edited

Loading

apeatling left a comment

simison commented Mar 1, 2020

scruffian commented Mar 2, 2020 •

edited

Loading

scruffian commented Mar 2, 2020

matticbot commented Mar 2, 2020

apeatling Mar 2, 2020

apeatling left a comment

Copons Mar 3, 2020

scruffian Mar 4, 2020

Copons Mar 3, 2020

matticbot commented Mar 4, 2020

scruffian commented Mar 4, 2020

matticbot commented Mar 5, 2020

scruffian commented Mar 5, 2020

Update keywords for blocks #14842

Update keywords for blocks #14842

Conversation

scruffian commented Feb 28, 2020

Changes proposed in this Pull Request:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

Proposed changelog entry for your changes:

matticbot commented Feb 28, 2020

jetpackbot commented Feb 28, 2020 • edited Loading

apeatling left a comment

Choose a reason for hiding this comment

simison commented Mar 1, 2020

scruffian commented Mar 2, 2020 • edited Loading

scruffian commented Mar 2, 2020

matticbot commented Mar 2, 2020

apeatling Mar 2, 2020

Choose a reason for hiding this comment

apeatling left a comment

Choose a reason for hiding this comment

Copons Mar 3, 2020

Choose a reason for hiding this comment

scruffian Mar 4, 2020

Choose a reason for hiding this comment

Copons Mar 3, 2020

Choose a reason for hiding this comment

matticbot commented Mar 4, 2020

scruffian commented Mar 4, 2020

matticbot commented Mar 5, 2020

scruffian commented Mar 5, 2020

jetpackbot commented Feb 28, 2020 •

edited

Loading

scruffian commented Mar 2, 2020 •

edited

Loading