-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keywords for blocks #14842
Update keywords for blocks #14842
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 7, 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm assuming "Map" as a search term was removed from the the map block because it matches on the block name already?
The 3 keywords limit might've been removed. Wanna test and confirm? :-) |
Yep! Also, we have |
You're right, I'll add some more! |
scruffian, Your synced wpcom patch D39595-code has been updated. |
_x( 'sell', 'block search term', 'jetpack' ), | ||
_x( 'shop', 'block search term', 'jetpack' ), | ||
'PayPal', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about "product"? There is products in the description, but not singular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my suggestion above, this looks good. I rechecked call for testing posts and all suggestions were added. 👍
_x( 'email', 'block search term', 'jetpack' ), | ||
_x( 'subscription', 'block search term', 'jetpack' ), | ||
_x( 'newsletter', 'block search term', 'jetpack' ), | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about also mailing list
?
Might be redundant if the autocomplete matches mail
with email
anyway. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea 👍
extensions/blocks/wordads/index.js
Outdated
keywords: [ | ||
_x( 'ads', 'block search term', 'jetpack' ), | ||
'WordAds', | ||
_x( 'Advertisement', 'block search term', 'jetpack' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extreme nitpick ahead: is this the only capitalized keyword? 😄
scruffian, Your synced wpcom patch D39595-code has been updated. |
This is ready for another review. |
scruffian, Your synced wpcom patch D39595-code has been updated. |
r203912-wpcom |
* Initial changelog entry * Changelog: add #14904 * Changelog: add #14910 * Changelog: add #14913 * Changelog: add #14916 * Changelog: add #14922 * Changelog: add #14924 * Changelog: add #14925 * Changelog: add #14928 * Changelog: add #14840 * Changelog: add #14841 * Changelog: add #14842 * Changelog: add #14826 * Changelog: add #14835 * Changelog: add #14859 * Changelog: add #14884 * Changelog: add #14888 * Changelog: add #14817 * Changelog: add #14814 * Changelog: add #14819 * Changelog;: add #14797 * Changelog: add #14798 * Changelog: add #14802 * Changelog: add #13676 * Changelog: add #13744 * Changelog: add #13777 * Changelog: add #14446 * Changelog: add #14739 * Changelog: add #14770 * Changelog: add #14784 * Changelog: add #14897 * Changelog: add #14898 * Changelog: add #14968 * Changelog: add #14985 * Changelog: add #15044 * Changelog: add #15052 * Update to remove Podcast since it remains in Beta * Changelog: add #14803 * Changelog: add #15028 * Changelog: add #15065 * Changelog:add #14886 * Changelog: add #15118 * Changelog: add #14990 * Changelog: add #14528 * Changelog: add #15120 * Changelog: add #15126 * Changelog: add #15049 * Chanegelog: add #14852 * Changelog: add #15090 * Changelog: add #15138 * Changelog: add #15124 * Changelog:add #15055 * Changelog: add #15017 * Changelog: add #15109 * Changelog: add #15145 * Changelog:add #15096 * Changelog:add #15153 * Changelog: add #15133 * Changelog: add #14960 * Changelog: add #15127 * Changelog: add #15056 * Copy current changelog to changelog archive. * Clarify changelog description
Some of the comments on the CfT for Google Calendar and Revue mentioned about our keyword use, so I reviewed every block and made a few changes to make our keywords more consistent.
Changes proposed in this Pull Request:
_x
for all keywords for consistencyIs this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Proposed changelog entry for your changes: