-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Tidy: Add mask, scroll, and object-fit properties #15044
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 7, 2020. |
@lancewillett Adding you as a reviewer since you've worked on this recently. Thank you! |
Even though my HACK week developer time is now over, I'll try to look soon. Should be a quick one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nielslange Could you please also add object-fit
and object-position
?
@jeherve Does it mess up the sync if I change Phabricator diff summary text? |
@lancewillett In 3f2897e you can find the updated version as requested by you in #15044 (review) |
It doesn't, no worries! However, if you make changes to the diff itself, those changes will be lost every time the bot updates the diff because the PR here has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, should be good to merge once the tests pass (I had to rebase to fix a bad test).
WP.com change landed in r204590-wpcom |
I love that GitHub to Phabricator push. Wow! That is a time saver. |
* Initial changelog entry * Changelog: add #14904 * Changelog: add #14910 * Changelog: add #14913 * Changelog: add #14916 * Changelog: add #14922 * Changelog: add #14924 * Changelog: add #14925 * Changelog: add #14928 * Changelog: add #14840 * Changelog: add #14841 * Changelog: add #14842 * Changelog: add #14826 * Changelog: add #14835 * Changelog: add #14859 * Changelog: add #14884 * Changelog: add #14888 * Changelog: add #14817 * Changelog: add #14814 * Changelog: add #14819 * Changelog;: add #14797 * Changelog: add #14798 * Changelog: add #14802 * Changelog: add #13676 * Changelog: add #13744 * Changelog: add #13777 * Changelog: add #14446 * Changelog: add #14739 * Changelog: add #14770 * Changelog: add #14784 * Changelog: add #14897 * Changelog: add #14898 * Changelog: add #14968 * Changelog: add #14985 * Changelog: add #15044 * Changelog: add #15052 * Update to remove Podcast since it remains in Beta * Changelog: add #14803 * Changelog: add #15028 * Changelog: add #15065 * Changelog:add #14886 * Changelog: add #15118 * Changelog: add #14990 * Changelog: add #14528 * Changelog: add #15120 * Changelog: add #15126 * Changelog: add #15049 * Chanegelog: add #14852 * Changelog: add #15090 * Changelog: add #15138 * Changelog: add #15124 * Changelog:add #15055 * Changelog: add #15017 * Changelog: add #15109 * Changelog: add #15145 * Changelog:add #15096 * Changelog:add #15153 * Changelog: add #15133 * Changelog: add #14960 * Changelog: add #15127 * Changelog: add #15056 * Copy current changelog to changelog archive. * Clarify changelog description
Fixes #14993
Changes proposed in this Pull Request:
Add
mask
,scroll
, andobject-fit
properties to CSS support.Is this a new feature or does it add/remove features to an existing part of Jetpack?
It's an enhancement of the current supported CSS elements.
Testing instructions:
mask
orscroll
orobject-fit
properties as mentioned in CSS Tidy: improve modern CSS support for properties such as mask and scroll #14993 (comment)Proposed changelog entry for your changes:
mask
,scroll
, andobject-fit