Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Run tests with PHP 8.1, experimentally #21207

Merged
merged 8 commits into from
Oct 26, 2021
Merged

CI: Run tests with PHP 8.1, experimentally #21207

merged 8 commits into from
Oct 26, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Sep 27, 2021

Changes proposed in this Pull Request:

PHP 8.1 is getting close to release. Let's run tests with it so we can start
cleaning stuff up.

This is certainly going to fail a lot of stuff for the moment, as WordPress
itself is still working on this. But we may as well get a head start on
it.

Also set convertDeprecationsToExceptions true in PHPUnit configs. PHPUnit is
defaulting this to false starting in 8.5.21 and 9.5.10, and recommending
everyone change their configs to set it back to true. And PHP 8.1 is bringing a
lot of deprecations.

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Is a "PHP tests: PHP 8.1 WP master" job running? It won't be passing, of course.
  • Did the "Tests" workflow report as passing even though the above job failed?

@anomiex
Update composer requirement to 2.1
dfee380 
PHP 8.1 is coming soon, and it makes Composer 2.0 spit out tons of
deprecation warnings. Plus 2.1 has been out for a while now. Seems like
a good time to finally update.
@anomiex
CI: Run tests with PHP 8.1, experimentally
40982aa 
PHP 8.1 is getting close to release. Let's run tests with it so we can
start cleaning stuff up.

This is certainly going to fail a lot of stuff for the moment, as
WordPress itself is [still working on this][1]. But we may as well get a
head start on it.

[1]: https://core.trac.wordpress.org/ticket/53635
@anomiex
Set convertDeprecationsToExceptions true in PHPUnit configs
541ae71 
PHPUnit is defaulting this to false starting in 8.5.21 and 9.5.10, and
recommending everyone change their configs to set it back to true.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal labels Sep 27, 2021
@anomiex anomiex self-assigned this Sep 27, 2021
test-case-reminder[bot]
test-case-reminder bot reviewed Sep 27, 2021
View reviewed changes
Copy link

@test-case-reminder test-case-reminder bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggested test cases for this PR.

Connection

  • In-place connection with free plan
  • In-place connection with paid plan
  • In-place connection with product purchase
  • Classic connection. Use Safari, or set a constant JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME to true
  • Disconnect/reconnect connection
  • Secondary user connection
  • Connection on multisite

Verify that the changes are compatible with the plugins that use the connection package.

  • WooCommerce Payments
  • Jetpack Boost
  • Previous versions of Jetpack

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] VaultPress [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management labels Sep 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Beta plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

Jetpack plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

Debug Helper plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

Backup plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

Vaultpress plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

Boost plugin:

  • Next scheduled release: November 30, 2021.
  • Scheduled code freeze: November 23, 2021.

Search plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

Base automatically changed from update/composer-to-2.1 to master September 27, 2021 20:21
@github-actions github-actions bot added [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Debug Helper Debug Tools plugin labels Sep 27, 2021
@github-actions github-actions bot added [Package] Admin Ui [Package] Search Contains core Search functionality for Jetpack and Search plugins labels Oct 26, 2021
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Oct 26, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 26, 2021
@jeherve jeherve added this to the jetpack/10.4 milestone Oct 26, 2021
@anomiex anomiex merged commit 0116966 into master Oct 26, 2021
@anomiex anomiex deleted the add/test-with-php-8.1 branch October 26, 2021 18:41
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 26, 2021
@anomiex anomiex mentioned this pull request Oct 27, 2021
Merged
davidlonjon added a commit that referenced this pull request Oct 28, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-ci-integration
b2c0236 
* master: (22 commits)
  Update PHPUnit coverage configs (#21557)
  cli: Fix skeleton phpunit config (#21555)
  Publicize: fix panel issue (#21560)
  Connection: move IDC args from Sync to Connection (#21147)
  Debug Helper IDC Simulator: add a button to trigger a remote request (#21535)
  cli: Fix docker sftp volume mapping (#21547)
  Add Docs and Tests to the js-redirect js tool (#21541)
  Debug Helper IDC Simulator: display the last five remote requests (#21534)
  actions: Build arm64 Docker image too (#21548)
  CI: Run tests with PHP 8.1, experimentally (#21207)
  changelogger: Adjust for PHP 8.1 compat (#21209)
  Publicize: handle main toggle control (#21540)
  E2E tests: wrapper over tunnel script (#21543)
  Update storybook monorepo to v6.3.12 (#21527)
  10.4: start release cycle (#21546)
  10.3 Beta release: changelog and version bumps (#21539)
  Debug Helper IDC Simulator: add setting to enable/disable Sync (#21532)
  Debug Helper IDC Simulator: display the IDC options. (#21529)
  Admin Page: Do not display version numbers on Atomic platform (#21533)
  Atomic: Supress Development Version status for weekly releases (#21460)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@test-case-reminder test-case-reminder[bot] test-case-reminder[bot] left review comments

@jeherve jeherve jeherve approved these changes

Assignees

@anomiex anomiex

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Package] A8c Mc Stats [Package] Abtest This package no longer exists in the monorepo. Its replacement is [Package] Explat. [Package] Admin Ui [Package] Assets [Package] Autoloader [Package] Backup [Package] Blocks [Package] Changelogger [Package] Codesniffer [Package] Connection [Package] Constants [Package] Device Detection [Package] Error [Package] Identity Crisis This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Jitm [Package] Lazy Images This package no longer exists in the monorepo. [Package] Licensing [Package] Logo [Package] Partner This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Password Checker [Package] Post List [Package] Redirect [Package] Roles [Package] Search Contains core Search functionality for Jetpack and Search plugins [Package] Status [Package] Sync [Package] Terms of Service This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Tracking This package no longer exists in the monorepo. It was merged into [Package] Connection. [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Debug Helper Debug Tools plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] VaultPress [Pri] Normal [Tools] Development CLI The tools/cli to assist during JP development. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
jetpack/10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@anomiex @jeherve @matticbot