Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelogger: Adjust for PHP 8.1 compat #21209

Merged
merged 6 commits into from
Oct 26, 2021
Merged

changelogger: Adjust for PHP 8.1 compat #21209

merged 6 commits into from
Oct 26, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Sep 27, 2021

Changes proposed in this Pull Request:

Add the ReturnTypeWillChange annotation in a few places, and a string
cast where a trim() was being passed null.

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Is CI happy?
  • Try things and see if they still work.

@anomiex
changelogger: Adjust for PHP 8.1 compat
5b14e09 
Add the ReturnTypeWillChange annotation in a few places, and a string
cast where a `trim()` was being passed null.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Sep 27, 2021
@anomiex anomiex self-assigned this Sep 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

jeherve
jeherve reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CI happy?

Nope, CI is not happy :)

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 28, 2021
@anomiex
Copy link
Contributor Author

anomiex commented Sep 29, 2021

The error in "Linting / PHP Code Sniffer (non-excluded files only)" is a bug in the sniff, which will be fixed by phpcs 3.6.1.

The error in "PHP Compatibility / dev branch for PHP 8.0" probably just needs that rule disabled. Earlier versions of PHP treat attributes as comments, so it's fine to have them.

@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Sep 29, 2021
@anomiex anomiex added [Status] Blocked / Hold and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Sep 29, 2021
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Blocked / Hold labels Oct 26, 2021
@anomiex
Copy link
Contributor Author

anomiex commented Oct 26, 2021

CI is happy now.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 26, 2021
@anomiex anomiex merged commit de509aa into master Oct 26, 2021
@anomiex anomiex deleted the fix/changelogger-php-8.1 branch October 26, 2021 16:27
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 26, 2021
davidlonjon added a commit that referenced this pull request Oct 28, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-ci-integration
b2c0236 
* master: (22 commits)
  Update PHPUnit coverage configs (#21557)
  cli: Fix skeleton phpunit config (#21555)
  Publicize: fix panel issue (#21560)
  Connection: move IDC args from Sync to Connection (#21147)
  Debug Helper IDC Simulator: add a button to trigger a remote request (#21535)
  cli: Fix docker sftp volume mapping (#21547)
  Add Docs and Tests to the js-redirect js tool (#21541)
  Debug Helper IDC Simulator: display the last five remote requests (#21534)
  actions: Build arm64 Docker image too (#21548)
  CI: Run tests with PHP 8.1, experimentally (#21207)
  changelogger: Adjust for PHP 8.1 compat (#21209)
  Publicize: handle main toggle control (#21540)
  E2E tests: wrapper over tunnel script (#21543)
  Update storybook monorepo to v6.3.12 (#21527)
  10.4: start release cycle (#21546)
  10.3 Beta release: changelog and version bumps (#21539)
  Debug Helper IDC Simulator: add setting to enable/disable Sync (#21532)
  Debug Helper IDC Simulator: display the IDC options. (#21529)
  Admin Page: Do not display version numbers on Atomic platform (#21533)
  Atomic: Supress Development Version status for weekly releases (#21460)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@anomiex anomiex

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Package] Changelogger [Pri] Normal [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anomiex @jeherve