actions: Build arm64 Docker image too #21548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're building an amd64 (Intel) image, but not one for M1 Macs. Which makes it run s-l-o-w for said Macs. Also, update the action to push PR tags to ghcr.io (but not Docker Hub) to allow for testing. Public open-source project usage is [apparently][1] free, so we may as well take advantage of it. [1]: https://docs.github.com/en/billing/managing-billing-for-github-packages/about-billing-for-github-packages
anomiex
added
[Type] Enhancement
github-actions
bot
added
the
Actions
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
It's the only one we're using, may as well save some effort.
anomiex
added
[Status] Needs Review
jeherve
added
[Status] Ready to Merge
github-actions
bot
removed
the
[Status] Ready to Merge
davidlonjon
added a commit
that referenced
this pull request
Oct 28, 2021
* master: (22 commits) Update PHPUnit coverage configs (#21557) cli: Fix skeleton phpunit config (#21555) Publicize: fix panel issue (#21560) Connection: move IDC args from Sync to Connection (#21147) Debug Helper IDC Simulator: add a button to trigger a remote request (#21535) cli: Fix docker sftp volume mapping (#21547) Add Docs and Tests to the js-redirect js tool (#21541) Debug Helper IDC Simulator: display the last five remote requests (#21534) actions: Build arm64 Docker image too (#21548) CI: Run tests with PHP 8.1, experimentally (#21207) changelogger: Adjust for PHP 8.1 compat (#21209) Publicize: handle main toggle control (#21540) E2E tests: wrapper over tunnel script (#21543) Update storybook monorepo to v6.3.12 (#21527) 10.4: start release cycle (#21546) 10.3 Beta release: changelog and version bumps (#21539) Debug Helper IDC Simulator: add setting to enable/disable Sync (#21532) Debug Helper IDC Simulator: display the IDC options. (#21529) Admin Page: Do not display version numbers on Atomic platform (#21533) Atomic: Supress Development Version status for weekly releases (#21460) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
We're building an amd64 (Intel) image, but not one for M1 Macs. Which
makes it run s-l-o-w for said Macs.
Also, update the action to push PR tags to ghcr.io (but not Docker Hub)
to allow for testing. Public open-source project usage is
apparently free, so we may as well take advantage of it.
Jetpack product discussion
p1635264502004600/1635162859.001700-slack-C02HQGKMFJ8
Does this pull request change what data or activity we track or use?
No
Testing instructions:
docker run --rm -it ghcr.io/automattic/jetpack-wordpress-dev:pr-21548 bash.time for ((i = 0; i < 1000; i++)); do /bin/true; done. It should take closer to 0.5s than 11s.docker run --rm -it automattic/jetpack-wordpress-dev:latest.