Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: Do not display version numbers on Atomic platform #21533

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Admin Page: Do not display version numbers on Atomic platform #21533

merged 4 commits into from
Oct 26, 2021

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Oct 25, 2021

  • Add isAtomicPlatform and update other Atomic-related functions
  • Do not display version for any Atomic hosted site
  • Do not show version bump information

Marking as blocked until 21460 lands.

Builds upon #21460

Changes proposed in this Pull Request:

  • Hides the version number in the footer for all Atomic sites (not just WoA)
  • Hides the Welcome to Jetpack x.y.z for all Atomic sites (not just WoA)
  • Introduces isAtomicPlatform state
  • Introduces isWoASite state
  • Soft-deprecates (e.g. in a comment only) isAtomicSite as it is not specific enough.

Jetpack product discussion

Various but about this specifically pbfA90-jV-p2#comment-1525

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • On a Pressable site, install Jetpack Beta, install this branch. Rename the dir from jetpack-dev to jetpack-anything.
  • Activate and connect this version of Jetpack (not the symlinked one)
  • Go to the Jetpack dashboard and confirm there is not a version number in the footer.

@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Blocked / Hold labels Oct 25, 2021
@kraftbj kraftbj added this to the jetpack/10.4 milestone Oct 25, 2021
@kraftbj kraftbj requested a review from jeherve October 25, 2021 21:22
@kraftbj kraftbj self-assigned this Oct 25, 2021
@kraftbj kraftbj changed the base branch from master to fix/atomic-return-is-dev-version October 25, 2021 21:22
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu labels Oct 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

@github-actions github-actions bot added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 25, 2021
@kraftbj kraftbj removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 25, 2021
@jeherve
Copy link
Member

jeherve commented Oct 26, 2021

Related: #21082 and 745-gh-wpcomsh

Base automatically changed from fix/atomic-return-is-dev-version to master October 26, 2021 10:46
@github-actions github-actions bot added [Block] Map [Block] Paid Content aka Premium Content [Package] Connection [Package] Identity Crisis This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Jitm [Package] Redirect [Package] Status [Package] Sync [Package] Terms of Service This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Tracking This package no longer exists in the monorepo. It was merged into [Package] Connection. [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Feature] Ad labels Oct 26, 2021
@kraftbj kraftbj removed [Block] Map [Feature] WordPress.com Block Editor [Package] Status [Package] Connection [Package] Terms of Service This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Tracking This package no longer exists in the monorepo. It was merged into [Package] Connection. [Block] Paid Content aka Premium Content [Package] Jitm [Package] Redirect [Feature] Cloudflare Analytics [Package] Identity Crisis This package no longer exists in the monorepo. It was merged into [Package] Connection. [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Focus] Compatibility Ensuring our products play well with third-parties [Plugin] Boost A feature to speed up the site and improve performance. [Feature] Ad labels Oct 26, 2021
@kraftbj
Copy link
Contributor Author

kraftbj commented Oct 26, 2021

@samiff Thanks for testing this on the other PR.

If you or @jeherve are comfortable, would y'all consider merging this before today's Atomic release?

I can do the plugins page version in a follow up but not having a "Welcome to Jetpack ...." with an a or beta version would be a nice delivery for those folks.

@kraftbj kraftbj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Blocked / Hold labels Oct 26, 2021
@jeherve jeherve modified the milestones: jetpack/10.4, jetpack/10.3 Oct 26, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 26, 2021
@jeherve jeherve enabled auto-merge (squash) October 26, 2021 12:14
@jeherve jeherve merged commit 60a12f7 into master Oct 26, 2021
@jeherve jeherve deleted the hide/atomic-version-everywhere branch October 26, 2021 12:14
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 26, 2021
jeherve added a commit that referenced this pull request Oct 26, 2021
@jeherve
Consider change added in #21533
04aeae0
@jeherve
Copy link
Member

jeherve commented Oct 26, 2021

I hadn't explored yet that piece of it. @jeherve What do you think about including that in Jetpack itself (3rd-party)?

Yes, that seems like a good idea now that we have better tools and a precedent for the Atomic platform in there.

davidlonjon added a commit that referenced this pull request Oct 28, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-ci-integration
b2c0236 
* master: (22 commits)
  Update PHPUnit coverage configs (#21557)
  cli: Fix skeleton phpunit config (#21555)
  Publicize: fix panel issue (#21560)
  Connection: move IDC args from Sync to Connection (#21147)
  Debug Helper IDC Simulator: add a button to trigger a remote request (#21535)
  cli: Fix docker sftp volume mapping (#21547)
  Add Docs and Tests to the js-redirect js tool (#21541)
  Debug Helper IDC Simulator: display the last five remote requests (#21534)
  actions: Build arm64 Docker image too (#21548)
  CI: Run tests with PHP 8.1, experimentally (#21207)
  changelogger: Adjust for PHP 8.1 compat (#21209)
  Publicize: handle main toggle control (#21540)
  E2E tests: wrapper over tunnel script (#21543)
  Update storybook monorepo to v6.3.12 (#21527)
  10.4: start release cycle (#21546)
  10.3 Beta release: changelog and version bumps (#21539)
  Debug Helper IDC Simulator: add setting to enable/disable Sync (#21532)
  Debug Helper IDC Simulator: display the IDC options. (#21529)
  Admin Page: Do not display version numbers on Atomic platform (#21533)
  Atomic: Supress Development Version status for weekly releases (#21460)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@kraftbj kraftbj

Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Milestone
jetpack/10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@kraftbj @jeherve @matticbot