Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Fix docker sftp volume mapping #21547

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Oct 26, 2021

Changes proposed in this Pull Request:

The previous code was not mapping the volumes correctly. It seemed to be
assuming it was mapping over the target paths rather than the
"src:target" strings.

Also it seems we need to put everything under /home/wordpress, otherwise
the symlinks fail.

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Set up sftp in your docker environment. Then sftp in and see if /var/www/html/wp-content/plugins/jetpack/ has Jetpack.

The previous code was not mapping the volumes correctly. It seemed to be
assuming it was mapping over the target paths rather than the
"src:target" strings.

Also it seems we need to put everything under /home/wordpress, otherwise
the symlinks fail.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal Docker labels Oct 26, 2021
@anomiex anomiex self-assigned this Oct 26, 2021
@github-actions github-actions bot added the [Tools] Development CLI The tools/cli to assist during JP development. label Oct 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@anomiex anomiex enabled auto-merge (squash) October 26, 2021 18:40
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. 🚢

@anomiex anomiex merged commit de3c861 into master Oct 27, 2021
@anomiex anomiex deleted the fix/docker-sftp-volume-map branch October 27, 2021 18:00
@jeherve jeherve removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Oct 27, 2021
davidlonjon added a commit that referenced this pull request Oct 28, 2021
* master: (22 commits)
  Update PHPUnit coverage configs (#21557)
  cli: Fix skeleton phpunit config (#21555)
  Publicize: fix panel issue (#21560)
  Connection: move IDC args from Sync to Connection (#21147)
  Debug Helper IDC Simulator: add a button to trigger a remote request (#21535)
  cli: Fix docker sftp volume mapping (#21547)
  Add Docs and Tests to the js-redirect js tool (#21541)
  Debug Helper IDC Simulator: display the last five remote requests (#21534)
  actions: Build arm64 Docker image too (#21548)
  CI: Run tests with PHP 8.1, experimentally (#21207)
  changelogger: Adjust for PHP 8.1 compat (#21209)
  Publicize: handle main toggle control (#21540)
  E2E tests: wrapper over tunnel script (#21543)
  Update storybook monorepo to v6.3.12 (#21527)
  10.4: start release cycle (#21546)
  10.3 Beta release: changelog and version bumps (#21539)
  Debug Helper IDC Simulator: add setting to enable/disable Sync (#21532)
  Debug Helper IDC Simulator: display the IDC options. (#21529)
  Admin Page: Do not display version numbers on Atomic platform (#21533)
  Atomic: Supress Development Version status for weekly releases (#21460)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker [Pri] Normal [Tools] Development CLI The tools/cli to assist during JP development. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants