feat: avm lookup and/or/xor

[IlyasRidhuan]

lookup op for and/or and xor, plus a refactor of the test to use TEST_Ps

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_successful_decrypting_time_in_ms (32): 641 (+24%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit f024751b and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,388 (-1%)	6,424
l1_rollup_execution_gas	585,745	585,721	585,757
l2_block_processing_time_in_ms	1,342 (+4%)	4,911 (+4%)	9,074 (+1%)
note_successful_decrypting_time_in_ms	175 (-5%)	⚠️ 641 (+24%)	1,046 (+9%)
note_trial_decrypting_time_in_ms	79.5 (-11%)	60.8 (+74%)	60.9 (-35%)
l2_block_building_time_in_ms	14,085 (+1%)	52,468 (+2%)	103,442 (+1%)
l2_block_rollup_simulation_time_in_ms	8,085 (+1%)	28,626 (+2%)	56,056 (+1%)
l2_block_public_tx_process_time_in_ms	5,975	23,790 (+1%)	47,285 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,631 (+3%)	26,130 (-5%)
note_history_successful_decrypting_time_in_ms	1,219 (-3%)	2,455 (+3%)
note_history_trial_decrypting_time_in_ms	63.2 (-39%)	150 (+30%)
node_database_size_in_bytes	18,632,784	35,029,072
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	236 (-4%)	44,379	28,214
private-kernel-ordering	208 (-4%)	52,880	14,296
base-parity	4,586 (+2%)	128	311
root-parity	1,631 (+3%)	1,244	311
base-rollup	18,182 (+1%)	165,760	861
root-rollup	50.3 (-1%)	4,359	725
private-kernel-inner	308 (-2%)	73,795	28,214
public-kernel-app-logic	125 (-5%)	35,252	28,217
public-kernel-tail	169 (-6%)	40,928	28,217
merge-rollup	9.56 (+8%)	2,568	861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1 (+1%)	16.0	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.587	0.494	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.7 (-5%)	72.6 (+1%)	235 (+2%)	446 (-1%)	878 (+1%)	1,727 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.479 (-5%)	0.447	0.427 (+2%)	0.416 (-1%)	0.415	0.413	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.3 (-4%)	108 (+2%)	346 (+3%)	662	1,332 (+2%)	2,645 (+2%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.482 (-4%)	0.483 (+1%)	0.469 (+2%)	0.455	0.458 (+1%)	0.457 (+1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.5 (-2%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.537 (-2%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,967	494,914

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,386 (-6%)	1,413 (-2%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	16.3 (+2%)	734 (-4%)

[jeanmon]

@IlyasRidhuan Please create tickets (if not done) or amend this PR for the remaining tasks:

• deserialization and execution support for XOR, OR, AND
• indirect memory support for XOR, OR, AND

[jeanmon]

Very good job! Very nice to have introduced parametrised tests. We will have to migrate other test suites in due time.
Please look at the feedback before merging.

[github-actions]

Changes to circuit sizes

Generated at commit: 8e1faeb5307dbf42f0866c9d3d79b6afea5ab8b2, compared to commit: 501c5e95c4c536ea061ad6da5b9d8cd3ec322e5c

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init	+2 ❌	+0.00%	+898 ❌	+0.26%
public_kernel_app_logic	+7 ❌	+0.01%	+594 ❌	+0.19%
public_kernel_setup	+4 ❌	+0.01%	+311 ❌	+0.17%
public_kernel_teardown	+4 ❌	+0.01%	+311 ❌	+0.17%
private_kernel_inner	+1 ❌	+0.00%	+312 ❌	+0.06%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_init	48,601 (+2)	+0.00%	349,510 (+898)	+0.26%
public_kernel_app_logic	56,073 (+7)	+0.01%	314,747 (+594)	+0.19%
public_kernel_setup	29,342 (+4)	+0.01%	183,091 (+311)	+0.17%
public_kernel_teardown	29,427 (+4)	+0.01%	183,177 (+311)	+0.17%
private_kernel_inner	95,865 (+1)	+0.00%	520,365 (+312)	+0.06%