chore: Use random tmp directory and cleanup afterwards

[PhilWindle]

End to end tests fail to run due to conflicts on /tmp/acvm/. This PR introduces a random directory to use instead and cleans it up after the test finishes.

[spalladino]

LGTM! For future reference, node's mkdtemp handles most of this on your behalf.

That aside, shouldn't we be always cleaning up the contents of ACVM working directory, not just in e2e tests or if it's a temp dir? If so, maybe we should place that logic somewhere else, like in a beforeexit?

[alexghr]

It wasn't obvious to me where this directory was created. Looks like it's created in getSimulationProider in the sequencer-client module.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (32): 124 (+303%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit fec10081 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668	18,852	36,420
l1_rollup_calldata_gas	66,280	238,104	470,172
l1_rollup_execution_gas	680,973	950,341	1,312,698
l2_block_processing_time_in_ms	1,352 (+6%)	4,682	8,897 (-5%)
note_successful_decrypting_time_in_ms	180 (-6%)	504 (-2%)	1,017 (+7%)
note_trial_decrypting_time_in_ms	86.4 (-11%)	⚠️ 124 (+303%)	50.1 (-39%)
l2_block_building_time_in_ms	17,796	67,138	133,073
l2_block_rollup_simulation_time_in_ms	8,018	28,425	55,595 (-1%)
l2_block_public_tx_process_time_in_ms	9,758 (+1%)	38,659	77,381

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,375 (+1%)	27,742 (+1%)
note_history_successful_decrypting_time_in_ms	1,246 (+2%)	2,569 (+4%)
note_history_trial_decrypting_time_in_ms	93.7 (+54%)	120 (-23%)
node_database_size_in_bytes	18,632,784	35,029,072
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	281	44,366	28,245
private-kernel-ordering	214	52,869	14,327
base-parity	1,869 (+3%)	128	311
base-rollup	713	165,788	925
root-parity	1,452 (-7%)	1,244	311
root-rollup	51.7	4,487	725
private-kernel-inner	643	73,772	28,245
public-kernel-app-logic	429 (+1%)	35,260	28,215
public-kernel-tail	173 (+1%)	40,926	28,215
merge-rollup	8.32	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.96	16.0	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.581 (-1%)	0.495	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.8	72.0	230	445	869	1,709	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.470	0.445	0.419	0.416	0.413	0.410	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.7	107 (+1%)	334	660	1,306	2,597	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.479	0.484 (+1%)	0.456	0.454	0.453	0.452	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.4 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.536 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,013

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,217 (-1%)	1,757

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	13.4 (+3%)	1,209 (+1%)

[PhilWindle]

LGTM! For future reference, node's mkdtemp handles most of this on your behalf.

That aside, shouldn't we be always cleaning up the contents of ACVM working directory, not just in e2e tests or if it's a temp dir? If so, maybe we should place that logic somewhere else, like in a beforeexit?

Yeah, we possibly should. Will take a look in another PR