feat: Simplify offsets and sizing using new block structure

[ledwards2225]

Fixes two small areas of brittleness using the newly introduced block and execution trace sorting work.

1. We no longer need the variable num_ecc_op_gates since this is equivalent to blocks.ecc_op.size() which is a safer representation of the number of goblin op gates.
2. We can compute pub_inputs_offset once and for all at the trace generation stage and avoid recomputing it elsewhere.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (64): 108 (+127%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 4c565367 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,412	6,412
l1_rollup_execution_gas	585,745	585,745	585,745
l2_block_processing_time_in_ms	1,329 (+3%)	4,744 (+2%)	9,451 (+4%)
note_successful_decrypting_time_in_ms	181 (+3%)	516 (+6%)	975 (-4%)
note_trial_decrypting_time_in_ms	83.4 (+4%)	34.3 (-68%)	⚠️ 108 (+127%)
l2_block_building_time_in_ms	17,433 (+1%)	65,634 (+1%)	129,986 (+1%)
l2_block_rollup_simulation_time_in_ms	8,036 (+1%)	28,369	55,728 (+1%)
l2_block_public_tx_process_time_in_ms	9,377 (+1%)	37,212 (+2%)	74,161 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,769 (-3%)	27,506 (+4%)
note_history_successful_decrypting_time_in_ms	1,214 (-4%)	2,385 (-3%)
note_history_trial_decrypting_time_in_ms	61.3 (-40%)	118 (-24%)
node_database_size_in_bytes	18,640,976	34,865,232
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	243	44,377	28,214
private-kernel-ordering	214	52,880	14,296
base-parity	4,635 (-1%)	128	311
root-parity	1,704 (+2%)	1,244	311
base-rollup	18,009	165,760	861
root-rollup	50.0 (+1%)	4,359	725
private-kernel-inner	602	73,794	28,214
public-kernel-app-logic	403	35,251	28,217
public-kernel-tail	175 (+1%)	40,928	28,217
merge-rollup	8.57 (-3%)	2,568	861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0 (+1%)	15.9	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.583 (+1%)	0.493	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.9	71.9 (-1%)	231	442	867	1,722 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.471	0.444 (-1%)	0.420	0.415	0.413	0.413	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.8	107	341 (+2%)	659 (+1%)	1,306	2,609	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.480	0.481	0.463 (+2%)	0.455 (+1%)	0.454	0.453	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.1
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.535

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,024

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,104 (-2%)	1,666

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	12.7 (+17%)	1,155

[maramihali]

nice!