fix(avm-simulator): hashing opcodes indirection

[fcarreiro]

Situation for hashes before this PR

The hash situation is quite peculiar. Noir defines its hashes as black box functions in the stdlib. However, the signature for most of them is not really good for bytecode/avm. E.g., they take and/or return u8s instead of Fields, some of them are permutations, others have separators, etc.

Moreover, Brillig preprocessing changes the signature to accept vectors (variable size at runtime) vs arrays (size known at runtime) for some of the black box functions.

The AVM defines:

• pedersen: it implements the blackbox function.
• the rest, are defined as oracles. This means that if a contract uses the stdlib (blackbox) hashes for these functions, it will not currently work with the avm. The definition as oracles is to have a (likely temporary) better signature for the hashes.

Some of the indirections in our pedersen opcode were handled incorrectly (the transpiler was assuming an array, not a vector).

After the PR

I started implementing all of the hashing opcodes from the blackbox functions but this was quite difficult to quickly do in TS. So for the moment I'm just fixing the indirection problems.

I also restricted getSlice to fail if called on undefined areas, which uncovered a few other bugs in tests.

[fcarreiro]

• feat(avm)!: per function avm run #5421
• feat(avm): add AvmContextInputs #5396
• fix(avm-simulator): hashing opcodes indirection #5376 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 933145e8 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,424	6,412
l1_rollup_execution_gas	585,745	585,757	585,745
l2_block_processing_time_in_ms	1,354 (+4%)	4,499 (-5%)	9,128 (-1%)
note_successful_decrypting_time_in_ms	174 (-6%)	515 (-1%)	966
note_trial_decrypting_time_in_ms	81.4 (-10%)	31.9 (-20%)	96.2 (+1%)
l2_block_building_time_in_ms	14,071 (+1%)	51,560	102,458
l2_block_rollup_simulation_time_in_ms	8,036 (+1%)	27,994 (-1%)	55,515
l2_block_public_tx_process_time_in_ms	6,011 (+2%)	23,514 (+1%)	46,848 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,809 (-1%)	26,421 (-1%)
note_history_successful_decrypting_time_in_ms	1,225 (-3%)	2,412 (-1%)
note_history_trial_decrypting_time_in_ms	94.3 (+4%)	120 (+2%)
node_database_size_in_bytes	18,669,648	34,959,440
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	237 (+1%)	44,377	28,214
private-kernel-ordering	208	52,880	14,296
base-parity	4,659 (-2%)	128	311
root-parity	1,567 (-3%)	1,244	311
base-rollup	17,955	165,760	861
root-rollup	50.0 (+1%)	4,359	725
private-kernel-inner	310 (+2%)	73,794	28,214
public-kernel-app-logic	127 (+2%)	35,251	28,217
public-kernel-tail	170 (+1%)	40,928	28,217
merge-rollup	8.57 (-7%)	2,568	861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.97	15.9 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.582	0.493 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.8 (+1%)	71.9 (-1%)	231	442	864	1,717	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.480 (+1%)	0.444 (-1%)	0.421	0.414	0.411	0.412	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.9 (-2%)	106	340	656 (-1%)	1,309	2,605	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.481 (-2%)	0.480	0.463	0.453	0.454	0.452	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.4 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.538 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,966	494,914

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,429 (+3%)	1,403 (+1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	15.4 (-7%)	732 (+1%)

[fcarreiro]

Merge activity

• Mar 25, 1:06 PM EDT: @fcarreiro merged this pull request with Graphite.