Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CLU response from Workflow resposnes #15160

Closed
wants to merge 180 commits into from
Closed

Separate CLU response from Workflow resposnes #15160

wants to merge 180 commits into from

Conversation

ChongTang
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

orkayam and others added 30 commits July 12, 2021 12:12
* add new resources

* Add resources to markdown

* Modify routes

* Add systemData

* Add systemData to defenderSettings

* Add missing parameter

* Add more systemData

* Fix example

* Add new API version

* Remove redundant change

* update markdown

* Add operations to new API version

* Update list filters

* update description

* update examples

* Update examples

* Add missing properties

* Add missing properties

* Rename property

Co-authored-by: Orel Kayam <orkayam@microsoft.com>
* sip routing API

* return 422 instead of 400

* change missing trunk error message

* add 'error' prefix in error examples

* describe patch behaviour

* use the standard Azure error

* remove unnecessary descriptions

* fix descriptions

* change fqdn max length

* remove locale from example params and change endpoint

* use the standard Azure error in examples

* unify tags

* use CommunicationServicesCommon/CommunicationErrorResponse

* refactor sip configuration patch into separate class

* fix CommunicationErrorResponse file path

* add x-ms-error-response flag

* add http errors schemas
…rt (#14725)

* Add FSPG GA location capability API with geo backup and restore support

* Renamed supportedIOPS to supportedIops and zoneRedundantHAandGeoBackupSupported to zoneRedundantHAAndGeoBackupSupported

* Change availabilityZone to create and read, change standbyAvailabilityZone to create, update, read

* Changed the camel case of zoneRedundantHaSupported and zoneRedundantHaAndGeoBackupSupported

* Fix LintDiff bug
…fication (#14671)

* Resume V2021-02-01-Preview BackupShortTermRetentionPolicies API Specification

* Prettier check fix

* comment

Co-authored-by: Lillian Liu <liulu@microsoft.com>
* add ingressStartAt

* prettier

* add a new example

* Delete .npmrc

remove .npmrc

* fix prettier

fix prettier

* put readonly back for kind

* Adding descriptin to ingressStartAt

* fix failure for python track2

* Removing readonly from kind

Co-authored-by: Go Blue <zth@umich.edu>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
* Update readme.python.md

* Update readme.md
* Update readme.python.md

* Update readme.md
…n stable/2021-06-15 (#14627)

* Adds base for updating Microsoft.DocumentDB from version stable/2021-04-15 to version 2021-06-15

* Updates readme

* Updates API version in new specs and examples

* PITR apis to stable version

* Fixing readme

* Adding parameters

* Fixing restorable.json

* Fixing linter errors

* missing ref

* Unflattening the DatabaseAccountCreateUpdateProperties

* Adds base for updating Microsoft.DocumentDB from version stable/2021-05-15 to version 2021-06-15

* Updates readme

* Updates API version in new specs and examples

* Adding the restorable json to readme

* Added disableLocalAuth flag to DatabaseAccount CRU operations.

* Adding Backup policy migration state

* Fixing linter errors

* Fixing linter warnings

* Fixing breaking change

Co-authored-by: ayanMSFT <53790657+ayanMSFT@users.noreply.github.com>
* sql t2 readme config

* readme config

* Update readme.python.md

* conflient resolve

* security t2 config

* modelerfour config

* Delete duplicate JSON files

* del test

* Update readme.md

* directive x-ms-enum

* delete redundant definition

Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
* copy 2016 version into 2020 folder to easily see diff

* add the changes from 2017 preview

* add dynamic scaling api and update api version to 2020

* add new version to readme

* remove accidental changes to 2017 folder

* fix streamingjobs.json

* fix operations api

* minor fixes

* address some review comments

* more validation fixes

* address comments

* fix breaking changes

* prettier fix

* update 2016

* fix some validation checks

* try to fix location/tags validation error

* fix lintdiff

* fix lintdiff warnings

* missed one

Co-authored-by: Roslyn Lu <roslu@microsoft.com>
* Init SignalR new Preview API version 2021-06-01-preview. Copy from 2021-04-01-preview

* init 2021-06-01-preview

* revert unneeded change

* revert unneeded change

* add property

* rename FQDN to Fqdn

* add missing example

* update authtype

* revert two properties

Co-authored-by: Binjie Qian <biqian@microsoft.com>
* update ReplicationLinks.json in 2021-02-01-preview

* update json file

* update examples/ReplicationLinkGet.json
* Adding stable swaggers

* change api version
* Add support for 2021-06-01-preview swagger

* Add 2021-10-15-preview as a baseline for this commit

* Add 2021-06-06-01-preview support

* fix example

* Remove example as path/operation is not used

* Update readme.python.md

* fix python pipeline failure

Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
…view' (#14753)

* Add 'Resource' definition in common types

* Export incidents resource to new preview API version

* New version for incidents and updated examples - team colaboration

* Extract alertRules and alertRuleTemplates endpoints and their related parameters and definition from 2019-01-01-preview/SecurityInsights.json

* New version for alert rules and updated examples - custom details, entity mappings and new incident grouping configuration

* Fix readme

* mark triggerUri secret

* Fix linting errors

Co-authored-by: Dor Siso <lisiso@microsoft.com>
Co-authored-by: Anat Gilenson <t-angile@microsoft.com>
Co-authored-by: Anat Gilenson <anatgilenson@microsoft.com>
* Add new fields

* prettier
* Remove File Server From AML Compute ARM

* Remove BatchAI
…ateParameters (#14452)

Co-authored-by: jimmypc92 <jimmypc92>
… preview (#14410)

* Adds base for updating Microsoft.DesktopVirtualization from version preview/2021-04-01-preview to version 2021-05-13-preview

* Updates readme

* Updates API version in new specs and examples

* add SAU and HPUpdate

* new routes and sh props, and shc last updated time
fix errors
update SAU
corect name sessionHostConfigurationLastUpdateTime and maintenance alert array
add faultType

* patch publicNetworkAccess

* minor description changes

* validate and initiate one endpoint, GET updateStatuses, GET validateStatuses

* long running and examples

* rename sessionhostconfigurations -> sessionhostconfigurations, hostpoolupdateparameters -> hostpoolupdateconfiguration

* make updateStatuses/current endpoint a proxy, updateValidationResults, updateResults

* fix system data and variable

* pr comments rename updateStatuses to updateDetails and remove unsupported state

* make status endpoints current

* pageable and list operation
more next link
more pagination
add refs of private link
more importing issues
undo breaking change
remove unused HostPoolUpdateValidationResponseList
prettier
add description

* system data for all
examples for all

* move shconfig to proxy obj

* add cancel message

* fix formatting

* add parameter

* philips pr comments

* fix examples

* move lastUpdate to shc proxy rename to version

* pr comments migrate to update

* add object type to private link

* remove object type for one

* change to default
…is/schemas (#14769)

* fixed ApiManagement/service/apis/schemas

* updated schema/document definition

Co-authored-by: Alan Feng <alanfeng@microsoft.com>
* Updating Swagger Correctness

* prettier fix

* Updating Go Readme for formatting

Co-authored-by: Adithya Jayachandran <adjayach@microsoft.com>
* Adding Communication CallingServer API preview1.

* Updated the Swagger to add PlayAudio api for out-call scenario (#14578)

* Updated the servercalling swagger with playAudio api for out-call
* Fixed a typo

Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>

* Add preview0 swagger for .net sdk.

* Update SDK Swagger preview0

* Update swagger api version.

* Update swagger api version.

* Removed Model and Internal postfix, added events in swagger (#14639)

* Removed Model and Internal postfix, added events in swagger

* update the title

* Add swagger for version 2021-06-15 (#14720)

* Updated swagger with version 2021-06-15

* Fix the Communication.Common definitions path

* Removed old swagger

* Added unhold to list of custom-word

* Update readme file accourding to new swagger.

* update responses model suffix to result

* Removed error responses and consumes/produces values from all the apis. Changed invite participant to add participant. Other model name related changes.

* Added examples for all the apis.

* Removed error responses from example

* Added back error response type, added response body for add participant operation

* Fix join call example

* Update the examples

Co-authored-by: Paresh Arvind Patil <patilaparesh@gmail.com>
Co-authored-by: Paresh Arvind Patil <papati@microsoft.com>
Co-authored-by: navali-msft <66667092+navali-msft@users.noreply.github.com>
Co-authored-by: Naveed Ali <navali@microsoft.com>
Co-authored-by: orenmichaely <73134189+ormichae@users.noreply.github.com>
* Update swaggers for logs and metrics queries

* Update version

* add missing fields

* include statistics

* include statistics

* statistics in log query result

* Include metrics namespace param

* Update title and client name

* Include namespace param

* Add namespace and region

* Fix top and orderby query params

* Fix linting errors

* Update security to oauth2

* Revert metrics changes

* Update path

* add batch sample

* Update query body

* Address PR comments

* Add error info for single query response

* Include batch example

* update batch results

* rendering response as object

* Update row value type to object

* update security definition to oauth2
* adding new api version 2021-05-01-preview

* Addng missing bracket

* Fix formatting

* Formatting

* Fix fields

* Fix merge conflicts and systemData

* Fix prettier

* Fix systemData

* Fix pr comments from ARM team.

* Fix tab

* Address ARM PR comment round 2

* Fix systemData and revert 2017-05-01-preview mistake

* Fix location in samples

* fix prettier

* Fix type lint errors

* Type fix

* One last missing object type

* Revert ErrorResponse change as it's breaking change

Co-authored-by: Phoenix He <tih@microsoft.com>
This was referenced Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.