add max bound for application gateway autoscale config #4996

KaiChiLin · 2019-01-07T19:06:29Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-01-07T19:07:28Z

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmp8ypn0v40/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmp8ypn0v40/azure-sdk-for-js', '--use=@microsoft.azure/autorest.typescript@2.1.1']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (2.1.1->2.1.1)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)
FATAL: System.InvalidOperationException: Found incompatible property types Object, Object for property 'tags' in schema inheritance chain
   at AutoRest.Modeler.SchemaResolver.ExpandAllOf(Schema schema) in c:\publish\autorest.modeler\src\SchemaResolver.cs:line 157
   at AutoRest.Modeler.SchemaResolver.Unwrap(Schema schema) in c:\publish\autorest.modeler\src\SchemaResolver.cs:line 75
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in c:\publish\autorest.modeler\src\SchemaBuilder.cs:line 35
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in c:\publish\autorest.modeler\src\SwaggerModeler.cs:line 348
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in c:\publish\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in c:\publish\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: typescript/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
  Error: Plugin imodeler1 reported failure.

azuresdkci · 2019-01-07T19:07:59Z

Can one of the admins verify this patch?

AutorestCI · 2019-01-07T19:08:28Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpg3fg6fou/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpg3fg6fou/azure-sdk-for-node', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.1.121']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.121->2.1.121)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
FATAL: System.InvalidOperationException: Found incompatible property types Object, Object for property 'tags' in schema inheritance chain
   at AutoRest.Modeler.SchemaResolver.ExpandAllOf(Schema schema) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaResolver.cs:line 157
   at AutoRest.Modeler.SchemaResolver.Unwrap(Schema schema) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaResolver.cs:line 75
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 35
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SwaggerModeler.cs:line 310
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: nodejs/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
  Error: Plugin imodeler1 reported failure.

AutorestCI · 2019-01-07T19:11:56Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-01-07T19:20:37Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2019-01-07T19:27:08Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2019-01-07T20:03:13Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

…zure#5045)

* Adds base for updating Microsoft.Network from version stable/2018-11-01 to version 2018-12-01 * Updates readme * Updates API version in new specs and examples * fixing invalid paths in frontdoor (#4991) * add max bound for application gateway autoscale config (#4996) * fixing location in network samples (#4992) * Fix duplicate path in old Network API versions (#5003) * missing location in route tables (#5024) * removed confusing readonly parameters from example (#5022) * Fix errors in ddosCustomPolicy.json (#5013) * Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01 * Pick AppGw changes from 2018-11-01 (#5044) * Adding the structure of ruleSequence and conditions in rewriteRuleSets under applicationGatewayProperties (#5009) * Added Prepare action for subnet (#5058) * Added Prepare action documentation * Took carte of the errors from the validation tool * Error fixes from validation tool * Adding a typo and a missing property * updated the destination address description to also include service tags (#5112) * Update for Get Application Gateway Server Variables APIs (#5113) * Changes in the existing APIs result format. * adding proxyresource to server variables APIs result * Updating applicationgateway.json * Update applicationGateway.json * add Go SDK build for 2018-12-01 * changes to pythonand ruby readme files * Update readme.ruby.md * adding jave readme changes * Minor Fix in spacing * Creating a new tag for 2018-12 version * Update readme.python.md * Update applicationGateway.json * fixing examples * examples * Fixed issue: #4721 (#5087) * Fixed issue: #4721 * Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01 * Threat Intel changes for Azure Firewall (#5143) * Threat Intel changes for Azure Firewall * Move the property to the end of the list * Fix typos in Network 2018-12-01

add max bound for application gateway autoscale config

0ba4733

KaiChiLin requested a review from MikhailTryakhov as a code owner January 7, 2019 19:06

kpajdzik added the review label Jan 7, 2019

azuresdkci assigned jianghaolu Jan 7, 2019

azuresdkci requested a review from jianghaolu January 7, 2019 19:07

AutorestCI mentioned this pull request Jan 7, 2019

[AutoPR network/resource-manager] add max bound for application gateway autoscale config Azure/azure-sdk-for-go#3808

Closed

jianghaolu approved these changes Jan 7, 2019

View reviewed changes

jianghaolu merged commit 4906929 into Azure:network-january-release Jan 7, 2019

anton-evseev mentioned this pull request Jan 16, 2019

Port AppGw changes from 2018-11-01 into 2018-12-01 #5044

Merged

5 tasks

anton-evseev pushed a commit to anton-evseev/azure-rest-api-specs that referenced this pull request Jan 16, 2019

add max bound for application gateway autoscale config (Azure#4996)

1d2275a

anton-evseev mentioned this pull request Jan 16, 2019

Cherry pick AppGw changes into master #5045

Merged

5 tasks

jianghaolu pushed a commit that referenced this pull request Jan 22, 2019

add max bound for application gateway autoscale config (#4996) (#5045)

b1d23a5

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019

add max bound for application gateway autoscale config (Azure#4996) (A…

15b2b80

…zure#5045)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add max bound for application gateway autoscale config #4996

add max bound for application gateway autoscale config #4996

KaiChiLin commented Jan 7, 2019

AutorestCI commented Jan 7, 2019 •

edited

Loading

azuresdkci commented Jan 7, 2019

AutorestCI commented Jan 7, 2019 •

edited

Loading

AutorestCI commented Jan 7, 2019 •

edited

Loading

AutorestCI commented Jan 7, 2019 •

edited

Loading

AutorestCI commented Jan 7, 2019 •

edited

Loading

AutorestCI commented Jan 7, 2019 •

edited

Loading

add max bound for application gateway autoscale config #4996

add max bound for application gateway autoscale config #4996

Conversation

KaiChiLin commented Jan 7, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Jan 7, 2019 • edited Loading

Automation for azure-sdk-for-js

azuresdkci commented Jan 7, 2019

AutorestCI commented Jan 7, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jan 7, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jan 7, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jan 7, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jan 7, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jan 7, 2019 •

edited

Loading

AutorestCI commented Jan 7, 2019 •

edited

Loading

AutorestCI commented Jan 7, 2019 •

edited

Loading

AutorestCI commented Jan 7, 2019 •

edited

Loading

AutorestCI commented Jan 7, 2019 •

edited

Loading

AutorestCI commented Jan 7, 2019 •

edited

Loading