Update for Get Application Gateway Server Variables APIs #5113

nirkum18 · 2019-01-30T08:53:19Z

Latest improvements:

This is a breaking change. Get Application Gateway Server Variables APIs changes were merged in 2018-11-01. We want the APIs results to be of type List(string) rather than Dictionay(string,List)
Link to previous PR: #4916

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-01-30T08:54:20Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#1042

AutorestCI · 2019-01-30T08:55:15Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4615

azuresdkci · 2019-01-30T08:56:42Z

Can one of the admins verify this patch?

AutorestCI · 2019-01-30T08:59:11Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2203

AutorestCI · 2019-01-30T09:07:35Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#4282

AutorestCI · 2019-01-30T09:13:45Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpcfdivak4/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpcfdivak4/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '--use=@microsoft.azure/autorest.go@~2.1.127', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Including configuration file 'file:///tmp/tmpcfdivak4/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.127->2.1.127)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-12"} .
   Including configuration file 'file:///tmp/tmpcfdivak4/rest/specification/network/resource-manager/readme.go.md'
Processing batch task - {"tag":"package-2018-10"} .
   Including configuration file 'file:///tmp/tmpcfdivak4/rest/specification/network/resource-manager/readme.go.md'
Shutting Down
FATAL: go/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Failure during batch task - {"tag":"package-2018-10"} -- false.

AutorestCI · 2019-01-30T09:50:03Z

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2897

dsgouda · 2019-01-30T17:15:08Z

Working on some high pri .NET deliverables, reassigning

sergey-shandar · 2019-01-31T00:16:28Z

@nirkum18 could you also add 2018-12 tags to python, ruby, and java?

sanjaiganesh · 2019-01-31T01:35:50Z

@KrisBash (on ARM side) shall be looking into this. This is a breaking change.

sergey-shandar

readme files for Go and other languages has to be fixed before merge.

jhendrixMSFT · 2019-01-31T19:06:32Z

@AutorestCI regenerate azure-sdk-for-go

…/azure-rest-api-specs into network-january-release

nirkum18 · 2019-01-31T20:00:22Z

@nirkum18 could you also add 2018-12 tags to python, ruby, and java?

Made changes to readme.python.md and readme.ruby.md. I see we don't have readme file for java in Network.

…/azure-rest-api-specs into network-january-release

jhendrixMSFT · 2019-01-31T20:42:51Z

@sarangan12 for ruby build failure.

sergey-shandar · 2019-02-04T22:45:59Z

@nirkum18 could you also check these errors https://travis-ci.org/Azure/azure-rest-api-specs/jobs/488714091 ?

sarangan12 · 2019-02-04T22:48:12Z

@sergey-shandar The Linter Diff tool does not have enough memory to run in Travis CI and it is failing. As a temporary solution, I have executed the tool locally, and here is the result:

Config file: specification/network/resource-manager/readme.md

SDK Errors/Warnings

Errors: Before: 0 - After: 0
Warnings: Before: 165 - After: 162
New SDK Errors: 0
New SDK Warnings: 0
Existing SDK Errors: 0
Existing SDK Warnings: 0

ARM Errors/Warnings

Errors: Before: 0 - After: 0
Warnings: Before: 0 - After: 0
New ARM Errors: 0
New ARM Warnings: 0
Existing ARM Errors: 0
Existing ARM Warnings: 0

So, if you are ok with all the other things, then you can merge these changes.

* Adds base for updating Microsoft.Network from version stable/2018-11-01 to version 2018-12-01 * Updates readme * Updates API version in new specs and examples * fixing invalid paths in frontdoor (#4991) * add max bound for application gateway autoscale config (#4996) * fixing location in network samples (#4992) * Fix duplicate path in old Network API versions (#5003) * missing location in route tables (#5024) * removed confusing readonly parameters from example (#5022) * Fix errors in ddosCustomPolicy.json (#5013) * Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01 * Pick AppGw changes from 2018-11-01 (#5044) * Adding the structure of ruleSequence and conditions in rewriteRuleSets under applicationGatewayProperties (#5009) * Added Prepare action for subnet (#5058) * Added Prepare action documentation * Took carte of the errors from the validation tool * Error fixes from validation tool * Adding a typo and a missing property * updated the destination address description to also include service tags (#5112) * Update for Get Application Gateway Server Variables APIs (#5113) * Changes in the existing APIs result format. * adding proxyresource to server variables APIs result * Updating applicationgateway.json * Update applicationGateway.json * add Go SDK build for 2018-12-01 * changes to pythonand ruby readme files * Update readme.ruby.md * adding jave readme changes * Minor Fix in spacing * Creating a new tag for 2018-12 version * Update readme.python.md * Update applicationGateway.json * fixing examples * examples * Fixed issue: #4721 (#5087) * Fixed issue: #4721 * Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01 * Threat Intel changes for Azure Firewall (#5143) * Threat Intel changes for Azure Firewall * Move the property to the end of the list * Fix typos in Network 2018-12-01

nirkum18 added 2 commits January 30, 2019 03:21

Changes in the existing APIs result format.

c6b9d9a

adding proxyresource to server variables APIs result

4cfc108

nirkum18 requested a review from MikhailTryakhov as a code owner January 30, 2019 08:53

azuresdkci assigned dsgouda Jan 30, 2019

azuresdkci requested a review from dsgouda January 30, 2019 08:54

dsgouda added the Reassign label Jan 30, 2019

azuresdkci removed the Reassign label Jan 30, 2019

azuresdkci assigned sergey-shandar and unassigned dsgouda Jan 30, 2019

azuresdkci requested a review from sergey-shandar January 30, 2019 17:37

nirkum18 added 2 commits January 31, 2019 00:32

Updating applicationgateway.json

75550ea

Update applicationGateway.json

df47719

AutorestCI mentioned this pull request Jan 30, 2019

[AutoPR network/resource-manager] Update for Get Application Gateway Server Variables APIs Azure/azure-sdk-for-js#1042

Merged

sergey-shandar added potential-sdk-breaking-change DoNotMerge <valid label in PR review process> use to hold merge after approval labels Jan 30, 2019

sergey-shandar changed the title ~~Update for Get Application Gateway Server Variables APIs~~ [Don't merge yet] Update for Get Application Gateway Server Variables APIs Jan 30, 2019

add Go SDK build for 2018-12-01

a5255e7

nirkum18 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 30, 2019

AutorestCI mentioned this pull request Jan 31, 2019

[AutoPR network/resource-manager] Update for Get Application Gateway Server Variables APIs Azure/azure-sdk-for-node#4615

Merged

sanjaiganesh requested a review from KrisBash January 31, 2019 01:28

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 31, 2019

sergey-shandar removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 31, 2019

sergey-shandar changed the title ~~[Don't merge yet] Update for Get Application Gateway Server Variables APIs~~ Update for Get Application Gateway Server Variables APIs Jan 31, 2019

sergey-shandar suggested changes Jan 31, 2019

View reviewed changes

AutorestCI mentioned this pull request Jan 31, 2019

[AutoPR network/resource-manager] Update for Get Application Gateway Server Variables APIs Azure/azure-sdk-for-go#3983

Closed

nirkum18 and others added 3 commits February 1, 2019 01:02

changes to pythonand ruby readme files

56ef285

Merge branch 'network-january-release' of https://github.com/nirkum18…

0df7a66

…/azure-rest-api-specs into network-january-release

Update readme.ruby.md

f2fca4d

AutorestCI mentioned this pull request Jan 31, 2019

[AutoPR network/resource-manager] Update for Get Application Gateway Server Variables APIs Azure/azure-sdk-for-python#4282

Merged

nirkum18 added 2 commits February 1, 2019 02:08

adding jave readme changes

d020b94

Merge branch 'network-january-release' of https://github.com/nirkum18…

60575d3

…/azure-rest-api-specs into network-january-release

AutorestCI mentioned this pull request Jan 31, 2019

[AutoPR network/resource-manager] Update for Get Application Gateway Server Variables APIs Azure/azure-sdk-for-java#2897

Merged

sergey-shandar approved these changes Feb 4, 2019

View reviewed changes

sarangan12 added 2 commits February 4, 2019 11:31

Minor Fix in spacing

a50b00e

Creating a new tag for 2018-12 version

2055e4d

AutorestCI mentioned this pull request Feb 4, 2019

[AutoPR network/resource-manager] Update for Get Application Gateway Server Variables APIs Azure/azure-sdk-for-ruby#2203

Merged

nirkum18 added 2 commits February 5, 2019 02:01

Update readme.python.md

d0f9972

Update applicationGateway.json

461be76

nirkum18 added 2 commits February 5, 2019 14:54

fixing examples

e2daf92

examples

b7b09dc

nirkum18 mentioned this pull request Feb 5, 2019

Get Application Gateway Server Variables APIs changes for 2018-11-01 #5157

Closed

5 tasks

sergey-shandar merged commit e7a48d7 into Azure:network-january-release Feb 5, 2019

nirkum18 mentioned this pull request Feb 25, 2019

Application Gateway support for Get Server Variables APIs Azure/azure-cli#8290

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update for Get Application Gateway Server Variables APIs #5113

Update for Get Application Gateway Server Variables APIs #5113

nirkum18 commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading

azuresdkci commented Jan 30, 2019

AutorestCI commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading

dsgouda commented Jan 30, 2019

sergey-shandar commented Jan 31, 2019

sanjaiganesh commented Jan 31, 2019

sergey-shandar left a comment

jhendrixMSFT commented Jan 31, 2019

nirkum18 commented Jan 31, 2019

jhendrixMSFT commented Jan 31, 2019

sergey-shandar commented Feb 4, 2019

sarangan12 commented Feb 4, 2019

Update for Get Application Gateway Server Variables APIs #5113

Update for Get Application Gateway Server Variables APIs #5113

Conversation

nirkum18 commented Jan 30, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Jan 30, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jan 30, 2019 • edited Loading

Automation for azure-sdk-for-node

azuresdkci commented Jan 30, 2019

AutorestCI commented Jan 30, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jan 30, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jan 30, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jan 30, 2019 • edited Loading

Automation for azure-sdk-for-java

dsgouda commented Jan 30, 2019

sergey-shandar commented Jan 31, 2019

sanjaiganesh commented Jan 31, 2019

sergey-shandar left a comment

Choose a reason for hiding this comment

jhendrixMSFT commented Jan 31, 2019

nirkum18 commented Jan 31, 2019

jhendrixMSFT commented Jan 31, 2019

sergey-shandar commented Feb 4, 2019

sarangan12 commented Feb 4, 2019

SDK Errors/Warnings

ARM Errors/Warnings

nirkum18 commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading

AutorestCI commented Jan 30, 2019 •

edited

Loading