-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port AppGw changes from 2018-11-01 into 2018-12-01 #5044
Port AppGw changes from 2018-11-01 into 2018-12-01 #5044
Conversation
Automation for azure-sdk-for-jsA PR has been created for you: |
Automation for azure-sdk-for-nodeEncountered a Subprocess error: (azure-sdk-for-node)
Command: ['/usr/local/bin/autorest', '/tmp/tmp5v7x2w_6/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp5v7x2w_6/azure-sdk-for-node', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.1.121'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4289/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.121->2.1.121)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated. |
Need to get #5013 in first |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f8b4cfe
to
1fb2733
Compare
@dsgouda can you please merge this? CI fails with OOM again |
@dsgouda nvm, restarting CI multiple times helped it pass. All green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Adds base for updating Microsoft.Network from version stable/2018-11-01 to version 2018-12-01 * Updates readme * Updates API version in new specs and examples * fixing invalid paths in frontdoor (#4991) * add max bound for application gateway autoscale config (#4996) * fixing location in network samples (#4992) * Fix duplicate path in old Network API versions (#5003) * missing location in route tables (#5024) * removed confusing readonly parameters from example (#5022) * Fix errors in ddosCustomPolicy.json (#5013) * Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01 * Pick AppGw changes from 2018-11-01 (#5044) * Adding the structure of ruleSequence and conditions in rewriteRuleSets under applicationGatewayProperties (#5009) * Added Prepare action for subnet (#5058) * Added Prepare action documentation * Took carte of the errors from the validation tool * Error fixes from validation tool * Adding a typo and a missing property * updated the destination address description to also include service tags (#5112) * Update for Get Application Gateway Server Variables APIs (#5113) * Changes in the existing APIs result format. * adding proxyresource to server variables APIs result * Updating applicationgateway.json * Update applicationGateway.json * add Go SDK build for 2018-12-01 * changes to pythonand ruby readme files * Update readme.ruby.md * adding jave readme changes * Minor Fix in spacing * Creating a new tag for 2018-12 version * Update readme.python.md * Update applicationGateway.json * fixing examples * examples * Fixed issue: #4721 (#5087) * Fixed issue: #4721 * Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01 * Threat Intel changes for Azure Firewall (#5143) * Threat Intel changes for Azure Firewall * Move the property to the end of the list * Fix typos in Network 2018-12-01
Port Application Gateway changes from #4996 into 2018-12-01
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.