Added Prepare action for subnet #5058

Am018 · 2019-01-17T20:16:15Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-01-17T20:17:22Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_network-january-release
  stderr: 'To https://github.com/Azure/azure-sdk-for-js.git
 ! [rejected]          restapi_auto_network-january-release -> restapi_auto_network-january-release (fetch first)
error: failed to push some refs to 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-js.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

AutorestCI · 2019-01-17T20:18:10Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_network-january-release
  stderr: 'To https://github.com/Azure/azure-sdk-for-node.git
 ! [rejected]            restapi_auto_network-january-release -> restapi_auto_network-january-release (fetch first)
error: failed to push some refs to 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-node.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

AutorestCI · 2019-01-17T20:21:46Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-01-17T20:30:34Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

azuresdkci · 2019-01-17T20:31:26Z

Can one of the admins verify this patch?

AutorestCI · 2019-01-17T20:37:03Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2019-01-17T21:43:51Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

anton-evseev · 2019-01-18T06:30:18Z

CI failure is caused by incorrect specs, this PR fixes it: #5013

jianghaolu · 2019-01-18T07:33:09Z

Will wait for 5013 to be merged to re run ci

specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/virtualNetwork.json

…network-january-release

Am018 · 2019-01-22T19:42:41Z

Can this PR be merged now since all the checks are passing and I have taken care of all the comments?

Am018 · 2019-01-22T20:19:18Z

Thanks @jianghaolu

* Adds base for updating Microsoft.Network from version stable/2018-11-01 to version 2018-12-01 * Updates readme * Updates API version in new specs and examples * fixing invalid paths in frontdoor (#4991) * add max bound for application gateway autoscale config (#4996) * fixing location in network samples (#4992) * Fix duplicate path in old Network API versions (#5003) * missing location in route tables (#5024) * removed confusing readonly parameters from example (#5022) * Fix errors in ddosCustomPolicy.json (#5013) * Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01 * Pick AppGw changes from 2018-11-01 (#5044) * Adding the structure of ruleSequence and conditions in rewriteRuleSets under applicationGatewayProperties (#5009) * Added Prepare action for subnet (#5058) * Added Prepare action documentation * Took carte of the errors from the validation tool * Error fixes from validation tool * Adding a typo and a missing property * updated the destination address description to also include service tags (#5112) * Update for Get Application Gateway Server Variables APIs (#5113) * Changes in the existing APIs result format. * adding proxyresource to server variables APIs result * Updating applicationgateway.json * Update applicationGateway.json * add Go SDK build for 2018-12-01 * changes to pythonand ruby readme files * Update readme.ruby.md * adding jave readme changes * Minor Fix in spacing * Creating a new tag for 2018-12 version * Update readme.python.md * Update applicationGateway.json * fixing examples * examples * Fixed issue: #4721 (#5087) * Fixed issue: #4721 * Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01 * Threat Intel changes for Azure Firewall (#5143) * Threat Intel changes for Azure Firewall * Move the property to the end of the list * Fix typos in Network 2018-12-01

Amol Bhattad added 3 commits January 16, 2019 17:04

Added Prepare action documentation

4fe7e2e

Took carte of the errors from the validation tool

0564e72

Error fixes from validation tool

7628251

Am018 requested a review from MikhailTryakhov as a code owner January 17, 2019 20:16

azuresdkci assigned jianghaolu Jan 17, 2019

azuresdkci requested a review from jianghaolu January 17, 2019 20:38

jianghaolu approved these changes Jan 18, 2019

View reviewed changes

nschonni reviewed Jan 18, 2019

View reviewed changes

specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/virtualNetwork.json Outdated Show resolved Hide resolved

Amol Bhattad added 2 commits January 20, 2019 22:57

Adding a typo and a missing property

1ed5f48

Merge remote-tracking branch 'upstream/network-january-release' into …

2cb3094

…network-january-release

This was referenced Jan 21, 2019

[AutoPR network/resource-manager] Added Prepare action for subnet Azure/azure-sdk-for-js#960

Closed

[AutoPR network/resource-manager] Added Prepare action for subnet Azure/azure-sdk-for-node#4578

Closed

jianghaolu merged commit 3ded879 into Azure:network-january-release Jan 22, 2019

Am018 deleted the network-january-release branch January 22, 2019 20:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Prepare action for subnet #5058

Added Prepare action for subnet #5058

Am018 commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading

azuresdkci commented Jan 17, 2019

AutorestCI commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading

anton-evseev commented Jan 18, 2019

jianghaolu commented Jan 18, 2019

Am018 commented Jan 22, 2019

Am018 commented Jan 22, 2019

Added Prepare action for subnet #5058

Added Prepare action for subnet #5058

Conversation

Am018 commented Jan 17, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Jan 17, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jan 17, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jan 17, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jan 17, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Jan 17, 2019

AutorestCI commented Jan 17, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jan 17, 2019 • edited Loading

Automation for azure-sdk-for-java

anton-evseev commented Jan 18, 2019

jianghaolu commented Jan 18, 2019

Am018 commented Jan 22, 2019

Am018 commented Jan 22, 2019

Am018 commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading

AutorestCI commented Jan 17, 2019 •

edited

Loading