New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed confusing readonly parameters from example #5022

Merged

dsgouda merged 1 commit into Azure:network-january-release from zikalino:virtual-network-gateway-remove-readonly

Jan 14, 2019

zikalino commented Jan 11, 2019

Removed parameters that are readonly and unnecessary when creating Virtual Network Gateway:

etag
id
capacity (always set to 2 by the service, any other value passed is ignored)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.


          removed confusing readonly parameters from example

2f27c64

zikalino requested a review from MikhailTryakhov as a code owner

January 11, 2019 08:33

AutorestCI commented Jan 11, 2019 •

edited

Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

AutorestCI commented Jan 11, 2019 •

edited

Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

AutorestCI commented Jan 11, 2019 •

edited

Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

AutorestCI commented Jan 11, 2019 •

edited

Loading

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

AutorestCI commented Jan 11, 2019 •

edited

Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

AutorestCI commented Jan 11, 2019 •

edited

Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

Contributor

azuresdkci commented Jan 11, 2019

Can one of the admins verify this patch?

azuresdkci assigned dsgouda

azuresdkci requested a review from dsgouda

January 11, 2019 08:35

dsgouda approved these changes

View reviewed changes

Contributor

dsgouda left a comment

LGTM

Contributor

dsgouda commented Jan 11, 2019

@MikhailTryakhov do you know if this is an expected linter failure?

Contributor

anton-evseev commented Jan 14, 2019

@dsgouda this is the same error my PR has (#5013) - OutOfMemory exception in node.js. It seems that Network specs became too heavy.

When we first encountered this issue Autorest team suggested to use node 10+ as it has better memory management. Upgrading to 10.15.0 LTS indeed helped us.

This repo's CI uses node version 8. Perhaps upgrading to version 10 would help

dsgouda merged commit 7be29f9 into Azure:network-january-release

sergey-shandar pushed a commit that referenced this pull request


          Merge Network release branch into master (#5189)

e209e79

* Adds base for updating Microsoft.Network from version stable/2018-11-01 to version 2018-12-01

* Updates readme

* Updates API version in new specs and examples

* fixing invalid paths in frontdoor (#4991)

* add max bound for application gateway autoscale config (#4996)

* fixing location in network samples (#4992)

* Fix duplicate path in old Network API versions (#5003)

* missing location in route tables (#5024)

* removed confusing readonly parameters from example (#5022)

* Fix errors in ddosCustomPolicy.json (#5013)

* Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008)

* Update ddosCustomPolicy.json in 2018-12-01

* Pick AppGw changes from 2018-11-01 (#5044)

* Adding the structure of ruleSequence and conditions in rewriteRuleSets under applicationGatewayProperties (#5009)

* Added Prepare action for subnet (#5058)

* Added Prepare action documentation

* Took carte of the errors from the validation tool

* Error fixes from validation tool

* Adding a typo and a missing property

* updated the destination address description to also include service tags (#5112)

* Update for Get Application Gateway Server Variables APIs (#5113)

* Changes in the existing APIs result format.

* adding proxyresource to server variables APIs result

* Updating applicationgateway.json

* Update applicationGateway.json

* add Go SDK build for 2018-12-01

* changes to pythonand ruby readme files

* Update readme.ruby.md

* adding jave readme changes

* Minor Fix in spacing

* Creating a new tag for 2018-12 version

* Update readme.python.md

* Update applicationGateway.json

* fixing examples

* examples

* Fixed issue: #4721 (#5087)

* Fixed issue: #4721

* Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01

* Threat Intel changes for Azure Firewall (#5143)

* Threat Intel changes for Azure Firewall

* Move the property to the end of the list

* Fix typos in Network 2018-12-01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet